INSERT INTO - Data is not inserted - Using #temp table to populate actual table

[ImraneA]

Hi there

Application : Access v2K/SQL 2K

Jest : Using sproc to append records into SQL table

Jest sproc :
1.Can have more than 1 record - so using ';' to separate each line
from each other.

2.Example of data

'HARLEY.I',0300 4,'A000-AA00',2003-08-29,0,0,7.5,7.5, 7.5,7.5,7.0,'No tes','General', 1,2,3;'HARLEY.I ',03004,'A000-AA00',2003-08-29,0,0,7.5,7.5, 7.5,7.5,7.0,'No tes','General', 1,2,3;

3.Problem - gets to line

BEGIN TRAN <---------- skips
rest
INSERT INTO timesheet.dbo.t able1

4.Checked permissions for table + sproc - ok

What am I doing wrong ?

Any comments most helpful......
CREATE PROCEDURE [dbo].[procTimesheetIn sert_Testing](
@TimesheetDetai ls varchar(5000) = NULL,
@RetCode int = NULL OUTPUT,
@RetMsg varchar(100) = NULL OUTPUT,
@TimesheetID int = NULL OUTPUT)
WITH RECOMPILE
AS
SET NOCOUNT ON
DECLARE @SQLBase varchar(8000), @SQLBase1 varchar(8000)
DECLARE @SQLComplete varchar(8000) ,@SQLComplete1 varchar(8000)
DECLARE @TimesheetCount int, @TimesheetCount 1 int
DECLARE @TS_LastEdit smalldatetime
DECLARE @Last_Editby smalldatetime
DECLARE @User_Confirm bit
DECLARE @User_Confirm_D ate smalldatetime
DECLARE @DetailCount int
DECLARE @Error int
/* Validate input parameters. Assume success. */

SELECT @RetCode = 1, @RetMsg = ''

IF @TimesheetDetai ls IS NULL
SELECT @RetCode = 0,
@RetMsg = @RetMsg +
'Timesheet line item(s) required.' + CHAR(13) + CHAR(10)

/* Create a temp table parse out each Timesheet detail from input
parameter string,
count number of detail records and create SQL statement to
insert detail records into the temp table. */
CREATE TABLE #tmpTimesheetDe tails
(
RE_Code varchar(50),
PR_Code varchar(50),
AC_Code varchar(50),
WE_Date smalldatetime,
SAT REAL DEFAULT 0,
SUN REAL DEFAULT 0,
MON REAL DEFAULT 0,
TUE REAL DEFAULT 0,
WED REAL DEFAULT 0,
THU REAL DEFAULT 0,
FRI REAL DEFAULT 0,
Notes varchar(255),
General varchar(50),
PO_Number REAL,
WWL_Number REAL,
CN_Number REAL)

SELECT @SQLBase ='INSERT INTO
#tmpTimesheetDe tails(RE_Code,P R_Code,AC_Code, WE_Date,SAT,SUN ,MON,TUE,WED,TH U,FRI,Notes,Gen eral,PO_Number, WWL_Number,CN_N umber)
VALUES ( '
SELECT @TimesheetCount =0
WHILE LEN( @TimesheetDetai ls) > 1
BEGIN
SELECT @SQLComplete = @SQLBase + LEFT( @TimesheetDetai ls,
Charindex(';', @TimesheetDetai ls) -1) + ')'
EXEC(@SQLComple te)
SELECT @TimesheetCount = @TimesheetCount + 1
SELECT @TimesheetDetai ls = RIGHT( @TimesheetDetai ls, Len(
@TimesheetDetai ls)-Charindex(';', @TimesheetDetai ls))
END

IF (SELECT Count(*) FROM #tmpTimesheetDe tails) <> @TimesheetCount
SELECT @RetCode = 0, @RetMsg = @RetMsg + 'Timesheet Details
couldn''t be saved.' + CHAR(13) + CHAR(10)

-- If validation failed, exit proc
IF @RetCode = 0
RETURN

-- If validation ok, continue
SELECT @RetMsg = @RetMsg + 'Timesheet Details ok.' + CHAR(13) +
CHAR(10)
/* RETURN*/

-- Start transaction by inserting into Timesheet table
BEGIN TRAN
INSERT INTO timesheet.dbo.t able1
select RE_Code,PR_Code ,AC_Code,WE_Dat e,SAT,SUN,MON,T UE,WED,THU,FRI, Notes,General,P O_Number,WWL_Nu mber,CN_Number
FROM #tmpTimesheetDe tails

-- Check if insert succeeded. If so, get ID.
IF @@ROWCOUNT = 1
SELECT @TimesheetID = @@IDENTITY
ELSE
SELECT @TimesheetID = 0,
@RetCode = 0,
@RetMsg = 'Insertion of new Timesheet failed.'

-- If order is not inserted, rollback and exit
IF @RetCode = 0
BEGIN
ROLLBACK TRAN
-- RETURN
END

--RETURN

SELECT @Error =@@error
print ''
print "The value of @error is " + convert (varchar, @error)
return
GO

[Erland Sommarskog]

ImraneA (i.*****@weir.c o.uk) writes:

1.Can have more than 1 record - so using ';' to separate each line
from each other.
But yet in the procedure you have:
INSERT INTO timesheet.dbo.t able1
select E_Code, PR_Code, C_Code, WE_Date, SAT,SUN, MON, TUE,
WED, THU, FRI, Notes, General, PO_Number, WWL_Number, CN_Number
FROM #tmpTimesheetDe tails

-- Check if insert succeeded. If so, get ID.
IF @@ROWCOUNT = 1
SELECT @TimesheetID = @@IDENTITY
The test data you supplied produced two rows, so you wind up in
ELSE
SELECT @TimesheetID = 0,
@RetCode = 0,
@RetMsg = 'Insertion of new Timesheet failed.'

And rollback the whole affair.

--
Erland Sommarskog, SQL Server MVP, so****@algonet. se

Books Online for SQL Server SP3 at
http://www.microsoft.com/sql/techinf...2000/books.asp

[Imrane Akram]

Hi there

After looking at your comments - you were correct. Been working on main
body of sproc very intensively, got to end logic went abit astray.

Fixed that - ok.

Thanks.


*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!