Recursive FTP script problem

[AlunDavies]

Hi,

I'm working on a system that recurses through a given directory, ftp-ing all the contents up to our FTP server. I've got the recursion bit working fine, but whenever I try to upload a file I get the following error:

ftplib.error_perm: 550 C:\testxml\asdas.txt: The filename, directory name or volume label syntax is incorrect.

My code is as follows:

import sys
import ftplib
import os
 
def upload(ftp, file):
    ext = os.path.splitext(file)[1]
    if ext in (".txt", ".htm", ".html"):
        ftp.storlines("STOR " + file, open(file))
    else:
        ftp.storbinary("STOR " + file, open(file, "rb"), 1024)  
 
def walktree(ftp, top = ".", depthfirst = True):
    import os, stat, types
    names = os.listdir(top)
 
    for name in names:
        try:
            st = os.lstat(os.path.join(top, name))
            print(os.path.join(top, name))
            upload(ftp, os.path.join(top, name))
        except os.error:
            continue
        if stat.S_ISDIR(st.st_mode):
             walktree (ftp, os.path.join(top, name), depthfirst)
 
ftp = ftplib.FTP("xxxxxxx")
ftp.login("xxxxxxxx", "xxxxxxxx")
 
if __name__ == '__main__':
    if len(sys.argv) == 2:
        top = sys.argv[1]
    else: top = '.'
    walktree(ftp, top, True)
 

The string which represents the filesystem address that is passed into the upload function appears to be correct, of the form C:\TestXml\asdas.txt.

Any ideas? I've run out of things to try.

Thanks

[bartonc]

Hi,

I'm working on a system that recurses through a given directory, ftp-ing all the contents up to our FTP server. I've got the recursion bit working fine, but whenever I try to upload a file I get the following error:

ftplib.error_perm: 550 C:\testxml\asdas.txt: The filename, directory name or volume label syntax is incorrect.

My code is as follows:

import sys
import ftplib
import os
 
def upload(ftp, file):
    ext = os.path.splitext(file)[1]
    if ext in (".txt", ".htm", ".html"):
        ftp.storlines("STOR " + file, open(file))
    else:
        ftp.storbinary("STOR " + file, open(file, "rb"), 1024)  
 
def walktree(ftp, top = ".", depthfirst = True):
    import os, stat, types
    names = os.listdir(top)
 
    for name in names:
        try:
            st = os.lstat(os.path.join(top, name))
            print(os.path.join(top, name))
            upload(ftp, os.path.join(top, name))
        except os.error:
            continue
        if stat.S_ISDIR(st.st_mode):
             walktree (ftp, os.path.join(top, name), depthfirst)
 
ftp = ftplib.FTP("xxxxxxx")
ftp.login("xxxxxxxx", "xxxxxxxx")
 
if __name__ == '__main__':
    if len(sys.argv) == 2:
        top = sys.argv[1]
    else: top = '.'
    walktree(ftp, top, True)
 

The string which represents the filesystem address that is passed into the upload function appears to be correct, of the form C:\TestXml\asdas.txt.

Any ideas? I've run out of things to try.

Thanks

Not sure if FTP likes or dislikes "\". Try using raw strings. ie r"C:\TestXml\asdas.txt" or escaping the back slash "C:\\TestXml\\asdas.txt" by hand at first. Then use the os module to format the name correctly for you.

I've added CODE tags to your post. Please read "REPLY GUIDELINES" in order to learn how to do this. Thanks for joining the Python Forum on TheScripts.com.

[AlunDavies]

Not sure if FTP likes or dislikes "\". Try using raw strings. ie r"C:\TestXml\asdas.txt" or escaping the back slash "C:\\TestXml\\asdas.txt" by hand at first. Then use the os module to format the name correctly for you.

I've added CODE tags to your post. Please read "REPLY GUIDELINES" in order to learn how to do this. Thanks for joining the Python Forum on TheScripts.com.

Hi bartonc,

Thanks for the reply. I've tried both your solutions (using raw strings and manually escaping the backslash) and neither seemed to make any difference. After looking into the problem a bit more I'm wondering if it might be something to do with changing the ftp's working directory? The problem is whenever I use the ftp.cwd() function I get the same error as above. Anybody got any ideas?

[bartonc]

Hi bartonc,

Thanks for the reply. I've tried both your solutions (using raw strings and manually escaping the backslash) and neither seemed to make any difference. After looking into the problem a bit more I'm wondering if it might be something to do with changing the ftp's working directory? The problem is whenever I use the ftp.cwd() function I get the same error as above. Anybody got any ideas?

If it were me, I'd have to run a "commercial" (free) FTP on some site, look at the log and figure out from there what the FTP directory name format is.

[ghostdog74]

.....
ftp = ftplib.FTP("xxxxxxx")
ftp.login("xxxxxxxx", "xxxxxxxx")
ftp.set_debuglevel(5)  
.....
 

you can add a debug statement and see what other information you can see. vary the level number to your needs.

[harshalbhakta]

hi AlunDavies,
try using "/" instead of "\" in the path.
this will definitely solve your problem. Let me know if it doesn't work.

-
thanks,
harshal bhakta