473,545 Members | 1,471 Online
Bytes | Software Development & Data Engineering Community
+ Post

Home Posts Topics Members FAQ

Help with optimisation

Hello,
I know this might be a little cheeky, and if it is, please say, but I need a
little hand optimising some code. For the simple reason that this is
'company' code and I have no idea what I'm allowed to release and not as the
case may be I've changed anything that could give an indication of the
company - if that makes any sense...

for the code below:
text_buffer is a single record from an XML stream. I can't read in the
entire XML at once because it isn't all available straight away, so I
capture line by line, and when a full message is available I use parseString
under the minidom API.
The SQL version is SQLite. It was recommended to me, and is adequate for the
uses I put it to.
The function doesn't return anything, but it's called often enough and
depending on the optimisation I'll be able to use the same style in other
areas of the program.

previous code:
def CreatePerson(te xt_buffer):
dom=xml.dom.min idom.parseStrin g(text_buffer)
reflist = dom.getElements ByTagName('Coun try')
Country = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Age' )
Age = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Surn ame')
Surname = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Fore name')
Forename = reflist[0].firstChild.nod eValue
cursor.execute( 'INSERT INTO Person VALUES(?,?,?)', (Forename + "-" +
Surname, Age, Country))
connection.comm it()

I've changed it now to this:
def CreatePerson(te xt_buffer):
dom=xml.dom.min idom.parseStrin g(text_buffer)
elements=['Country','Age' ,'Surname','For ename']
Values=[]
for element in elements:
reflist=dom.get ElementsByTagNa me(element)
Values.append(r eflist[0].firstChild.nod eValue)
# I can get away with the above because I know the structure of the
XML
cursor.execute( 'INSERT INTO Person
VALUES(?,?,?)', (Forename+"-"+Surname,Age,C ountry))
connection.comm it()

They both seem ugly IMO (read: longer than intuitively necessary), and so I
was wondering whether there was any way to combine Forename and Surname
together within the Values list (think merge cells with the '-' in between)
so I could use the unary(?) operator within the SQL?

I suppose if this is a cheeky request then I won't get any replies.
Thank you for any help
Dominic

Aug 13 '07 #1
2 1242
special_dragonf ly <Do*****@PLEASE ASK.co.ukwrote:
...
dom=xml.dom.min idom.parseStrin g(text_buffer)
If you need to optimize code that parses XML, use ElementTree (some
other parsers are also fast, but minidom ISN'T).
Alex
Aug 13 '07 #2
special_dragonf ly a écrit :
Hello,
(snip)
The function doesn't return anything, but it's called often enough and
depending on the optimisation I'll be able to use the same style in other
areas of the program.

previous code:
def CreatePerson(te xt_buffer):
dom=xml.dom.min idom.parseStrin g(text_buffer)
reflist = dom.getElements ByTagName('Coun try')
Country = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Age' )
Age = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Surn ame')
Surname = reflist[0].firstChild.nod eValue
reflist = dom.getElements ByTagName('Fore name')
Forename = reflist[0].firstChild.nod eValue
cursor.execute( 'INSERT INTO Person VALUES(?,?,?)', (Forename + "-" +
Surname, Age, Country))
connection.comm it()

I've changed it now to this:
def CreatePerson(te xt_buffer):
dom=xml.dom.min idom.parseStrin g(text_buffer)
elements=['Country','Age' ,'Surname','For ename']
Values=[]
for element in elements:
reflist=dom.get ElementsByTagNa me(element)
Values.append(r eflist[0].firstChild.nod eValue)
# I can get away with the above because I know the structure of the
XML
cursor.execute( 'INSERT INTO Person
VALUES(?,?,?)', (Forename+"-"+Surname,Age,C ountry))
connection.comm it()
A common python optimisation trick is to stote local references to save
on attribute lookup time, ie:

# local ref to parseString
import dom
dom_parseString =xml.dom.minido m.parseString

def CreatePerson(te xt_buffer):
dom = dom_parseString (text_buffer)
elements=['Country','Age' ,'Surname','For ename']
values=[]
getElementByTag Name = dom.getElements ByTagName
for element in elements:
reflist = getElementsByTa gName(element)
values.append(r eflist[0].firstChild.nod eValue)
But as Alex already pointed out, you'd be better using (c)ElementTree.
They both seem ugly IMO (read: longer than intuitively necessary),
I'd say this is a common problem with XML :-/
Aug 13 '07 #3

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

8
1414
by: OPQ | last post by:
Hi all, I'd happy to have you share some thougts about ultimate optimisations on those 2 topics: (1)- adding one caractere at the end of a string (may be long) (2)- in a dict mapping a key to a list of int, remove every entrie where the list of int have of length < 2
2
1871
by: Simon Elliott | last post by:
What optimisation do compilers typically provide when passing STL containers around? For example, if I do something like this: struct Tbloggs { std::string s1; }; typedef std::vector<Tbloggs> TbloggsList;
16
1473
by: simonwittber | last post by:
Hello People. I've have a very tight inner loop (in a game app, so every millisecond counts) which I have optimised below: def loop(self): self_pool = self.pool self_call_exit_funcs = self.call_exit_funcs self_pool_popleft = self.pool.popleft self_pool_append = self.pool.append
8
1888
by: Jon Maz | last post by:
Hi, I'm facing a code-optimisation issue on an asp.net/vb.net/SQL Server 2000 project. A web page containing not much more than 3 DropDownLists is taking nigh on 6 seconds to load, because each ddl opens up a separate connection to the DB, pulls out its data, and closes its own connection before the next ddl repeats the process. The...
6
3592
by: Lee Harr | last post by:
I have a database where I remove the schema public. When I try to use the createlang script, it fails like this ... >createdb foo CREATE DATABASE >psql foo -c "select version()" version --------------------------------------------------------------------- PostgreSQL 7.4.1 on i386-portbld-freebsd4.9, compiled by GCC 2.95.4 (1 row)
1
1989
by: David Welch | last post by:
Hi, I have a bit of code where I am relying on empty base member optimisation. The bit of code is below: template<typename Enum> struct EncodePrefix { template<Enum e> struct Apply
1
2053
by: grid | last post by:
Hi, I was exploring the affect of cache on program performance/optimisation.Is it the compilers responsibility only to consider this kind of optimisation or the programmer can do his bit in this case ? Reading through the "Expert C Programming" text,it mentions how the below program can be efficient taking the cache details into accont. ...
21
2287
by: c | last post by:
Hi everybody. I'm working on converting a program wriiten on perl to C, and facing a problem with concatenate strings. Now here is a small program that descripe the problem, if you help me to solve in this small code, I can solve it on my own program...you don't want to have head-ache :-) So, the problem excatly is, I built an...
41
2640
by: c | last post by:
Hi every one, Me and my Cousin were talking about C and C#, I love C and he loves C#..and were talking C is ...blah blah...C# is Blah Blah ...etc and then we decided to write a program that will calculate the factorial of 10, 10 millions time and print the reusult in a file with the name log.txt.. I wrote something like this
0
7465
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main...
0
7398
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it. First, let's disable language...
0
7656
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed. This is as boiled down as I can make it. ...
0
7805
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that...
0
5969
agi2029
by: agi2029 | last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then...
0
3449
by: TSSRALBI | last post by:
Hello I'm a network technician in training and I need your help. I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs. The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols. I succeeded, with both firewalls in...
1
1878
by: 6302768590 | last post by:
Hai team i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system
1
1013
muto222
by: muto222 | last post by:
How can i add a mobile payment intergratation into php mysql website.
0
701
bsmnconsultancy
by: bsmnconsultancy | last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.