Strange artifacts in recieved file

[kjensen]

Hi

I'm working on a simple FTP server implementation but I've run into a strange problem.

I use this function to recieve:

def stor(self):
   f = open('test', 'w')
   while 1:
      data = self.pasvsocket.recv(1024).replace('\r\n', '\n')
      if not data:
         break
      f.write(data)
   f.close()
 

I use a simple large test file with 49999 lines with numbers going from 1 and incrementing each line to 49999. Here comes the strange thing. When this file is transmitted by the standard linux ftp program artifacts appears. Viewed in a editor (vim) these artifacts are the "^M" often seen. They appear with exactly 512 lines in between at the end of the line. Using 4096 as the buffer size the number is 2048 - hmm stange!

I guess that I'm receiving in the wrong way... Can anyone catch the problem?

Thanks :)

[ghostdog74]

Hi

I'm working on a simple FTP server implementation but I've run into a strange problem.

I use this function to recieve:

def stor(self):
   f = open('test', 'w')
   while 1:
      data = self.pasvsocket.recv(1024).replace('\r\n', '\n')
      if not data:
         break
      f.write(data)
   f.close()
 

I use a simple large test file with 49999 lines with numbers going from 1 and incrementing each line to 49999. Here comes the strange thing. When this file is transmitted by the standard linux ftp program artifacts appears. Viewed in a editor (vim) these artifacts are the "^M" often seen. They appear with exactly 512 lines in between at the end of the line. Using 4096 as the buffer size the number is 2048 - hmm stange!

I guess that I'm receiving in the wrong way... Can anyone catch the problem?

Thanks :)

just a guess, maybe this line did not work

...
data = self.pasvsocket.recv(1024).replace('\r\n', '\n')
...
 

you might want to check the last character of "data" by doing a print

..
print "last char of data is " % data[-1], len(data[-1])
...
 

OR another way to do it is, after recving the whole file, do another function to remove ^M. ^M are newlines..