converting a nested try/except statement into try/except/else

[John Salerno]

I'm starting out with this:

try:
if int(text) 0:
return True
else:
self.error_mess age()
return False
except ValueError:
self.error_mess age()
return False

I rewrote it as this:

try:
int(text)
except ValueError:
self.error_mess age()
return False
else:
return True

I think it's much cleaner, but obviously I lost the test in the original
if statement.

So my question is, can I still retain this second structure and still
test for 0, but not have any extra nesting?

Thanks.

[Bruno Desthuilliers]

John Salerno a écrit :

I'm starting out with this:

try:
if int(text) 0:
return True
else:
self.error_mess age()
return False
except ValueError:
self.error_mess age()
return False

I rewrote it as this:

try:
int(text)
except ValueError:
self.error_mess age()
return False
else:
return True

I think it's much cleaner, but obviously I lost the test in the original
if statement.

So my question is, can I still retain this second structure and still
test for 0, but not have any extra nesting?

solution 1:

def wrong():
raise ValueError

try:
int(text) 0 or wrong()
except ValueError:
self.error_mess age()
return False
else:
return True

But that's being-too-clever imho...

solution 2:

def error_message() :
self.error_mess age()
return False

try:
return int(text) 0 or error_message()
except ValueError:
return error_message()

[Simon Forman]

John Salerno wrote:

I'm starting out with this:

try:
if int(text) 0:
return True
else:
self.error_mess age()
return False
except ValueError:
self.error_mess age()
return False

I rewrote it as this:

try:
int(text)
except ValueError:
self.error_mess age()
return False
else:
return True

I think it's much cleaner, but obviously I lost the test in the original
if statement.

So my question is, can I still retain this second structure and still
test for 0, but not have any extra nesting?

Thanks.

What about the version I gave you 8 days ago? ;-)

http://groups.google.ca/group/comp.l...0fcd8932b0733a

It's clean, does the job, and doesn't have any extra nesting.

Peace,
~Simon

[Bruno Desthuilliers]

Bruno Desthuilliers a écrit :

John Salerno a écrit :

(snip)

or of course the dead simple:

try:
if int(text) <= 0: raise ValueError
except ValueError:
self.error_mess age()
return False
else:
return True
BTW, you really should have a look at FormEncode...

[John Salerno]

Bruno Desthuilliers wrote:

try:
if int(text) <= 0: raise ValueError
except ValueError:
self.error_mess age()
return False
else:
return True

Nice! Thanks!

[John Salerno]

Simon Forman wrote:

What about the version I gave you 8 days ago? ;-)

http://groups.google.ca/group/comp.l...0fcd8932b0733a

It's clean, does the job, and doesn't have any extra nesting.

Peace,
~Simon

I remember that version, but I found it a little hard to follow. It
seems like the kind of code that if I look at it again in another month
or so, I'll have to trace through it again to figure out what's what.

But I think it was your code that made me think of using an else
statement in the first place! :)

[John Salerno]

Bruno Desthuilliers wrote:

try:
if int(text) <= 0: raise ValueError

Hmm, I'm actually not so sure about this line now. It doesn't seem right
to raise a ValueError when the result of the expression is negative,
because even though it's a problem for my program, it isn't really a
"ValueError ," right?

[Slawomir Nowaczyk]

On Wed, 09 Aug 2006 18:51:04 +0000 (GMT)
John Salerno <jo******@NOSPA Mgmail.comwrote :

#try:
# int(text)
#except ValueError:
# self.error_mess age()
# return False
#else:
# return True
#>
#I think it's much cleaner, but obviously I lost the test in the
#original if statement.
#>
#So my question is, can I still retain this second structure and
#still test for 0, but not have any extra nesting?

How about

try:
if int(text) 0:
return True
except ValueError:
pass
self.error_mess age()
return False

--
Best wishes,
Slawomir Nowaczyk
( Sl************* **@cs.lth.se )

In 10 minutes, a hurricane releases more energy than all of the world's
nuclear weapons combined.

[infidel]

try:

if int(text) <= 0: raise ValueError

Hmm, I'm actually not so sure about this line now. It doesn't seem right
to raise a ValueError when the result of the expression is negative,
because even though it's a problem for my program, it isn't really a
"ValueError ," right?

It's an invalid value to your program, so yes, it is a ValueError.

[Bruno Desthuilliers]

John Salerno a écrit :

Bruno Desthuilliers wrote:

> try:
if int(text) <= 0: raise ValueError

Hmm, I'm actually not so sure about this line now. It doesn't seem right
to raise a ValueError when the result of the expression is negative,
because even though it's a problem for my program, it isn't really a
"ValueError ," right?

It's obviously a ValueError if your program needs a strictly positive
integer. But anyway, you don't care: this error is raised just so it get
caught on the next line...