newby trying to use GET to return variable to script in same page

[charlie fortune]

I have a simple html form and a bit of PHP in the same page, and I
want the script to get the entry from the form, and write it to a
file. I dont think I'm allowed to use POST on my webspace. Here is my
code ;

<p>&nbsp;
<form method="GET">
Type in a groovy word and press enter<input type="text"
name="groovyword">
<br>

</form></p>
<?php

// ** file created on 12/03/2005 17:18:03 **
// ** file created by Charlie Fortune
// ** Funk Name Generator

function addname ($word){
if (!file_exists("Funk name elements.txt")) touch ("Funk name
elements.txt") ;
$fp=fopen("Funk name elements.txt",'a');
fwrite($fp,"$word\r\n");
fclose($fp);
}
if (isset($groovyword))
addname($groovyword);
?>

what am I doing wrong ? I can see the entry in the url, but nothing is
being written to the file..

[Andy Hassall]

On 12 Mar 2005 16:05:11 -0800, go****@charliefortune.com (charlie fortune)
wrote:

I have a simple html form and a bit of PHP in the same page, and I
want the script to get the entry from the form, and write it to a
file. I dont think I'm allowed to use POST on my webspace.
That would be a cruel and unusual restriction. What makes you think that?
Here is my code ;

<p>&nbsp;
<form method="GET">
Type in a groovy word and press enter<input type="text"
name="groovyword">
<br>

</form></p>
You haven't got a submit button, which puts you at the mercy of the browser
deciding to submit when you press enter or similar. Add a submit button.
<?php
// ** file created on 12/03/2005 17:18:03 **
// ** file created by Charlie Fortune
// ** Funk Name Generator

function addname ($word){
if (!file_exists("Funk name elements.txt")) touch ("Funk name
elements.txt") ;
$fp=fopen("Funk name elements.txt",'a');
You can remove the 'touch' call if you use mode 'a+' (append if exists, create
if not).

Filenames with spaces cause pain in various situations, consider replacing
spaces with underscores or similar. This isn't required, just a suggestion.
fwrite($fp,"$word\r\n");
It's up to you what line endings you use, but Unix-style plain "\n" is
generally preferred over Windows-style "\r\n".
fclose($fp);
} if (isset($groovyword))
addname($groovyword);

There is nothing in this script that will set $groovyword unless you are using
either a very old version of PHP, or a newer version with the register_globals
option set to true, which is strongly recommended to be set to false.

Change these lines to:

if (isset($_GET['groovyword']))
addname($_GET['$groovyword']);

Another issue to consider; what if two people run this script at the exact
same time? You might want to look at http://uk.php.net/flock . Or even move up
a level and use a database; handling concurrent access is one of the several
fundamental reasons to use a proper database.

--
Andy Hassall / <an**@andyh.co.uk> / <http://www.andyh.co.uk>
<http://www.andyhsoftware.co.uk/space> Space: disk usage analysis tool

[charlie fortune]

Thanks for your reply, Andy, it's very helpful. I'm still not quite
there, though.

When I tried to "POST" i got an Error 405 POST method not permitted,
so that's why I thought I would have to use "GET". I am following this
up with my hosts.

My script is now as follows, however I know that it isn't calling the
function, because the .txt file isn't being created.

<p>&nbsp;
<form method="GET">
Type in a groovy word<input type="text" name="groovyword">
<br>
<input type="submit" value="file it">
</form></p>
<?php

// ** file created on 12/03/2005 17:18:03 **
// ** file created by Charlie Fortune
// ** Funk Name Generator

function addname ($word){
$fp=fopen("Funk_name_elements.txt",'a+');
fwrite($fp,"$word\n");
fclose($fp);
}
if(isset($_GET["groovyword"]))
addname($_GET["groovyword"]);
?>
Originally, I had the php as a separate file on the server, in the
same directory,and called it with <form action="funk_filer.php"> and
it worked fine except for the fact that it went to a new blank page
every time it filed an entry. I want it to regenerate the same page
with an empty field. (I would also like to conquer the returning
values to the same page concept). What is the way around this ?

Have I got this right ; a GET or POST method creates an associative
array with the name part of the element as a key ? Even with
register_globals off ?

Also, in your reply, you put

if(isset($_GET['groovyword']))
addname($_GET['$groovyword']);

with a $ in front of groovyword in addname, but I tried with and
without, and I guessed that the way I have it at the top is correct ?

Anyway, I really appreciate your help. I am reading a book too, but
you can't ask books questions....

[Kenneth Downs]

charlie fortune wrote:

Thanks for your reply, Andy, it's very helpful. I'm still not quite
there, though.

When I tried to "POST" i got an Error 405 POST method not permitted,
so that's why I thought I would have to use "GET". I am following this
up with my hosts.

My script is now as follows, however I know that it isn't calling the
function, because the .txt file isn't being created.

You are doing two things, a GET and a filesystem operation, and you need to
isolate which one is not working. Methinks you have a filesystem problem.
Try this simple sanity check:

<?php
echo "is this what you typed: ".$_GET["groovyword"];
?>

Which should settle once and for all for you that the variable is getting
through to your server.

With that settled, write yourself a little file:

FILE:Testme.php
<?php
$fp=fopen("Test.txt","a+");
$fwrite($fp,"sanity check");
fclose($fp);
echo "I wrote the file, check now to see if it worked";
?>

And then invoke http://example.com/Testme.php

....which will tell you if you your file commands are working.

--
Kenneth Downs
Secure Data Software, Inc.
(Ken)nneth@(Sec)ure(Dat)a(.com)