what is error in this line of code?

[Fivestar]

The following code snippet gives an error "unexpected '}'"

I have tried chopping up the line into small parts and it seems to die
when I get the the "onclick" part of the line.

Can anyone see what the problem is or offer a suggestion on how to do
this better.

Thanks!

Mike

[Fivestar]

might help if I posted the code :) The line in question is the long
print line

while ($line = mysql_fetch_assoc($pics)) {
$num = $line["SeqNo"];
$name = $line["Name"];
print "<p>$num $name</p>";
print "<p align=\"left\"><a style=\"cursor:hand\"
onclick=\"chgpic($num)\"><font color="#FFFFFF">$name</font></a></p>";
}

[Chris Hope]

Fivestar wrote:

might help if I posted the code :) The line in question is the long
print line

while ($line = mysql_fetch_assoc($pics)) {
$num = $line["SeqNo"];
$name = $line["Name"];
print "<p>$num $name</p>";
print "<p align=\"left\"><a style=\"cursor:hand\"
onclick=\"chgpic($num)\"><font color="#FFFFFF">$name</font></a></p>";
}

<font color="#FFFFFF">

should be

<font color=\"#FFFFFF\">

--
Chris Hope - The Electric Toolbox - http://www.electrictoolbox.com/

[noSpam]

Fivestar wrote:

might help if I posted the code :) The line in question is the long
print line

while ($line = mysql_fetch_assoc($pics)) {
$num = $line["SeqNo"];
$name = $line["Name"];
print "<p>$num $name</p>";
print "<p align=\"left\"><a style=\"cursor:hand\"
onclick=\"chgpic($num)\"><font color="#FFFFFF">$name</font></a></p>";
}

The immediate thing that springs to mind is yuo haven't escaped the
quotes around the colour string

[Michael Fesser]

.oO(Fivestar)

might help if I posted the code :) The line in question is the long
print line

while ($line = mysql_fetch_assoc($pics)) {
$num = $line["SeqNo"];
$name = $line["Name"];
print "<p>$num $name</p>";
print "<p align=\"left\"><a style=\"cursor:hand\"
onclick=\"chgpic($num)\"><font color="#FFFFFF">$name</font></a></p>";
}

There are some unescaped double quotes in the string, causing the parse
error. Either escape them or simply use single quotes.

Micha

[Fivestar]

Chris,

Thanks for the quick response! Can't believe I missed something that
obvious!

Thanks again!

Mike

[Alvaro G. Vicario]

*** Fivestar escribió/wrote (22 Feb 2005 14:27:16 -0800):

Thanks for the quick response! Can't believe I missed something that
obvious!

This kind of errors become pretty obvious when your text editor has syntax
highlight.

Also (and this is merely a personal opinion) scaping quotes makes code
harder to understand:

print "<p align=\"left\"><a style=\"cursor:hand\" onclick=\"chgpic($num)\"><font color="#FFFFFF">$name</font></a></p>";
print '<p align="left"><a style="cursor:hand" onclick="chgpic(' . $num. ')"><font color="#FFFFFF">' . $name . '</font></a></p>';
--
-+ Álvaro G. Vicario - Burgos, Spain
+- http://www.demogracia.com (la web de humor barnizada para la intemperie)
++ Manda tus dudas al grupo, no a mi buzón
-+ Send your questions to the group, not to my mailbox
--

[Geoff Berrow]

I noticed that Message-ID: <cv**********@lust.ihug.co.nz> from Chris
Hope contained the following:

<font color="#FFFFFF">

should be

removed and replaced by CSS.
--
Geoff Berrow (put thecat out to email)
It's only Usenet, no one dies.
My opinions, not the committee's, mine.
Simple RFDs http://www.ckdog.co.uk/rfdmaker/

[Matt Mitchell]

"Geoff Berrow" <bl******@ckdog.co.uk> wrote in message
news:f9********************************@4ax.com...

: ><font color="#FFFFFF">
: >
: >should be
: >
: removed and replaced by CSS.

and then all of it should be removed into a template somewhere ;-)

[phiberoptick]

Templates are the only way to go.....

[JDS]

On Tue, 22 Feb 2005 14:06:15 -0800, Fivestar wrote:

might help if I posted the code :) The line in question is the long

It also might help if you posted the entire error.

--
JDS | je*****@example.invalid
| http://www.newtnotes.com
DJMBS | http://newtnotes.com/doctor-jeff-master-brainsurgeon/