fwrite loop and last record

[anfetienne]

hi im back again.......i have a code to create strings and save it within a text file to pass variables to flash. im using the string format below.

mylist=apple,cherry,lemon,banana&mylist2=apple,cherry,lemon,banana
 

this code below is what im using to write my string to the text file, basically the info is collected from a db and i use a loop to cycle through and write each value in. I have to seperate these values using a comma ',' like in my above example. i can do this but then i am left with a comma at the end of my string before the next variable starts like this mylist=apple,ch erry,lemon,bana na,&

is there a way to add commas and once it gets to the last value to write to get php to check that its the last value and not add a comma in?

$file = "upload/$random_digit/gallery.txt";
$imgHandle = fopen($file, 'w') or die("can't open file");
 
    $iv= 1;
    $lQ = ',';
 
    $stringData = "&imgLoc=";
    fwrite($imgHandle, $stringData);
 
            for($i=0;$i<$totalRecords;$i++)
            {
                $stringData = $returnedData[$i]["imageLoc"] .$lQ ;
                fwrite($imgHandle, $stringData);
            } 
 
fclose($imgHandle);
 

[Niheel]

You might be able to use rtrim function in php and ask it delete the comma from the end of the string.

http://us2.php.net/manual/en/function.rtrim.php

$trimmed = rtrim($string, ",");
 

[anfetienne]

yeah i had a look at that....it's basically the same as str_replace.... i've used str_replace and it works great.....thank s for the advice it is something i'm looking into in more detail

[code green]

I would improve the efficiency drastically by concatenating then writing one big string.
Then you can easily trim the last comma

$file = "upload/$random_digit/gallery.txt"; 
$imgHandle = fopen($file, 'w') or die("can't open file");   
    $iv= 1; 
    $lQ = ',';   
    $stringData = "&imgLoc="; 
    for($i=0;$i<$totalRecords;$i++) 
    { 
        $stringData .= $returnedData[$i]["imageLoc"] .$lQ ; 
    }
   $stringData = rtrim($stringData,',');  
   fwrite($imgHandle, $stringData); 
fclose($imgHandle); 
 

Even if this causes memory problems due to a huge string I would still do the same but split into chunks

[anfetienne]

that's exactly what i have done.....the speed it does it in is good and it doesn't take much memory.....i basically build the string and at the end i str_replace the unwanted commas then save it back into the file