Using a view with some parameters

[Harris Kosmidhs]

Hello,

I try to develop an application with a controller (which acts as the
model also, meaning it performs calls to db and all this) and a view.

For example, there's a controller called professor which will act upon
members of the site (teachers, professors) who will login.

In my class professor I have a function:
function login() {
$loginForm=new professorLoginF orm("professors/login");
if($this->_post) {
....
} else {
$this->todisplay=$log inForm->ShowLogin();

}
}

Since I 'm not posting the form now the $loginForm->ShowLogin(); is
executed.

professorLoginF orm is an extension of LoginForm where I have a function:

function ShowLogin($logi nErrors="") {
if($this->use_cookies) {
$loginCookie=$t his->GetCookie();
$loginvars['email']=$loginCookie['email'];
$loginvars['password']=$loginCookie['password'];
}
$loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;

if($loginErrors !="") $loginvars['errors']=$loginErrors;

$logform=get_in clude_contents( 'views/generalLoginFor m.php');

return $logform;
}

and another function

function get_include_con tents($filename ) {
if (is_file($filen ame)) {
ob_start();
include( $filename);
$contents = ob_get_contents ();
ob_end_clean();
return $contents;
}
return false;
}

The problem is in the views/generalLoginFor m.php. The beginning of it has:
<?php global $loginvars,$log inclassname;?>
<form class="<?php echo $loginclassname ; ?>" action="<?php echo
$loginvars['action']; ?>"

$loginvars and $loginclassname is always "". Why is that?

The reason for using the get_include_con tents instead of just including
it is because in my controller I have a function:

function Display() {

include('static pages/header.php');
print $this->todisplay;
include('static pages/footer.php');
}

I know this may be a wrong approach and I would like to comment on it if
so.

Thanks and sorry for the huge post.

Harris

[C. (http://symcbean.blogspot.com/)]

On Jun 12, 11:37 am, Harris Kosmidhs
<hkosm...@remov e.me.softnet.tu c.grwrote:
<snip>

function ShowLogin($logi nErrors="") {

....

$loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;

if($loginErrors !="") $loginvars['errors']=$loginErrors;

$logform=get_in clude_contents( 'views/generalLoginFor m.php');

return $logform;
}

<snip>

The problem is in the views/generalLoginFor m.php. The beginning of it has:
<?php global $loginvars,$log inclassname;?>
<form class="<?php echo $loginclassname ; ?>" action="<?php echo
$loginvars['action']; ?>"

$loginvars and $loginclassname is always "". Why is that?

Because they are not in the global scope.

C

[Harris Kosmidhs]

C. (http://symcbean.blogspot.com/) wrote:

On Jun 12, 11:37 am, Harris Kosmidhs
<hkosm...@remov e.me.softnet.tu c.grwrote:
<snip>

>function ShowLogin($logi nErrors="") {

...

> $loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;

if($loginErrors !="") $loginvars['errors']=$loginErrors;

$logform=get_in clude_contents( 'views/generalLoginFor m.php');

return $logform;
}

<snip>

>The problem is in the views/generalLoginFor m.php. The beginning of it has:
<?php global $loginvars,$log inclassname;?>
<form class="<?php echo $loginclassname ; ?>" action="<?php echo
$loginvars['action']; ?>"

$loginvars and $loginclassname is always "". Why is that?

Because they are not in the global scope.

C

because the function get_include_con tents is in another file?

How can I overcome it?

[=?UTF-8?B?IsOBbHZhcm8gRy4gVmljYXJpbyI=?=]

Harris Kosmidhs escribió:

>>function ShowLogin($logi nErrors="") {

...

>> $loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;

if($loginErrors !="") $loginvars['errors']=$loginErrors;

$logform=get_in clude_contents( 'views/generalLoginFor m.php');

return $logform;
}

[...]

>Because they are not in the global scope.

[...]

because the function get_include_con tents is in another file?

Variable scope has nothing to do with files. If you want to use global
variables inside a function you need to load it with the global keyword:

function ShowLogin($logi nErrors="") {
global $loginvars;
$loginvars['use_cookies']=$this->use_cookies;
...
}

Otherwise, whatever variables you handle are considered local to the
function. That prevents undesired side effects.
--
-- http://alvaro.es - �lvaro G. Vicario - Burgos, Spain
-- Mi sitio sobre programación web: http://bits.demogracia.com
-- Mi web de humor al baño MarÃ*a: http://www.demogracia.com
--

[Jerry Stuckle]

�lvaro G. Vicario wrote:

Harris Kosmidhs escribió:

>>>function ShowLogin($logi nErrors="") {
...
$loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;

if($loginErrors !="") $loginvars['errors']=$loginErrors;

$logform=get_in clude_contents( 'views/generalLoginFor m.php');

return $logform;
}

[...]

>>Because they are not in the global scope.

[...]

>because the function get_include_con tents is in another file?

Variable scope has nothing to do with files. If you want to use global
variables inside a function you need to load it with the global keyword:

function ShowLogin($logi nErrors="") {
global $loginvars;
$loginvars['use_cookies']=$this->use_cookies;
...
}

Otherwise, whatever variables you handle are considered local to the
function. That prevents undesired side effects.

At the same time, it is not a good idea to use global variables. They
make bugs much harder to find.

Rather, return the value(s) from the function, or pass variables by
reference to the function.

--
=============== ===
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
js*******@attgl obal.net
=============== ===

[Harris Kosmidhs]

Jerry Stuckle wrote:

�lvaro G. Vicario wrote:

>Harris Kosmidhs escribió:

>>>>function ShowLogin($logi nErrors="") {
...
$loginvars['use_cookies']=$this->use_cookies;
$loginvars['action']=$this->action;
>
if($loginErrors !="") $loginvars['errors']=$loginErrors;
>
$logform=get_in clude_contents( 'views/generalLoginFor m.php');
>
return $logform;
}

[...]

>>>Because they are not in the global scope.

[...]

>>because the function get_include_con tents is in another file?

Variable scope has nothing to do with files. If you want to use global
variables inside a function you need to load it with the global keyword:

function ShowLogin($logi nErrors="") {
global $loginvars;
$loginvars['use_cookies']=$this->use_cookies;
...
}

Otherwise, whatever variables you handle are considered local to the
function. That prevents undesired side effects.

At the same time, it is not a good idea to use global variables. They
make bugs much harder to find.

Rather, return the value(s) from the function, or pass variables by
reference to the function.

Can you please explain how can I do this? I understand the problem but
can't find out a solution. How do templates handle passed variables?

Thanks

[Jerry Stuckle]

Harris Kosmidhs wrote:

Jerry Stuckle wrote:

>�lvaro G. Vicario wrote:

>>Harris Kosmidhs escribió:
>function ShowLogin($logi nErrors="") {
...
> $loginvars['use_cookies']=$this->use_cookies;
> $loginvars['action']=$this->action;
>>
> if($loginErrors !="") $loginvars['errors']=$loginErrors;
>>
> $logform=get_in clude_contents( 'views/generalLoginFor m.php');
>>
> return $logform;
> }
[...]
Because they are not in the global scope.
[...]
because the function get_include_con tents is in another file?

Variable scope has nothing to do with files. If you want to use
global variables inside a function you need to load it with the
global keyword:

function ShowLogin($logi nErrors="") {
global $loginvars;
$loginvars['use_cookies']=$this->use_cookies;
...
}

Otherwise, whatever variables you handle are considered local to the
function. That prevents undesired side effects.

At the same time, it is not a good idea to use global variables. They
make bugs much harder to find.

Rather, return the value(s) from the function, or pass variables by
reference to the function.

Can you please explain how can I do this? I understand the problem but
can't find out a solution. How do templates handle passed variables?

Thanks

Just like I said - if they need to change a value, they use references
or return a value. They don't do anything any different.

The php manual has a lot of good stuff on both passing by reference and
returning values from functions.

--
=============== ===
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
js*******@attgl obal.net
=============== ===