473,728 Members | 2,059 Online
Bytes | Software Development & Data Engineering Community
+ Post

Home Posts Topics Members FAQ

curly brackets necessary in php?


Do I need to use curly brackets in PHP if .. else statements? other constructs?
Does it matter? What are Best Practices? Why?

thanks in advance...

This seems to work WITHOUT curly brackets:

if(ereg("Win", getenv("HTTP_US ER_AGENT")))
$visos = "Windows";
elseif((ereg("M ac", getenv("HTTP_US ER_AGENT"))) || (ereg("PPC",
getenv("HTTP_US ER_AGENT"))))
$visos = "Mac";
elseif(ereg("Li nux", getenv("HTTP_US ER_AGENT")))
$visos = "Linux";
elseif(ereg("Fr eeBSD", getenv("HTTP_US ER_AGENT")))
$visos = "FreeBSD";
elseif(ereg("Su nOS", getenv("HTTP_US ER_AGENT")))
$visos = "SunOS";
elseif(ereg("IR IX", getenv("HTTP_US ER_AGENT")))
$visos = "IRIX";
elseif(ereg("Be OS", getenv("HTTP_US ER_AGENT")))
$visos = "BeOS";
elseif(ereg("OS/2", getenv("HTTP_US ER_AGENT")))
$visos = "OS/2";
elseif(ereg("AI X", getenv("HTTP_US ER_AGENT")))
$visos = "AIX";
else $visos = "unknown";

And this seems to work WITH curly brackets:

if (isset($_SERVER ))
{
if (isset($_SERVER["HTTP_X_FORWARD ED_FOR"]))
{
$visip = $_SERVER["HTTP_X_FORWARD ED_FOR"];
}
elseif (isset($_SERVER["HTTP_CLIENT_IP "]))
{
$visip = $_SERVER["HTTP_CLIENT_IP "];
}
else
{
$visip = $_SERVER["REMOTE_ADD R"];
}
}
else
{
if (getenv('HTTP_X _FORWARDED_FOR' ))
{
$visip = getenv('HTTP_X_ FORWARDED_FOR') ;
}
elseif (getenv('HTTP_C LIENT_IP'))
{
$visip = getenv('HTTP_CL IENT_IP');
}
else
{
$visip = getenv('REMOTE_ ADDR');
}
}
Jul 17 '05 #1
21 12952
On Sun, 21 Mar 2004 00:35:18 GMT, "deko" <dj****@hotmail .com> wrote:
Do I need to use curly brackets in PHP if .. else statements? other constructs?
Does it matter? What are Best Practices? Why?


You need to use curly brackets if there is more than one statement to be
executed in that conditional branch.

if (condition)
statement;
else
statement2;

if (condition) {
statement;
} else {
statemen2;
}

if (condition) {
statement1;
statement2;
} else
statement2;

All these are fine.

A conditional itself is a single statement, so even:

if (condition1)
if (condition2)
statement1;
else
statement2;

If you only have one statement, you can leave out the curly brackets, which
cuts out a couple of lines and may make the code more (or less) readable.

The risk is that later you add another statement, and forget to add the curly
brackets:

if (condition)
statement1;
statement2;

statement2 will in fact always be executed, even if condition is false.

Same principle applies to all the control structures; while, foreach, etc.

--
Andy Hassall <an**@andyh.co. uk> / Space: disk usage analysis tool
http://www.andyh.co.uk / http://www.andyhsoftware.co.uk/space
Jul 17 '05 #2
I'll have to admit, those curly brackets are a pain. But it would seem better
to ALWAYS use curly brackets for consistency's sake. Do many programmers do
this? Or is it pretty much a free for all?

"Andy Hassall" <an**@andyh.co. uk> wrote in message
news:di******** *************** *********@4ax.c om...
On Sun, 21 Mar 2004 00:35:18 GMT, "deko" <dj****@hotmail .com> wrote:
Do I need to use curly brackets in PHP if .. else statements? other constructs?Does it matter? What are Best Practices? Why?


You need to use curly brackets if there is more than one statement to be
executed in that conditional branch.

if (condition)
statement;
else
statement2;

if (condition) {
statement;
} else {
statemen2;
}

if (condition) {
statement1;
statement2;
} else
statement2;

All these are fine.

A conditional itself is a single statement, so even:

if (condition1)
if (condition2)
statement1;
else
statement2;

If you only have one statement, you can leave out the curly brackets, which
cuts out a couple of lines and may make the code more (or less) readable.

The risk is that later you add another statement, and forget to add the curly
brackets:

if (condition)
statement1;
statement2;

statement2 will in fact always be executed, even if condition is false.

Same principle applies to all the control structures; while, foreach, etc.

--
Andy Hassall <an**@andyh.co. uk> / Space: disk usage analysis tool
http://www.andyh.co.uk / http://www.andyhsoftware.co.uk/space

Jul 17 '05 #3
deko wrote:
I'll have to admit, those curly brackets are a pain. But it would seem better
to ALWAYS use curly brackets for consistency's sake. Do many programmers do
this? Or is it pretty much a free for all?


Do as you think it's better for you.
Think that you'll have to read your code again in a few months time, and
make it easy to identify what blocks (or instructions) 'belong' to what
control structure.

I tend to not use braces for most simple and direct "stuff":
if ($bold) echo '<strong>';
echo $content;
if ($bold) echo '</strong>';

but use them for things I might want to change later:
// previous statement
while ($row = mysql_fetch_row ($result)) {
$option[] = $row[0];
}
// next statement

this last one could very well be written as
// previous statement

//get db data
while ($row = mysql_fetch_row ($result)) $option[] = $row[0];

// next statement
In the last two snippets I use blank lines and coments as shown. Of
course the // next and // previous statement comments, in real code
would be real statements (unless either was another thing I needed a
comment for).
--
USENET would be a better place if everybody read: : mail address :
http://www.catb.org/~esr/faqs/smart-questions.html : is valid for :
http://www.netmeister.org/news/learn2quote2.html : "text/plain" :
http://www.expita.com/nomime.html : to 10K bytes :
Jul 17 '05 #4
10-4

Think I'll start with using them all the time and see how it goes from there.
{
Thanks for the tip :)
}
"Pedro Graca" <he****@hotpop. com> wrote in message
news:c3******** *****@ID-203069.news.uni-berlin.de...
deko wrote:
I'll have to admit, those curly brackets are a pain. But it would seem better to ALWAYS use curly brackets for consistency's sake. Do many programmers do
this? Or is it pretty much a free for all?


Do as you think it's better for you.
Think that you'll have to read your code again in a few months time, and
make it easy to identify what blocks (or instructions) 'belong' to what
control structure.

I tend to not use braces for most simple and direct "stuff":
if ($bold) echo '<strong>';
echo $content;
if ($bold) echo '</strong>';

but use them for things I might want to change later:
// previous statement
while ($row = mysql_fetch_row ($result)) {
$option[] = $row[0];
}
// next statement

this last one could very well be written as
// previous statement

//get db data
while ($row = mysql_fetch_row ($result)) $option[] = $row[0];

// next statement
In the last two snippets I use blank lines and coments as shown. Of
course the // next and // previous statement comments, in real code
would be real statements (unless either was another thing I needed a
comment for).
--
USENET would be a better place if everybody read: : mail address :
http://www.catb.org/~esr/faqs/smart-questions.html : is valid for :
http://www.netmeister.org/news/learn2quote2.html : "text/plain" :
http://www.expita.com/nomime.html : to 10K bytes :

Jul 17 '05 #5
Just to add on to what's been said...

I always use braces, it makes the code much easier to read I find.
Also, I use braces on separate lines as in

if ( condition )
{
actions...
}
else
{
....
)

Which I personally find easier to read. The use of one brace at the
end of the condition line was started in an attempt to save paper when
developing on teletypes and punched cards.

Gives you some idea of how old I am (:

Steve

On Sun, 21 Mar 2004 04:39:28 GMT, "deko" <dj****@hotmail .com> wrote:
10-4

Think I'll start with using them all the time and see how it goes from there.
{
Thanks for the tip :)
}
"Pedro Graca" <he****@hotpop. com> wrote in message
news:c3******* ******@ID-203069.news.uni-berlin.de...
deko wrote:
> I'll have to admit, those curly brackets are a pain. But it would seembetter > to ALWAYS use curly brackets for consistency's sake. Do many programmers do
> this? Or is it pretty much a free for all?


Do as you think it's better for you.
Think that you'll have to read your code again in a few months time, and
make it easy to identify what blocks (or instructions) 'belong' to what
control structure.

I tend to not use braces for most simple and direct "stuff":
if ($bold) echo '<strong>';
echo $content;
if ($bold) echo '</strong>';

but use them for things I might want to change later:
// previous statement
while ($row = mysql_fetch_row ($result)) {
$option[] = $row[0];
}
// next statement

this last one could very well be written as
// previous statement

//get db data
while ($row = mysql_fetch_row ($result)) $option[] = $row[0];

// next statement
In the last two snippets I use blank lines and coments as shown. Of
course the // next and // previous statement comments, in real code
would be real statements (unless either was another thing I needed a
comment for).
--
USENET would be a better place if everybody read: : mail address :
http://www.catb.org/~esr/faqs/smart-questions.html : is valid for :
http://www.netmeister.org/news/learn2quote2.html : "text/plain" :
http://www.expita.com/nomime.html : to 10K bytes :


Jul 17 '05 #6
In article <Ti************ *******@newssvr 25.news.prodigy .com>, "deko"
<dj****@hotmail .com> wrote:
I'll have to admit, those curly brackets are a pain. But it would
seem better to ALWAYS use curly brackets for consistency's sake. Do
many programmers do this? Or is it pretty much a free for all?


I always use them, unless it's a oneliner, like:

if ($nr == 10) print "It's ten!";

But I usually make them as compact as possible, with:

if (condition){*pr int "foo"; }
else { print "bar"; }

And if the statements run more than one lines:

if (condition){
print "foo";
$foo = true;
} else {
print "bar";
}

--
Sandman[.net]
Jul 17 '05 #7
deko wrote:
But it would seem better to ALWAYS use curly brackets
for consistency's sake.
It is, for reasons of consistency, readability, and long-term
maintainability .
Do many programmers do this?


I do, and the people under me on my team do. I do not look kindly on
people who generate error-prone code out of sheer laziness. Always use
the brackets. Always. There is no excuse to leave them out.

bblackmoor
2004-03-21
Jul 17 '05 #8
Steve Holdoway wrote:

Also, I use braces on separate lines as in

if ( condition )
{
actions...
}
else
{
....
)


This is my preferred style, as well, and is the style mandated in our
coding guidelines. It makes the code more readable, and thus makes
errors less likely. It also makes searching for pairs of brackets much
easier.

bblackmoor
2004-03-21
Jul 17 '05 #9
Well, these's the alternative synatx:

if(IsMad($cows) ):
OrderTurkeyBurg ers();
CallCDC();
elsif(HasFlu($c hickens)):
OrderKungPaoBee f();
Cancel($trip_to _thailand);
else:
FireUpBBQ();
HaveUnprotected Sex();
endif;

for($i = 0; $i < 3; $i++):
ChangeRegime($a xis_of_evil[$i]);
endfor;

while($morale < 100):
ContinueBeating ();
endwhile;

....etc.

In regular PHP code, this syntax is considered deprecated. Some of us like
to this it though when we place control structure within HTML. <? foreach(
.... )?> ... <? endforeach; ?> is much more readable than <? foreach( ... )
{ ?> ... <? } ?> .

Uzytkownik "deko" <dj****@hotmail .com> napisal w wiadomosci
news:ar******** **********@news svr25.news.prod igy.com...

Do I need to use curly brackets in PHP if .. else statements? other constructs? Does it matter? What are Best Practices? Why?

thanks in advance...

This seems to work WITHOUT curly brackets:

if(ereg("Win", getenv("HTTP_US ER_AGENT")))
$visos = "Windows";
elseif((ereg("M ac", getenv("HTTP_US ER_AGENT"))) || (ereg("PPC",
getenv("HTTP_US ER_AGENT"))))
$visos = "Mac";
elseif(ereg("Li nux", getenv("HTTP_US ER_AGENT")))
$visos = "Linux";
elseif(ereg("Fr eeBSD", getenv("HTTP_US ER_AGENT")))
$visos = "FreeBSD";
elseif(ereg("Su nOS", getenv("HTTP_US ER_AGENT")))
$visos = "SunOS";
elseif(ereg("IR IX", getenv("HTTP_US ER_AGENT")))
$visos = "IRIX";
elseif(ereg("Be OS", getenv("HTTP_US ER_AGENT")))
$visos = "BeOS";
elseif(ereg("OS/2", getenv("HTTP_US ER_AGENT")))
$visos = "OS/2";
elseif(ereg("AI X", getenv("HTTP_US ER_AGENT")))
$visos = "AIX";
else $visos = "unknown";

And this seems to work WITH curly brackets:

if (isset($_SERVER ))
{
if (isset($_SERVER["HTTP_X_FORWARD ED_FOR"]))
{
$visip = $_SERVER["HTTP_X_FORWARD ED_FOR"];
}
elseif (isset($_SERVER["HTTP_CLIENT_IP "]))
{
$visip = $_SERVER["HTTP_CLIENT_IP "];
}
else
{
$visip = $_SERVER["REMOTE_ADD R"];
}
}
else
{
if (getenv('HTTP_X _FORWARDED_FOR' ))
{
$visip = getenv('HTTP_X_ FORWARDED_FOR') ;
}
elseif (getenv('HTTP_C LIENT_IP'))
{
$visip = getenv('HTTP_CL IENT_IP');
}
else
{
$visip = getenv('REMOTE_ ADDR');
}
}

Jul 17 '05 #10

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

8
6836
by: Ken in Melbourne Australia | last post by:
If I use the curly bracket syntax (referred to as the complex syntax) within a string, how do I get to call a function within it? The php manual says that the first (or previous) character for the curly bracket has to be a dollar sign '$'. This is fine for variables, arrays and some objects but doesn't allow me to call a function such as addslashes() or trim() before I return the string in the variable.
1
1909
by: inquirydog | last post by:
Hello- I, the inquirydog have a question: Using the AVT mechanism (curly brackets in an attribute value) is a great way to decrease the size of your xml document and make it more readable. Can one also include the results of a call-template within curly brackets? Ideally it would be great if you could just call the template as a function: <tagname attributename="{mytemplate('abcd')}">
6
6655
by: STF | last post by:
While reading the C++ tutorial in this page: http://www.cplusplus.com/doc/tutorial/tut2-2.html I'm astonished to learn that we could omit curly brackets in function declaration for single instruction as is written in the paragraph: "statement is the function's body. It can be a single instruction or a block of instructions. In the latter case it must be delimited by curly brackets {}." But I'm not sure if this is true. At least with...
4
8338
by: lwoods | last post by:
In PHP you can do this: $x="test"; $y=$x{2}; echo $y; ....will display "s". Where in the PHP doc is this type of behavior for "curly brackets" defined?
2
5021
by: Zain Homer | last post by:
Someone please let me know if I'm sending this to the wrong email alias... I'm wondering why we can't use the glob module to glob with curly brackets like we can from the command line (at least in tcsh). Is there a shell standard for which the python glob module has been designed which prevents the implimentation of the {}'s? For example:
24
2283
by: dmitrey | last post by:
Hi all, I looked to the PEPs & didn't find a proposition to remove brackets & commas for to make Python func call syntax caml- or tcl- like: instead of result = myfun(param1, myfun2(param5, param8), param3) just make possible using result = myfun param1 (myfun2 param5 param8) param3 it would reduce length of code lines and make them more readable, + no needs to write annoing charecters.
3
5363
by: Grande News | last post by:
Hi, I've got some PHP code that looks like this $cura= ord($data{$pnum*2}); $curb = ord($data{$pnum*2+1}); Notice the curly braces -- does using them make any difference, or will square brackets do the same thing? Thanks B
37
2508
by: dorayme | last post by:
Is there some particular reason that the inventors of CSS chose to leave us with the legacy of the curly brackets (for which one has to shift press) rather than the square (for which one simply has to press)? p is two key presses shorter then p {margin: 0;}
0
8759
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it. First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
0
9424
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed. This is as boiled down as I can make it. Here is my compilation command: g++-12 -std=c++20 -Wnarrowing bit_field.cpp Here is the code in...
0
9135
tracyyun
by: tracyyun | last post by:
Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...
0
8133
agi2029
by: agi2029 | last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then launch it, all on its own.... Now, this would greatly impact the work of software developers. The idea...
1
6718
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules. He will explain when you may want to use classes instead of User Defined Types (UDT). For example, to manage the data in unbound forms. Adolph will...
0
6013
by: conductexam | last post by:
I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and then checking html paragraph one by one. At the time of converting from word file to html my equations which are in the word document file was convert into image. Globals.ThisAddIn.Application.ActiveDocument.Select();...
0
4524
by: TSSRALBI | last post by:
Hello I'm a network technician in training and I need your help. I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs. The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols. I succeeded, with both firewalls in the same network. But I'm wondering if it's possible to do the same thing, with 2 Pfsense firewalls...
2
2668
muto222
by: muto222 | last post by:
How can i add a mobile payment intergratation into php mysql website.
3
2161
bsmnconsultancy
by: bsmnconsultancy | last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.