A simple IF condition.

[Alec]

I have a simple IF condition to check whether an entered town name for
a search actually exists in the database.

The form search produces $townsearch

The check should return "Cannot Find The Town" if $townsearch does not
correspond to a recognised townname in the database.

The database is correct, and the SQL query OK.

So why can I type anything in and it accepts it??

(Day 4 of learning PHP)

Alec

<?php $townsearch = $_GET['town']; ?>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
<input type="text" name="town" size="20" value="<?php echo $townsearch;
?>" />&nbsp;
<input type="submit" value="GO" />

<?php
$check = @mysql_query ("SELECT townname FROM site01_towns WHERE
townname='$town search'");
if (!$check)
{
echo '<p>Cannot Find The Town</p>';
exit();

}

?>

[Alvaro G Vicario]

*** Alec wrote/escribió (2 Sep 2005 05:46:29 -0700):

$check = @mysql_query ("SELECT townname FROM site01_towns WHERE
townname='$town search'");
if (!$check)
{
echo '<p>Cannot Find The Town</p>';
exit();

}

Let's check mysql_query() manual page:

"Only for SELECT,SHOW,EXP LAIN or DESCRIBE statements mysql_query() returns
a resource identifier or FALSE if the query was not executed correctly.
[...] A non-FALSE return value means that the query was legal and could be
executed by the server. It does not indicate anything about the number of
rows affected or returned. It is perfectly possible for a query to succeed
but affect no rows or return no rows."

Your if condition will only be FALSE if you have a syntax error in your SQL
query.
--
-- Álvaro G. Vicario - Burgos, Spain
-- http://bits.demogracia.com - Mi sitio sobre programación web
-- Don't e-mail me your questions, post them to the group
--

[dracolytch]

Give

if (mysql_num_rows ($check) == 0)

a try instead.

[frizzle]

Is this the entire code?
If so, you don't have a mysql connection yet (afaik).

And *please* escape your search object:
http://www.php.net/manual/en/functio...ape-string.php

Greetings Frizzle.

[Alec]

Dracolytch

If (mysql_num_rows ($check) ==0)

Works nicely thank you very much....

Am learning as I am doing, but eventually....