handling arrays.... "We are not in C anymore"

[jaynemarie]

I have a simple program that attempts to convert lines to a csv file. The way I see it it shoule output like this:
Applebee's Neighborhood Grill & Bar*, 11500 Shawnee Mission Pkwy.,Shawnee, KS, 66203, 913-962-1133
as one line. But it is not and I don't see why. I am putting each line into an array and then at the end doing a join. Why am I getting a newline after the company name and then again after the street address?


As an example...
INPUT FILE
"Shawnee, KS -- Chamber of commerce"

Applebee's Neighborhood Grill & Bar*
11500 Shawnee Mission Pkwy.
"Shawnee, KS 66203"
913-962-1133

Arby's
7404 Nieman Rd.
"Shawnee, KS 66203"
913-631-1425

Arizona's Neighborhood Grille & Bar
7182 Renner Rd.
"Shawnee, KS 66217"
913-962-9988


OUTPUT FILE
"Shawnee, KS -- Chamber of commerce"
Applebee's Neighborhood Grill & Bar*
, 11500 Shawnee Mission Pkwy.
, Shawnee, KS, 66203, 913-962-1133
Arby's
, 7404 Nieman Rd.
, Shawnee, KS, 66203, 913-631-1425
Arizona's Neighborhood Grille & Bar
, 7182 Renner Rd.
, Shawnee, KS, 66217, 913-962-9988

SOURCE

#!/usr/bin/perl
use warnings;
use strict;
#define variables
my $FileIn = 'shawneechamber.txt';
my $FileOut = 'row2col.csv';
my $data;
my $lineno =1;
my $linecounter=0;
my @csvline;
my $date;
my $container;
 
#open file for reading
open (FILEIN, "<$FileIn") or die ("Can not open $FileIn for reading:  $!.\n");
open (FILEOUT, ">$FileOut") or die ("Can not open $FileOut for reading:  $!.\n");
binmode(FILEIN);
binmode(FILEOUT);
 
while (<FILEIN>) {
 
   $data=$_;
   chomp($data);
   print("Working with $data\n");
 
if ($lineno == 1){  #It is the header
      print FILEOUT $data; 
      $lineno++;
   }elsif($data =~ /^\s*$/){
      print("I have a space.\n");
      $linecounter=0;
   }elsif($data =~ /\d+\/{1}\d+\/{1}\d+/){
      $date=$data;
   }elsif($data =~ /"(\w*),\s*(\w+)\s+([0-9]{2,})"/){ #Is it a City State zip
            print("City is $1 State is $2 and Zip is $3 Linecounter $linecounter.\n");
            $csvline[$linecounter]= $1;
            $linecounter++;
            $csvline[$linecounter]= $2;
            $linecounter++;
            $csvline[$linecounter]= $3;
            $linecounter++;
            print ("@csvline\n");
   }elsif($data =~/\s*\d+-\d+-\d+/){
        print("I have a phone of $data\n");
        $csvline[$linecounter] = $data;
        print ("A complete record\n");
        print ("$csvline[0], $csvline[1], $csvline[2], $csvline[3], $csvline[4]\n");
        print ("A complete record: @csvline\n");          
        $data=join(', ', @csvline);
        print FILEOUT $data;
        #print FILEOUT "\n";
        $#csvline = -1;  #clear all values in the array  
        $linecounter = 0;
   }else{
       chomp($data);
        print("Value of line counter is $linecounter\n");
        print("Data in else statement is: $data\n");
        $csvline[$linecounter]=$data;
        print("Data in array is $csvline[$linecounter]\n");
        $linecounter++;
        print("Data in array is $csvline[0]\n");
   }
 
}#End of While Loop
close FILEIN;
close FILEOUT;
 

[KevinADC]

Are you talking about the data getting printed to the file that is messed up?

[jaynemarie]

Are you talking about the data getting printed to the file that is messed up?

Yes I want each customer record to be a line in a csv file. This program is putting new lines or return carriages and I don't know why. I am chomping the strings.

[KevinADC]

Any change the input file was created on one operating system and you are processing it on a different one? If so, chomp() may not work correctly. You may need to try a regexp instead of chomp:

$data =~ s/[\r\n]+$//;

[numberwhun]

Any change the input file was created on one operating system and you are processing it on a different one? If so, chomp() may not work correctly. You may need to try a regexp instead of chomp:

$data =~ s/[\r\n]+$//;

There is also the possibility of extending your Perl script to use the DBI module, along with the DBD::CSV module. That pretty much enables you to interact with a CSV file as if it were a database, using SQL statements and such.

It may not work for you, but hey, I figured I would throw the option on the pile for you.

Regards,

Jeff

[KevinADC]

They don't don't have a CSV file, they are converting to a CSV file.

In my above post I said "Any change..." it should have been "Any chance..."

[numberwhun]

They don't don't have a CSV file, they are converting to a CSV file.

In my above post I said "Any change..." it should have been "Any chance..."

I understand that they don't have a CSV file, but can't you use the SQL CREATE to make one and go from there? Again, just an idea.

Regards,

Jeff

[KevinADC]

I understand that they don't have a CSV file, but can't you use the SQL CREATE to make one and go from there? Again, just an idea.

Regards,

Jeff

I'm not sure.

.........

[jaynemarie]

I'm not sure.

.........

Both of these are great ideas and worked thank you very much. I am used to getchar instead of reg expressions and using modules to assist. I appreciate you both breaking the mind lock.

[KevinADC]

What worked?

.......