"require" problem?

[Michael]

Guten Morgen,
I am implementing a script that my client wants on their website. Within
the script there are several "require" statements. Any time one of these
"require" statements is executed, the script terminates.

Any ideas how I might solve this problem?
Cheers!

[Gunnar Hjalmarsson]

Michael wrote:

I am implementing a script that my client wants on their website.
Within the script there are several "require" statements. Any time
one of these "require" statements is executed, the script
terminates.

Any ideas how I might solve this problem?

How about installing the modules that it tries to require? Just a thought.

--
Gunnar Hjalmarsson
Email: http://www.gunnar.cc/cgi-bin/contact.pl

[Michael]

On Thu, 18 Mar 2004 13:40:10 +0000, Gunnar Hjalmarsson wrote:

Michael wrote:

I am implementing a script that my client wants on their website.
Within the script there are several "require" statements. Any time
one of these "require" statements is executed, the script
terminates.

Any ideas how I might solve this problem?

How about installing the modules that it tries to require? Just a thought.

The files are installed just where I believe they need to be. Here is the
code that is giving me the problem:

&require_suppor ting_libraries
(__FILE__, __LINE__,
"$path/file1.cfg",
"$path/file2.cfg",
"$path/library/file3.pl",
"$path/html/file4.pl",
"$path/library/file5.pl");

sub require_support ing_libraries
{
local ($file, $line, @require_files) = @_; local ($require_file) ;

foreach $require_file (@require_files )
{
if (-e "$require_f ile" && -r "$require_file" )
{
print "$require_f ile <br><br>";
require '$require_file' ;
}
}
}
When I run the code the path and name of the first file is printed to the
browser window. Only the first file is listed. If I comment out the
require statement, all of the files are listed. Clearly the code is
finding the files (as it makes it into the if code block) but when the
require statement is executed, the code terminates.

rats.

Is there a problem with the syntax of the require statement? Or maybe the
permissions of the files needs to be different?

Any ideas will be appreciated.
Cheers!

[Gunnar Hjalmarsson]

Michael wrote:

require '$require_file' ;
<snip>
Is there a problem with the syntax of the require statement?
Yes, it tries to require a file *literally* named '$require_file' .
Remove those quotes:

require $require_file;
Or maybe the permissions of the files needs to be different?

It seems to be checking for that.

You posted a piece of buggy code written for a several years old Perl
generation (Perl 4). You may want to advise your client to use a
modern quality script instead.

--
Gunnar Hjalmarsson
Email: http://www.gunnar.cc/cgi-bin/contact.pl

[Michael]

On Fri, 19 Mar 2004 06:59:07 +0000, Gunnar Hjalmarsson wrote:

Michael wrote:

require '$require_file' ;

<snip>

Is there a problem with the syntax of the require statement?

Yes, it tries to require a file *literally* named '$require_file' .
Remove those quotes:

require $require_file;

Or maybe the permissions of the files needs to be different?

It seems to be checking for that.

You posted a piece of buggy code written for a several years old Perl
generation (Perl 4). You may want to advise your client to use a
modern quality script instead.

The code originaly did not have the quotes around $require_file. Without
the quotes the code would terminate with an error message "Internal Server
Error". So I added them to try and fix the problem, but seem to have
created another.

rats.

[Jürgen Exner]

Michael wrote:
[...]

Without the quotes the code would terminate with an error message
"Internal Server Error".

This is not a Perl (or perl) error message. Check the server logs for the
real error message.

jue

[Gunnar Hjalmarsson]

Michael wrote:

Gunnar Hjalmarsson wrote:

Michael wrote:

Is there a problem with the syntax of the require statement?

Yes, it tries to require a file *literally* named
'$require_file' . Remove those quotes:

require $require_file;

The code originaly did not have the quotes around $require_file.
Without the quotes the code would terminate with an error message
"Internal Server Error". So I added them to try and fix the
problem, but seem to have created another.

You are obviously running the script as a CGI script, which it would
have been appropriate to let us know about in your initial message.

To have the browser display a more meaningful error message, you can
add this line somewhere at the beginning of the script:

use CGI::Carp 'fatalsToBrowse r';

--
Gunnar Hjalmarsson
Email: http://www.gunnar.cc/cgi-bin/contact.pl

[Michael]

On Fri, 19 Mar 2004 06:59:07 +0000, Gunnar Hjalmarsson wrote:

You posted a piece of buggy code written for a several years old Perl
generation (Perl 4). You may want to advise your client to use a
modern quality script instead.

Hmm. Well, that might be a good idea. I typically perfer to write
my own code, but the client insists on the one that he has purchased a few
years ago and used successfully on a previous server.
What if I replaced that mess of code with:

use '$path/file1.cfg';
use '$path/file2.cfg';
use '$path/library/file3.pl';
use '$path/html/file4.pl';
use '$path/library/file5.pl';

Given that I have read that

use somemodule();

is equivalent to:

BEGIN {require somemodule}
I figure that an attempt to make this code work will be less time than
rewriting it.

[Gunnar Hjalmarsson]

Michael wrote:

On Fri, 19 Mar 2004 06:59:07 +0000, Gunnar Hjalmarsson wrote:

You posted a piece of buggy code written for a several years old
Perl generation (Perl 4). You may want to advise your client to
use a modern quality script instead.
Hmm. Well, that might be a good idea. I typically perfer to write
my own code, but the client insists on the one that he has
purchased a few years ago and used successfully on a previous
server.

What if I replaced that mess of code with:

use '$path/file1.cfg';
use '$path/file2.cfg';
use '$path/library/file3.pl';
use '$path/html/file4.pl';
use '$path/library/file5.pl';

What happened when you tried it?

Honestly, if you are writing scripts for a client, you should know the
answer to that, or you should at least be able to figure it out
without asking here.

If you don't have access to the server's error log, did you try my
advice to load the CGI::Carp module and import the 'fatalsToBrowse r'
routine?
Given that I have read that

use somemodule();

is equivalent to:

BEGIN {require somemodule}

That's only partly true, and not relevant here, since the files you
are trying to load aren't modules, i.e. they are not *.pm files.

--
Gunnar Hjalmarsson
Email: http://www.gunnar.cc/cgi-bin/contact.pl

[Joe Smith]

Gunnar Hjalmarsson wrote:

Michael wrote:

require $require_file;

The code originaly did not have the quotes around $require_file.
Without the quotes the code would terminate with an error message
"Internal Server Error". So I added them to try and fix the
problem, but seem to have created another.

You are obviously running the script as a CGI script, which it would
have been appropriate to let us know about in your initial message.

To have the browser display a more meaningful error message, you can
add this line somewhere at the beginning of the script:

use CGI::Carp 'fatalsToBrowse r';

In addition to the above advice, make sure that each of your
require files ends with

1;

so that perl will recognize that the file was included successully.
-Joe