Q: string substitution in a file

[Troll]

Hi,

This is what I have:

#!/usr/bin/perl -w
use strict;

sub replace {
s/one/two/;
}

open (INFILE, "ARGV[1]") || etc...
while (<INFILE>) {
replace ();
print $_;
}

but the file contents do not get replaced from one to two. Any hints?

[John Bokma]

Troll wrote:

Hi,

This is what I have:

#!/usr/bin/perl -w
use strict;

sub replace {
s/one/two/;
}

open (INFILE, "ARGV[1]") || etc... ^^^^ that's not perl
while (<INFILE>) {
replace ();
print $_;
}

but the file contents do not get replaced from one to two. Any hints?

I guess that there is no file ARGV[1]?

--
Kind regards, virtual home: http://johnbokma.com/ ICQ: 218175426
web site hints: http://johnbokma.com/websitedesign/
John I count my toes ~ one to ten ~ I meditate ~ and feel the Zen

[Kaynon McChag]

It looked fine to my eye, so I tried it. Your version was dying at line 8
where it was trying to read in the argument ARGV[1]; I replaced your open
command with my own way of doing things:

my $file = shift;
open (INFILE, $file) or die "Couldn't open $file: $!";

...and the script worked fine.

[kmc@spire:~]$ cat infile
I have one monkey
I have one manatee
I wish I had one bonobo

[kmc@spire:~]$ test.pl infile.txt
I have two monkey
I have two manatee
I wish I had two bonobo
"Troll" <ab***@microsof t.com> wrote in message
news:7l******** ************@ne ws-server.bigpond. net.au...
| Hi,
|
| This is what I have:
|
| #!/usr/bin/perl -w
| use strict;
|
| sub replace {
| s/one/two/;
| }
|
| open (INFILE, "ARGV[1]") || etc...
| while (<INFILE>) {
| replace ();
| print $_;
| }
|
| but the file contents do not get replaced from one to two. Any hints?
|
|

[Troll]

"John Bokma" <po********@cas tleamber.com> wrote in message
news:10******** *******@halkan. kabelfoon.nl...

Troll wrote:

Hi,

This is what I have:

#!/usr/bin/perl -w
use strict;

sub replace {
s/one/two/;
}

open (INFILE, "ARGV[1]") || etc...

^^^^ that's not perl

while (<INFILE>) {
replace ();
print $_;
}

but the file contents do not get replaced from one to two. Any hints?

I guess that there is no file ARGV[1]?

--
Kind regards, virtual home: http://johnbokma.com/ ICQ: 218175426
web site hints: http://johnbokma.com/websitedesign/
John I count my toes ~ one to ten ~ I meditate ~ and feel the Zen

Sorry John. I could have included more info. The script is run like
$ replace.pl DIR file.txt <<< where DIR is the directory location of the
file and file.txt is the file itself. Both exist.

What I'm trying to do is pass the directory name and the filename as command
line parameters. This file then gets modified ie. one is replaced with two.
Is this clearer?

Sorry there was a typo here. Doesn't this open the file.txt passed thru the
command line?
open (INFILE, "$ARGV[1]") || etc...

[Troll]

*snip*

open (INFILE, "ARGV[1]") || etc... ^^^^ that's not perl

while (<INFILE>) {
replace ();
print $_;
}

but the file contents do not get replaced from one to two. Any hints?

I guess that there is no file ARGV[1]?

--
Kind regards, virtual home: http://johnbokma.com/ ICQ: 218175426
web site hints: http://johnbokma.com/websitedesign/
John I count my toes ~ one to ten ~ I meditate ~ and feel the Zen

Sorry John. I could have included more info. The script is run like
$ replace.pl DIR file.txt <<< where DIR is the directory location of the
file and file.txt is the file itself. Both exist.

What I'm trying to do is pass the directory name and the filename as

command line parameters. This file then gets modified ie. one is replaced with two. Is this clearer?

Sorry there was a typo here. Doesn't this open the file.txt passed thru the command line?
open (INFILE, "$ARGV[1]") || etc...

Actually there's one more line in the script which I omitted. Sorry:

#!/usr/bin/perl -w
use strict;
chdir $ARGV[0]; # changes to the location of the file

sub replace {
s/one/two/;

[Troll]

"Kaynon McChag" <ka***********@ allstream.net> wrote in message
news:9u******** ***********@new s02.bloor.is.ne t.cable.rogers. com...

It looked fine to my eye, so I tried it. Your version was dying at line 8
where it was trying to read in the argument ARGV[1]; I replaced your open
command with my own way of doing things:

my $file = shift;
open (INFILE, $file) or die "Couldn't open $file: $!";

..and the script worked fine.

[kmc@spire:~]$ cat infile
I have one monkey
I have one manatee
I wish I had one bonobo

[kmc@spire:~]$ test.pl infile.txt
I have two monkey
I have two manatee
I wish I had two bonobo
"Troll" <ab***@microsof t.com> wrote in message
news:7l******** ************@ne ws-server.bigpond. net.au...
| Hi,
|
| This is what I have:
|
| #!/usr/bin/perl -w
| use strict;
|
| sub replace {
| s/one/two/;
| }
|
| open (INFILE, "ARGV[1]") || etc...
| while (<INFILE>) {
| replace ();
| print $_;
| }
|
| but the file contents do not get replaced from one to two. Any hints?
|
|

This is odd. I have exactly this:
#!/usr/bin/perl -w
use strict;

sub replace {
s/one/two/g;
}

open (INFILE, "$ARGV[1]") || etc... <<< there was a typo here in the
original post as it had no $
while (<INFILE>) {
replace ();
print $_;
}

I even tried what u suggested Kaynon with no luck:
my $file = shift;
open (INFILE, $file) or die "Couldn't open $file: $!";

My output from print $_ looks like:
two
two
two

but cat test.txt still gives me:
one
one
one

I may need a rest...

[Kris Wempa]

I think you are a little confused about what your program is doing. It will
NOT change the original file. It's simply reading the file line by line and
changing the STRING from 'one' to 'two'. If you want the file to change,
you'll have to specifically print the changed lines back to a filehandle.
If your program is printing out a bunch of 'two's, then it is behaving
correctly.
"Troll" <ab***@microsof t.com> wrote in message
news:w7******** ************@ne ws-server.bigpond. net.au...

This is odd. I have exactly this:
#!/usr/bin/perl -w
use strict;

sub replace {
s/one/two/g;
}

open (INFILE, "$ARGV[1]") || etc... <<< there was a typo here in the
original post as it had no $
while (<INFILE>) {
replace ();
print $_;
}

I even tried what u suggested Kaynon with no luck:
my $file = shift;
open (INFILE, $file) or die "Couldn't open $file: $!";

My output from print $_ looks like:
two
two
two

but cat test.txt still gives me:
one
one
one

I may need a rest...