String data not properly read from Windows Registry

[CrimeMaster]

Hi
i have made a Key under the HKEY_LOCAL_MACH INE\Software\My
Toolbar\Setting .
i have placed some values under the Setting key.
i m trying to access the values under that key and want to map them to
a dialog box ,means they should be visible in their corresponding Edit
controls when i display the dialog.i have used the following code in
OnInitDialog() function to map the values to their corresponding
controls but when the dialog displayed some values are repeatedly shown

in different controls.tell me where i m doing a mistake .

CRegKey regKey;
TCHAR szPath[] = _T("SOFTWARE\\M ySpace.com
ToolBar\\Settin g");
TCHAR szBuff[1024];
DWORD dwSize=dwSize = sizeof(szBuff)/sizeof(szBuff[0]);
LONG err=regKey.Open (HKEY_LOCAL_MAC HINE,szPath);
if (err!=ERROR_SUC CESS)
regKey.Close();
regKey.QueryVal ue(szBuff, _T("FirstName") , &dwSize);
m_FirstName = szBuff;
regKey.QueryVal ue(szBuff, _T("LastName") , &dwSize);
m_LastName= szBuff;
regKey.QueryVal ue(szBuff, _T("PresentAddr ess"), &dwSize);
m_PresentAddres s= szBuff;
regKey.QueryVal ue(szBuff, _T("PermanentAd dress"), &dwSize);
m_PermanentAddr ess = szBuff;
regKey.QueryVal ue(szBuff, _T("City"), &dwSize);
m_City= szBuff;
regKey.QueryVal ue(szBuff, _T("Country"), &dwSize);
m_Country = szBuff;
regKey.QueryVal ue(szBuff, _T("ZipCode"), &dwSize);
m_Zip= szBuff;
regKey.QueryVal ue(szBuff, _T("PhoneNo"), &dwSize);
m_Phone=szBuff;
regKey.QueryVal ue(szBuff, _T("MobileNo") , &dwSize);
m_Mobile = szBuff;
regKey.QueryVal ue(szBuff, _T("AutofillEma il"), &dwSize);
m_EmailAddress = szBuff;
UpdateData(fals e);
when the dialog displayed often LastName value from registry is
displayed in the m_PresentAddres s and m_PermanentAddr ess edit
controls.and City Value fron registry id
also displayed in m_Country edit control.in the same way some values
are retrieving from registry and when i try to map them with edit
controls on the Dialog box .why did they are ?

[Bruno van Dooren]

> i have made a Key under the HKEY_LOCAL_MACH INE\Software\My

Toolbar\Setting .
i have placed some values under the Setting key.
i m trying to access the values under that key and want to map them to
a dialog box ,means they should be visible in their corresponding Edit
controls when i display the dialog.i have used the following code in
OnInitDialog() function to map the values to their corresponding
controls but when the dialog displayed some values are repeatedly shown

in different controls.tell me where i m doing a mistake .

CRegKey regKey;
TCHAR szPath[] = _T("SOFTWARE\\M ySpace.com
ToolBar\\Settin g");
TCHAR szBuff[1024];
DWORD dwSize=dwSize = sizeof(szBuff)/sizeof(szBuff[0]);
LONG err=regKey.Open (HKEY_LOCAL_MAC HINE,szPath);
if (err!=ERROR_SUC CESS)
regKey.Close();
regKey.QueryVal ue(szBuff, _T("FirstName") , &dwSize);
m_FirstName = szBuff;
regKey.QueryVal ue(szBuff, _T("LastName") , &dwSize);
m_LastName= szBuff;
regKey.QueryVal ue(szBuff, _T("PresentAddr ess"), &dwSize);
m_PresentAddres s= szBuff;

2 things:
- you don't check the return value of QueryValue. shame on you.
- you don't re-initialize the dwSize value before each call to QueryValue.
from MSDN: "pdwCount
The size of the string data. Its value is initially set to the size of the
szValue buffer."
you should initialize it to the max string size before each call.

another thing is that QueryValue is depreceated in favor of this method:
LONG QueryValue(
LPCTSTR pszValueName,
DWORD* pdwType,
void* pData,
ULONG* pnBytes
) throw( );

also, this looks weird:
DWORD dwSize=dwSize = sizeof(szBuff)/sizeof(szBuff[0]);

--

Kind regards,
Bruno.
br************* *********@hotma il.com
Remove only "_nos_pam"

[Egbert Nierop \(MVP for IIS\)]

"CrimeMaste r" <aj******@gmail .com> wrote in message
news:11******** *************@c 74g2000cwc.goog legroups.com...

Hi
i have made a Key under the HKEY_LOCAL_MACH INE\Software\My
Toolbar\Setting .
i have placed some values under the Setting key.
i m trying to access the values under that key and want to map them to
a dialog box ,means they should be visible in their corresponding Edit
controls when i display the dialog.i have used the following code in
OnInitDialog() function to map the values to their corresponding
controls but when the dialog displayed some values are repeatedly shown

in different controls.tell me where i m doing a mistake .

regKey.QueryVal ue(szBuff, _T("City"), &dwSize);
m_City= szBuff;

In addition to what Bruno sais,
why don't you use
LONG result = regKey.QueryStr ingValue(_T("Ci ty"), szBuff, &dwSize);

[CrimeMaster]

Egbert Nierop (MVP for IIS) wrote:

"CrimeMaste r" <aj******@gmail .com> wrote in message
news:11******** *************@c 74g2000cwc.goog legroups.com...

Hi
i have made a Key under the HKEY_LOCAL_MACH INE\Software\My
Toolbar\Setting .
i have placed some values under the Setting key.
i m trying to access the values under that key and want to map them to
a dialog box ,means they should be visible in their corresponding Edit
controls when i display the dialog.i have used the following code in
OnInitDialog() function to map the values to their corresponding
controls but when the dialog displayed some values are repeatedly shown

in different controls.tell me where i m doing a mistake .

regKey.QueryVal ue(szBuff, _T("City"), &dwSize);
m_City= szBuff;

In addition to what Bruno sais,
why don't you use
LONG result = regKey.QueryStr ingValue(_T("Ci ty"), szBuff, &dwSize);

Thanks dear
But not discourage me
its working.

Crime Master.