AJAX innerHTML problem

[noddy]

The full code relating to this question can be found at
http://marc.info/?l=php-general&m=112198633625636&w=2

It describes a bare bones way of making an AJAX request.
It works fine for me except at the last step where data is put into an
innerHTML element within
<div id="foo">
</div>

Here is the function to do that:

function handleResponse() {
if(http.readyState == 4){
var response = http.responseText;
var update = new Array();
// var up0 = update[0];
// alert("up0 is " + up0);
if(response.indexOf('|' != -1)) {
update = response.split('|');
document.getElementById(update[0]).innerHTML = update[1];
}
}
}

I get an error stating that getElementById(update[0]) is either null
or not an object>

Using the commented out alert code I have confirmed that the update
array does in fact contain "foo" in update[0].

If I hardcode the value "foo" into the line thus
document.getElementById("foo").innerHTML = update[1];

update[1] is displayed ok within the foo div without error
I would be gratefulif somone could explain to me what is causing this
error

TIA
N

[Erwin Moller]

noddy wrote:

The full code relating to this question can be found at
http://marc.info/?l=php-general&m=112198633625636&w=2

It describes a bare bones way of making an AJAX request.
It works fine for me except at the last step where data is put into an
innerHTML element within
<div id="foo">
</div>

Here is the function to do that:

function handleResponse() {
if(http.readyState == 4){
var response = http.responseText;
var update = new Array();
// var up0 = update[0];
// alert("up0 is " + up0);
if(response.indexOf('|' != -1)) {
update = response.split('|');
document.getElementById(update[0]).innerHTML = update[1];
}
}
}

I get an error stating that getElementById(update[0]) is either null
or not an object>

Using the commented out alert code I have confirmed that the update
array does in fact contain "foo" in update[0].

If I hardcode the value "foo" into the line thus
document.getElementById("foo").innerHTML = update[1];

update[1] is displayed ok within the foo div without error
I would be gratefulif somone could explain to me what is causing this
error

Hi,

This has nothing to do with AJAX.

Just alert (http.responseText);
to see what the response contains.
According to your code it should contain at least one |
I expect it doesn't.

an example:
var test = "one|two";
var myArr = test.split("|");
alert (myArr[0]);
alert (myArr[0]);
alert (myArr[2]);

The last alert will fail because the element is never filled by the split
return array since it contains only 2 elements.

I expect you have a similar problem in your responsetext.

In general: Always examine the response from an Ajax request.

Regards,
Erwin Moller

>
TIA
N

[Tom Cole]

On Mar 20, 6:52 am, noddy <[e-mail]:

The full code relating to this question can be found athttp://marc.info/?l=php-general&m=112198633625636&w=2

It describes a bare bones way of making an AJAX request.
It works fine for me except at the last step where data is put into an
innerHTML element within
<div id="foo">
</div>

Here is the function to do that:

function handleResponse() {
if(http.readyState == 4){
var response = http.responseText;
var update = new Array();
// var up0 = update[0];
// alert("up0 is " + up0);
if(response.indexOf('|' != -1)) {

Oops... should be if (response.indexOf('|') >= 0) {

update = response.split('|');
document.getElementById(update[0]).innerHTML = update[1];

You should confirm that the length of the array is also 2:

if (update.length >= 2) {
document.getElementById(update[0]).innerHTML = update[1];
}

}
}

}

I get an error stating that getElementById(update[0]) is either null
or not an object>

Using the commented out alert code I have confirmed that the update
array does in fact contain "foo" in update[0].

If I hardcode the value "foo" into the line thus
document.getElementById("foo").innerHTML = update[1];

update[1] is displayed ok within the foo div without error

I would be gratefulif somone could explain to me what is causing this
error

TIA
N

[noddy]

On Tue, 20 Mar 2007 12:51:52 +0100, Erwin Moller
<si******************************************@spam yourself.comwrote:

>Hi,

This has nothing to do with AJAX.

You are right - I am resending the query more appropriatelyhead

>Just alert (http.responseText);
to see what the response contains.
According to your code it should contain at least one |
I expect it doesn't.

Thank you but it does

N

[noddy]

On 20 Mar 2007 05:52:36 -0700, "Tom Cole" <tc****@gmail.comwrote:

> if(response.indexOf('|' != -1)) {

Oops... should be if (response.indexOf('|') >= 0) {

Really?
This line as it is seems to confirm the presence orabsence of | in
the string just fine

>

> update = response.split('|');
document.getElementById(update[0]).innerHTML = update[1];

You should confirm that the length of the array is also 2:

The length of the array is 2 .
Thanks for your response.

N

[Randy Webb]

noddy said the following on 3/21/2007 12:00 AM:

On 20 Mar 2007 05:52:36 -0700, "Tom Cole" <tc****@gmail.comwrote:

>> if(response.indexOf('|' != -1)) {

Oops... should be if (response.indexOf('|') >= 0) {

Really?
This line as it is seems to confirm the presence orabsence of | in
the string just fine

No, it doesn't test the presence of |, it checks the presence of '|' !=
-1 You need to move the equality comparison outside the parentheses of
the indexOf search.

--
Randy
Chance Favors The Prepared Mind
comp.lang.javascript FAQ - http://jibbering.com/faq/index.html
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/