Changing a variable with onClick

[ndeeley]

HI,

How can I change a form variable with onClick?

I have a table which shows the results of a ColdFusion query. I need to have a drop down list box showing the other queries that could be sprayed into the table and want to change the variable storing the query to achieve this.

Any ideas would be appreciated!

thanks
Neil

[Dormilich]

basicly

var sql = select.value;

where select is your drop down box. (if I understand you right)

[juanmendes]

Does the drop down contain the actual SQL? That sounds injection prone. It doesn't have to be if you're careful, make sure you're not using the sql from the client directly. The drop down should contain ids that reference the queries that are hard coded on the server

[ndeeley]

hi both,

Thanks for your help. What I have actually done is generated all my tables then just hidden then with some .css, using a javascript function to show the relevant table when the link is used:

<script language="JavaScript">
//here you place the ids of every element you want.
var ids=new Array('s1','s2','s3','s4','s5','s6','c1','c2','c3','c4','c5','c6');
 
function switchid(id){    
    hideallids();
    showdiv(id);
}
 
function hideallids(){
    //loop through the array and hide each element by id
    for (var i=0;i<ids.length;i++){
        hidediv(ids[i]);
    }          
}
 
function hidediv(id) {
    //safe function to hide an element with a specified id
    if (document.getElementById) { // DOM3 = IE5, NS6
        document.getElementById(id).style.display = 'none';
    }
    else {
        if (document.layers) { // Netscape 4
            document.id.display = 'none';
        }
        else { // IE 4
            document.all.id.style.display = 'none';
        }
    }
}
 
function showdiv(id) {
    //safe function to show an element with a specified id
 
    if (document.getElementById) { // DOM3 = IE5, NS6
        document.getElementById(id).style.display = 'block';
    }
    else {
        if (document.layers) { // Netscape 4
            document.id.display = 'block';
        }
        else { // IE 4
            document.all.id.style.display = 'block';
        }
    }
}
</script>

Thanks
Neil

[juanmendes]

Looks like a good solution, but your js code is sooooo 1995. do you really need to support browsers that don't support getElementById?

Also, your script tag shouldn't contain a language attribute, it should be

<script type="text/javascript">

[acoder]

Correct. Change hidediv and showdiv to the following:

function hidediv(id) {
    document.getElementById(id).style.display = 'none';
}
 
function showdiv(id) {
    document.getElementById(id).style.display = 'block';
}

[ndeeley]

Thanks - i have changed it and it works fine!