emulating document.docume ntElement on pre W3C DOM browsers

[Aaron Gray]

(Please tell me if this is silly or I am barking up the wrong tree)

Can someone check this please on pre W3C DOM browsers :-

function getDocumentRoot ()
{
for ( e in document.childN odes)
if ( document.childN odes[e].nodeName == "HTML")
return document.childN odes[e];
return document.body;
}

if (!document.docu mentElement)
document.docume ntElement = getDocumentRoot ();

There's an html test page here :-

http://www.aarongray.org/Test/JavaSc...ment-test.html

There's also a test for document.getEle mentById() emulation here :-

http://www.aarongray.org/Test/JavaSc...ById-test.html

Many thanks in advance,

Aaron

[Richard Cornford]

Aaron Gray wrote:

Richard Cornford wrote:

>Aaron Gray wrote:

<snip>

>>Can someone check this please on pre W3C DOM browsers :-

<snip>

>> function getDocumentRoot ()
{
for ( e in document.childN odes)

<snip>

>... IE 4 and Netscape 4 exit here.

<snip>

Great, thats cut the lower end off at IE4 and NN4.

So which "pre W3C DOM browsers" come after IE 4 and NN4? I suppose
Konqueror 2 might have fallen into that gap, but its "experiment al"
script engine was so far short of any ECMAScript specification that it
could hardly execute scripts at all (and certainly nothing modern (not
having support for, for example, function expressions)).

Richard.

[SAM]

Gregor Kofler a écrit :

[1]
http://www.jslint.com/

JSLint is completely mad if not crazy !
Only trying to follow how it thinks indentations have to be
gives a code unreadable for me.
--
sm

[Aaron Gray]

"Richard Cornford" <Ri*****@litote s.demon.co.ukwr ote in message
news:g5******** ***********@new s.demon.co.uk.. .

Aaron Gray wrote:

>Richard Cornford wrote:

>>Aaron Gray wrote:

<snip>

>>>Can someone check this please on pre W3C DOM browsers :-

<snip>

>>> function getDocumentRoot ()
{
for ( e in document.childN odes)

<snip>

>>... IE 4 and Netscape 4 exit here.

<snip>

>Great, thats cut the lower end off at IE4 and NN4.

So which "pre W3C DOM browsers" come after IE 4 and NN4? I suppose
Konqueror 2 might have fallen into that gap, but its "experiment al" script
engine was so far short of any ECMAScript specification that it could
hardly execute scripts at all (and certainly nothing modern (not having
support for, for example, function expressions)).

Thanks Richard, that hopefully just about wraps that one up then.

Aaron

[Aaron Gray]

"SAM" <st************ *********@wanad oo.fr.invalidwr ote in message
news:48******** *************@n ews.orange.fr.. .

Gregor Kofler a écrit :

>[1]
http://www.jslint.com/

JSLint is completely mad if not crazy !
Only trying to follow how it thinks indentations have to be
gives a code unreadable for me.

Oh! Have not had chance to try it out yet ! Could be fun, or maybe not fun
:)

What indenting scheme do you use ?

Aaron

[Gregor Kofler]

SAM meinte:

Gregor Kofler a écrit :

>[1]
http://www.jslint.com/

JSLint is completely mad if not crazy !

It isn't. It's perfect for tracking down those otherwise extremely hard
to find bugs.

Only trying to follow how it thinks indentations have to be
gives a code unreadable for me.

What indentations? JSLint normally offers explanations why to follow
certain practices and guidelines. My code stays perfectly readable - in
fact I didn't have to change anything of my usual formatting.

Gregor
--
http://photo.gregorkofler.at ::: Landschafts- und Reisefotografie
http://web.gregorkofler.com ::: meine JS-Spielwiese
http://www.image2d.com ::: Bildagentur für den alpinen Raum

[SAM]

Gregor Kofler a écrit :

SAM meinte:

>Gregor Kofler a écrit :

>>[1]
http://www.jslint.com/

JSLint is completely mad if not crazy !

It isn't. It's perfect for tracking down those otherwise extremely hard
to find bugs.

Perhaps, I don't know.
Which checkboxes do you choose for that ?

>Only trying to follow how it thinks indentations have to be
gives a code unreadable for me.

What indentations? JSLint normally offers explanations why to follow
certain practices and guidelines. My code stays perfectly readable - in
fact I didn't have to change anything of my usual formatting.

He bien, tant mieux.

I use to do ie :

if(truc>0) {
dothat();
if(foo) return;
}

or in expanded, delayed, that I rarely use :

if(truc>0)
{
dothat();
if(foo)
{
return;
}
}
and I think JSLint wants

if ( truc 0 )
{
dothat();
if ( foo )
{
return;
}
}

With these '{' '}' not aligned on the contained instructions
and all this almost blank lines and all these white spaces
I'm lost :-(

I have only a 20" screen.
(my way : 4 lines, JSLint way : 8 lines)

--
sm

[Gregor Kofler]

SAM meinte:

JSLint doesn't like that.

if(foo) return;

if(foo) { return; } is "correct".

and I think JSLint wants

if ( truc 0 )
{
dothat();
if ( foo )
{
return;
}
}

Nope.

JSLint wants it the Kernighan-Ritchie style

if ( truc 0) {
if(...) {
}
}

It prvents the bugs induced by the auto semicolon insertion. JSLint
doesn't care about indentation.

I have only a 20" screen.
(my way : 4 lines, JSLint way : 8 lines)

No. It becomes less.

Gregor

--
http://photo.gregorkofler.at ::: Landschafts- und Reisefotografie
http://web.gregorkofler.com ::: meine JS-Spielwiese
http://www.image2d.com ::: Bildagentur für den alpinen Raum

[SAM]

Gregor Kofler a écrit :

>
JSLint wants it the Kernighan-Ritchie style

if ( truc 0) {
if(...) {
}
}

So I didn't check the good checkboxe(s) on my last try of JSLint ?
(recommended options)

--
sm

[Gregor Kofler]

SAM meinte:

Gregor Kofler a écrit :

>>
JSLint wants it the Kernighan-Ritchie style

if ( truc 0) {
if(...) {
}
}

So I didn't check the good checkboxe(s) on my last try of JSLint ?
(recommended options)

I normally use the default checkboxes.

In your example above JSLint accepts
if()
{..
}

However,
if() foo();
is not accepted.

Gregor
--
http://photo.gregorkofler.at ::: Landschafts- und Reisefotografie
http://web.gregorkofler.com ::: meine JS-Spielwiese
http://www.image2d.com ::: Bildagentur für den alpinen Raum

[SAM]

Gregor Kofler a écrit :

SAM meinte:

>Gregor Kofler a écrit :

>>>
JSLint wants it the Kernighan-Ritchie style

if ( truc 0) {
if(...) {
}
}

So I didn't check the good checkboxe(s) on my last try of JSLint ?
(recommended options)

I normally use the default checkboxes.

In your example above JSLint accepts
if()
{..
}

However,
if() foo();
is not accepted.

Yes yes yes understood (while these missing {} are optional)

but with my "normal" way ...
30 lines to tell white spaces missing and wrong indentation
Without forgiving unknown variables

>
Gregor