"Reference to Undefined Variable" say what?

[Markus]

I was just playing around with javascript today and i wanted to change the style of a table element with javascript.

The code i am using:

ChangeIt(id){
var target = document.getElementById(id)
var newColor = "#00ff33"
target.style.color = newColor
}
 

The php (this is from withing a while loop):
[php]
echo("<tr bgcolor=".$bgco lor.">
<td id=\"s".$counte r."\" onclick=\"Chang eIt('s".$counte r."');\">\n") ;
echo $counter;
$counter++; //increment counter
echo("</td><td>\n");
echo($row['url']);
echo("</td><td>\n");
echo($row['Util_Uploaded']);
echo("</td></tr>\n");
}
[/php]

I'm trying to get an onclick event where it catches the ID of the tag and then changes the style of said tag.

I get this error though:
Event thread: click
Error:
name: ReferenceError
message: Statement on line 1: Reference to undefined variable: ChangeIt
Backtrace:
Line 1 of script
ChangeIt("s2");
At unknown location
[statement source code not available]

What am i doing wrong?

Thanks.

[Ferris]

hi

change your javascript code into:

function ChangeIt(id){
          var target = document.getElementById(id);
          var newColor = "#00ff33";
          target.style.color = newColor;
}
 

hope it helps.

[Markus]

How stupid am i!?!

I would've stewed over that for hours, over a simple 'function'. I can't believe i missed that, haha.

Thanks a bunch man :D

[Markus]

New problem:

If i add some if and else statements in, i get the Reference to Undefined Variable ChangeIt

function ChangeIt(id){
var target = document.getElementById(id)
var newColor = "#00ff33"
if(target.bgColor != newColor){
    target.bgColor = newColor
} else {
    target.bgColor = "#ffffff"
}
 

Problem solved, hah.
Missed the last '}' out

:)