I'm aware of the circular reference memory leak problem with IE/closures.
I'm not sure exactly how to resolve it in this situation. Also, Firefox
appears to grow its memory size with the same code. So I'm wondering if I'm
missing something?
My test code is as follows:
function myObj() {
var req = new Object();
req.temp = 0;
if (window.XMLHttp Request) { req.xmlHttpRequ est = new XMLHttpRequest( ); }
else if (window.ActiveX Object) { req.xmlHttpRequ est = new
ActiveXObject(" Msxml2.XMLHTTP" ); }
req.xmlHttpRequ est.onreadystat echange =
function() {
if (req.readyState ==4) {
req.temp = req.xmlHttpRequ est.responseTex t;
}
};
req.xmlHttpRequ est.open("GET", "/",true);
req.xmlHttpRequ est.send(null);
return req;
}
// Create a whole bunch of these objects to check for memory leak
for (var i=0; i<1000; i++) {
var x = new myObj();
}
What is the best way to avoid memory leaking in this example?
--
Matt Kruse http://www.JavascriptToolbox.com 10 14073
Matt Kruse wrote: I'm aware of the circular reference memory leak problem with IE/closures. I'm not sure exactly how to resolve it in this situation. Also, Firefox appears to grow its memory size with the same code. So I'm wondering if I'm missing something?
My test code is as follows:
function myObj() { var req = new Object(); req.temp = 0; if (window.XMLHttp Request) { req.xmlHttpRequ est = new XMLHttpRequest( ); } else if (window.ActiveX Object) { req.xmlHttpRequ est = new ActiveXObject(" Msxml2.XMLHTTP" ); } req.xmlHttpRequ est.onreadystat echange = function() { if (req.readyState ==4) { req.temp = req.xmlHttpRequ est.responseTex t; } }; req.xmlHttpRequ est.open("GET", "/",true); req.xmlHttpRequ est.send(null); return req; } // Create a whole bunch of these objects to check for memory leak for (var i=0; i<1000; i++) { var x = new myObj(); }
What is the best way to avoid memory leaking in this example?
-- Matt Kruse http://www.JavascriptToolbox.com
Not sure if this will solve your problem, but I noticed a few wasted
resources and unclear code.
First, when you say: function myObj() { var req = new Object();
You are actually instantiating two objects for every call to new myObj.
Second: req.xmlHttpRequ est.onreadystat echange = function() { if (req.readyState ==4) { req.temp = req.xmlHttpRequ est.responseTex t; } };
For everything within the anonymous function, req should be 'this'.
This is how I would I would rewrite this:
function makeXMLRequest( URI ) {
var x = (
window.XMLHttpR equest ?
( new XMLHttpRequest( ) )
: ( new ActiveXObject( 'Msxml2.XMLHTTP ' ) )
);
x.open( 'GET', encodeURI( URI || 'about :blank' ), true );
x.send( null );
return x;
}
Now a call to x = makeXMLRequest (NOT new makeXMLRequest) will return
an instance of either XMLHttpRequest OR a new ActiveXObject of type
'Msxml2.XMLHTTP '.
This should result in more efficient garbage collection as well.
The real problem (I think) is that you are creating all of these
objects and not necessarily giving them time to complete the HTTP
request. This is probably preventing the necessary garbage collection
and creating 1000 simultaneous HTTP requests. Ouch.
Hope that helps.
Random wrote: First, when you say: function myObj() { var req = new Object(); You are actually instantiating two objects for every call to new myObj.
This is a simplified example of my real case, which needs to do this. But
that's unrelated...
This is how I would I would rewrite this:
Well, that doesn't something entirely different. You can't really solve a
problem by rewriting it and removing functionality, can you? :)
Now a call to x = makeXMLRequest (NOT new makeXMLRequest) will return an instance of either XMLHttpRequest OR a new ActiveXObject of type 'Msxml2.XMLHTTP '. This should result in more efficient garbage collection as well.
Well that's because you've removed the handling function completely!
--
Matt Kruse http://www.JavascriptToolbox.com
Matt Kruse wrote: if (req.readyState ==4) {
Oops, this is actually:
if (req.xmlHttpReq uest.readyState ==4) {
of course :)
--
Matt Kruse http://www.JavascriptToolbox.com
Matt Kruse wrote: I'm aware of the circular reference memory leak problem with IE/closures. I'm not sure exactly how to resolve it in this situation. Also, Firefox appears to grow its memory size with the same code. So I'm wondering if I'm missing something?
<snip> function myObj() { var req = new Object(); req.temp = 0; if (window.XMLHttp Request) { req.xmlHttpRequ est = new XMLHttpRequest( ); } else if (window.ActiveX Object) { req.xmlHttpRequ est = new ActiveXObject(" Msxml2.XMLHTTP" ); } req.xmlHttpRequ est.onreadystat echange = function() { if (req.readyState ==4) { req.temp = req.xmlHttpRequ est.responseTex t;
req.xmlHttpRequ est.onreadystat echange = null;
- At this point will remove the curricular reference and free the
closure.
} }; req.xmlHttpRequ est.open("GET", "/",true); req.xmlHttpRequ est.send(null); return req; }
<snip> What is the best way to avoid memory leaking in this example?
Belt and braces would have you nulling the reference to the
XMLHttpRequest object once it is finished with.
Richard.
Richard Cornford wrote:
<snip> - At this point will remove the curricular reference ...
<snip> ^^^^^^^^^^
That should have been 'circular'.
Richard.
Richard Cornford wrote: req.xmlHttpRequ est.onreadystat echange = null; - At this point will remove the curricular reference and free the closure.
That's what I thought too, but no luck. IE says "type mismatch".
Instead, I found that this appears to work:
delete req.xmlHttpRequ est['onreadystatech ange'];
And in fact, I'm doing this just to be safe:
delete req.xmlHttpRequ est['onreadystatech ange'];
req.xmlHttpRequ est = null;
req = null;
CollectGarbage( );
That *appears* to work in IE. I can see the memory usage grow to over 150MB,
then drop back to 30MB, so I assume the leak is gone. However, I don't know
of any way to test for sure. Do you?
--
Matt Kruse http://www.JavascriptToolbox.com
Matt Kruse wrote: Random wrote: First, when you say: function myObj() { var req = new Object(); You are actually instantiating two objects for every call to new myObj.
This is a simplified example of my real case, which needs to do this. But that's unrelated...
Clearly I misunderstood. Sorry I didn't catch that based on your
original post. This is how I would I would rewrite this:
Well, that doesn't something entirely different. You can't really solve a problem by rewriting it and removing functionality, can you? :)
See above. Now a call to x = makeXMLRequest (NOT new makeXMLRequest) will return an instance of either XMLHttpRequest OR a new ActiveXObject of type 'Msxml2.XMLHTTP '. This should result in more efficient garbage collection as well.
Well that's because you've removed the handling function completely!
See above.
Matt Kruse wrote: Richard Cornford wrote: req.xmlHttpRequ est.onreadystat echange = null; - At this point will remove the curricular reference and free the closure. That's what I thought too, but no luck. IE says "type mismatch".
Yes, you are right. It looks like I went for assigning a reference to a
small harmless (and not 'inner') function to clear the closure in my
version.
<snip> And in fact, I'm doing this just to be safe:
delete req.xmlHttpRequ est['onreadystatech ange']; req.xmlHttpRequ est = null; req = null; CollectGarbage( );
<snip>
Calling CollectGarbage without verifying its existence will result in
errors on browsers that do not support it.
Richard.
i ussing xmlhttprequest for few years. Typicaly i use sinchronus data
trander
example of my uses
senddata(method ,data,debug,url )
debug = shows respondense content
myResult = sendData('updat e',{id:1,name:3 4});
after this call i get myResult javascript array (or string)
for asyncronus can be added callback function This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: Mark D. Anderson |
last post by:
About a month ago Richard Cornford did an interesting analysis of a
memory leak
in jscript (internet explorer) when there are "circular" references
between
DOM objects and (real) jscript objects:
http://groups.google.com/groups?selm=bcq6fn%24g53%241%248300dec7%40news.demon.co.uk
This message summarizes some testing I've done and their...
|
by: Robert |
last post by:
Hi,
Do I understand correctly from
http://jibbering.com/faq/faq_notes/closures.html that the following will
create a memory leak in IE?
function createMemoryLeak(id)
{
var el = document.getElementById(id);
|
by: Cylix |
last post by:
I have read an article about the memory leak issue on nowadays website,
"Circular References-When mutual references are counted between
Internet Explorer's COM infrastructure and any scripting engine,
objects can leak memory. This is the broadest pattern."
Anyone can explain this for me? How would be the coding make circular
reference?
|
by: Robert |
last post by:
Hello javascript group readers,
I have a question regarding how to prevent memory leaks in Internet
Explorer when using closures. I already knew about the circular
reference problem, and until now was able to prevent memory leak
problems. But I needed to store DOM elements and can't solve it
anymore. So I search the group archive to see if...
|
by: m0nkeymafia |
last post by:
I have spent the past few weeks trying to figure a way around this
problem, and have yet to find a good enough solution.
Internet Explorer leaks memory when I update a div container using
innerHTML, this does not occur in firefox. This would not be a problem
except the webpage is required to be left on for weeks on end without
being...
| |
by: Jay |
last post by:
I have a web app running on the windows CE device. In one of the asp.net
pages - it has javascript code. That seems to have a memory leak.
When I run the web app - in about one hour, the app hangs. I looked at the
memory and it seems to be full.
I removed all the javascript code - and the app seems to be have no leaks.
As soon as I include my...
|
by: rizwan6feb |
last post by:
I am working on an ajax chat application, done most of the work but when i tested it on IE (both on IE6 and IE7), found that there is a memory leak. The application works fine on FF. How can i fix this?
I have used ajax in the following way (this is a similar to how i am using ajax in my chat application); incrementer.php file on line # 34...
|
by: Daniel Orner |
last post by:
Hi all,
I've been trying to pin down a memory leak in IE6 for several WEEKS
now. I've done my share of googling etc., and know all about common
leaks like circular references and closures, but have found nothing like
this.
This app is designed to run in a kiosk environment, so it has
things like a persistent frame which holds data as well...
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For...
| |
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules.
He will explain when you may want to use classes...
|
by: conductexam |
last post by:
I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and then checking html paragraph one by one.
At the time of converting from word file to html my equations which are in the word document file was convert...
|
by: 6302768590 |
last post by:
Hai team
i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system
|
by: bsmnconsultancy |
last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating...
| |