removing array item

[J. J. Cale]

I have the following. There must be something less cumbersome without push
pop. The function parameter obj is the event.srcElemen t and has the
attributes(prop erties?) picNum and alb pinned to it. The function is part of
a process to delete the selected obj, a photo in this case from the album
vis albumArr. TIA
Jimbo
function Album(albumName ) {
this.name=album Name;
this.paths=new Array();
}
var albumArr(); // holds an array of Albums();
function removeArrSrc(ob j) {
var dummy=new Array();
for(i=0;i<album Arr.length;i++) {
dummy[i]=new Album(albumArr[i].name);
var el=albumArr[i].paths;
for(var j=0;j<el.length ;j++) {
if(dummy[i].name==obj.alb) {
if(j==obj.picNu m) continue;
}
var len=dummy[i].paths.length;
dummy[i].paths[len]=el[j];
}
}
albumArr=dummy;
}

[Michael Winter]

On Mon, 30 Aug 2004 11:47:41 +0200, J. J. Cale <ph****@netvisi on.net.il>
wrote:

012345678901234 567890123456789 012345678901234 567890123456789 0123456789

I have the following. There must be something less cumbersome without
push pop. The function parameter obj is the event.srcElemen t
Is this for the Web, or just an IE-only environment?
and has the attributes(prop erties?) picNum and alb pinned to it. The
function is part of a process to delete the selected obj, a photo in
this case from the album vis albumArr. TIA function Album(albumName ) {
this.name=album Name;
this.paths=new Array();
}
var albumArr(); // holds an array of Albums();
I don't know what that's supposed to be, but I'm certain it'll cause an
error on most browsers. Perhaps you meant:

var albumArr = [];
function removeArrSrc(ob j) {
var dummy=new Array();
for(i=0;i<album Arr.length;i++) {
dummy[i]=new Album(albumArr[i].name);
var el=albumArr[i].paths;
for(var j=0;j<el.length ;j++) {
if(dummy[i].name==obj.alb) {
if(j==obj.picNu m) continue;
}
var len=dummy[i].paths.length;
dummy[i].paths[len]=el[j];
}
}
albumArr=dummy;
}

How about:

function removeArrSrc(o) {
var i = 0, n = albumArr.length ;

// Find the element, 'o'
while(i < n && albumArr[i] != o) {++i;}
// If 'o' exists in the array, 'i' will now point it
if(i < n) {
// Don't want to reach the last element
--n;
// Now shift the remaining elements down
while(i < n) {albumArr[i] = albumArr[i + 1]; ++i;}
// Finally, truncate the array
albumArr.length = n;
}
}

which is removes the element in-place. You could also use:

function removeArrSrc(o) {
var i = 0, n = albumArr.length ;

// Find the element, 'o'
while(i < n && albumArr[i] != o) {++i;}
// If 'o' exists in the array, 'i' will now point it
if(i < n) {
albumArr = albumArr.slice( 0, i).concat(album Arr.slice(i + 1));
}
}

which might be a little quicker (due to being performed by the browser),
but probably isn't (due to the resulting array allocations).

I haven't tested these, by the way.

Good luck,
Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[J. J. Cale]

"Michael Winter" <M.******@bluey onder.co.invali d> wrote in message
news:opsdjinqrx x13kvk@atlantis ...

On Mon, 30 Aug 2004 11:47:41 +0200, J. J. Cale <ph****@netvisi on.net.il>
wrote:

012345678901234 567890123456789 012345678901234 567890123456789 0123456789

I have the following. There must be something less cumbersome without
push pop. The function parameter obj is the event.srcElemen t
Is this for the Web, or just an IE-only environment?

Ideally it would be generic although currently I'm writing an HTA.

and has the attributes(prop erties?) picNum and alb pinned to it. The
function is part of a process to delete the selected obj, a photo in
this case from the album vis albumArr. TIA

function Album(albumName ) {
this.name=album Name;
this.paths=new Array();
paths array holds image paths
}
var albumArr(); // holds an array of Albums();

I don't know what that's supposed to be, but I'm certain it'll cause an
error on most browsers. Perhaps you meant:

var albumArr = [];

Sorry! It is declared var albumArr=new Array();

function removeArrSrc(ob j) {
var dummy=new Array();
for(i=0;i<album Arr.length;i++) {
dummy[i]=new Album(albumArr[i].name);
var el=albumArr[i].paths;
for(var j=0;j<el.length ;j++) {
if(dummy[i].name==obj.alb) {
if(j==obj.picNu m) continue;
}
var len=dummy[i].paths.length;
dummy[i].paths[len]=el[j];
}
}
albumArr=dummy;
}

How about:

function removeArrSrc(o) {
var i = 0, n = albumArr.length ;

// Find the element, 'o'
while(i < n && albumArr[i] != o) {++i;}

the array albumArr contains an array of Album objects. I need to delete
the path for one image.
the reference obj (here 'o') has the album name and the index in the
paths array pinned as attributes
I'm searching therefore for o.alb (the album name) and o.picNum the
offset into the paths array of the Album object.
while(i<n && albumArr[i].name != o.alb) {++i} should work to
find the album
// If 'o' exists in the array, 'i' will now point it
if(i < n) {
// Don't want to reach the last element
--n;
// Now shift the remaining elements down
while(i < n) {albumArr[i] = albumArr[i + 1]; ++i;}
// Finally, truncate the array
albumArr.length = n;
}
}
This would delete the entire album. I need to delete the image from the
paths array of the album. The slice method with a regex is what I'm looking
for but I'm just getting into regex.
which is removes the element in-place. You could also use:

function removeArrSrc(o) {
var i = 0, n = albumArr.length ;

// Find the element, 'o'
while(i < n && albumArr[i] != o) {++i;}
// If 'o' exists in the array, 'i' will now point it
if(i < n) {
albumArr = albumArr.slice( 0, i).concat(album Arr.slice(i + 1));
}
}

which might be a little quicker (due to being performed by the browser),
but probably isn't (due to the resulting array allocations).
I hope I've explained myself better this time. Thanks for the above particularly because I haven't written the funtion to delete an album yet.
I'm sure this will do the job.
Jimbo I haven't tested these, by the way.

Good luck,
Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[Michael Winter]

On Tue, 31 Aug 2004 09:02:32 +0200, J. J. Cale <ph****@netvisi on.net.il>
wrote:

"Michael Winter" <M.******@bluey onder.co.invali d> wrote in message
news:opsdjinqrx x13kvk@atlantis ...

On Mon, 30 Aug 2004 11:47:41 +0200, J. J. Cale
<ph****@netvisi on.net.il> wrote:
[snip]

event.srcElemen t
Is this for the Web, or just an IE-only environment?

Ideally it would be generic although currently I'm writing an HTA.

The reason I asked is that event.srcElemen t is IE-only. You'll also have
to check event.target, and possibly other properties, for the code to work
with other browsers. However, since you're writing a HTA, it isn't of much
concern at the moment.

[snip]
the array albumArr contains an array of Album objects. I need to
delete the path for one image.
Sorry.
the reference obj (here 'o') has the album name and the index in the
paths array pinned as attributes
I'm searching therefore for o.alb (the album name) and o.picNum the
offset into the paths array of the Album object.
while(i<n && albumArr[i].name != o.alb) {++i} should work
to find the album
Yes, it would.

[snip]
This would delete the entire album. I need to delete the image from the
paths array of the album. The slice method with a regex is what I'm
looking for but I'm just getting into regex.

I don't think that a regular expression would be terribly useful. Of
course, I'm not seeing the whole picture, so I could be wrong.

[snip]

function Album(albumName ) {
this.name = albumName;
this.paths = [];
}
Album.prototype .removePath = function(i) {
for(var n = this.paths - 1; i < n; ++i) {
this.paths[i] = this.paths[i + 1];
}
this.paths.leng th = n;
};

function removeArrSrc(o) {
for(var i = 0, n = albumArr.length ; i < n; ++i) {
if(albumArr[i].name == o.alb) {
albumArr[i].removePath(o.p icNum);
break;
}
}
}

I forsee a possible problem here. Say that you delete the first path
(picNum 0). In the paths array, all of the elements will shift making the
second path first, third path second, etc. If you then delete the second
path (picNum 1), you'll actually be deleting the third path from the
original list. Do you account for that?

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[Thomas 'PointedEars' Lahn]

J. J. Cale wrote:

I have the following. There must be something less cumbersome without push
pop. The function parameter obj is the event.srcElemen t
which is IE only, use

function foo(e)
{
if (!e)
e = event;

if (e)
{
var t = e.target ? e.target : e.srcElement;
if (t)
{
// do something with t
}
}
}

<... on...="foo(even t);" ...>...</...>

instead.
and has the attributes(prop erties?) picNum and alb pinned to it. The
function is part of a process to delete the selected obj, a photo in
this case from the album vis albumArr. TIA
Jimbo
function Album(albumName ) {
this.name=album Name;
this.paths=new Array();
}
var albumArr(); // holds an array of Albums();
Invalid syntax. () is the call operator and can only be applied to
functions/methods.

var albumArr;

Watch the JavaScript Console or the status bar of the browser window!
function removeArrSrc(ob j) {
var dummy=new Array();
for(i=0;i<album Arr.length;i++) {
Note that `i' is declared global here, causing mostly undesired
side effects. Use the `var' keyword (and optimize a bit):

for (var i = 0, len = albumArr.length ; i < len; i++)
{
// ...
}

Since order does not seem to matter here, this can be
further optimized:

for (var i = albumArr.length ; i--; 0)
{
// ...
}

This loops from the last element to the first.
dummy[i]=new Album(albumArr[i].name);
[...]

To remove an array element, use the "delete" operator:

delete albumAr[42];

The array size will not be reduced, but further references
to albumAr[42] will return `undefined' instead of an Album
object reference which you can detect in your loop:

for (var i = albumAr.length; i--; 0)
{
if (albumAr[i])
{
delete albumAr[i];
}
}

More sophisticated but requires JavaScript 1.1 and compatibles:

for (var i = albumAr.length; i--; 0)
{
if (typeof albumAr[i] != "undefined" )
{
delete albumAr[i];
}
}

or

for (var i = albumAr.length; i--; 0)
{
if (albumAr[i] && albumAr[i].constructor == Album)
{
delete albumAr[i];
}
}

Even more sophisticated but requires an ECMAScript 3 or later
implementation (e.g. JavaScript 1.5, JScript 5.6):

for (var i = albumAr.length; i--; 0)
{
if (albumAr[i] instanceof Album)
{
delete albumAr[i];
}
}

You may want to add further conditions which must be matched
before the element will be deleted: your search parameters.
HTH

PointedEars

P.S.
Falsifying header information is not appropriate behavior (violating
several Usenet/Internet standards, the Netiquette and most certainly
the Acceptable Use Policy of service providers). It only *supports*
spammers' doing: <http://www.interhack.n et/pubs/munging-harmful/>
--
If they outlaw encryption, only outlaws will
62Xq3mrg45x69A9 6yvxi70gXrSdD+S Cw

[Lasse Reichstein Nielsen]

Thomas 'PointedEars' Lahn <Po*********@we b.de> writes:

A few nitpicks:

function foo(e)
{
if (!e)
e = event;
these two lines are not necessary if you do:
<... on...="foo(even t);" ...>...</...>
The event will be the argument to the function in all browsers (since
you pass it explicitly, and they all agree that "event" refers to the
event in an intrinsic event handler). It is needed (in IE) only when
you assign the function directly, as in:
something.onwha tever = foo;
Even more sophisticated but requires an ECMAScript 3 or later
implementation (e.g. JavaScript 1.5, JScript 5.6):

for (var i = albumAr.length; i--; 0)

This would start "i" out at albumAr.length, which is one past
the last element of the array. It should probably be
...(var i = albumAr.length - 1; ...

The "0" can also be omitted (all three expressions in a "for"
construct are optional).
--
Lasse Reichstein Nielsen - lr*@hotpop.com
DHTML Death Colors: <URL:http://www.infimum.dk/HTML/rasterTriangleD OM.html>
'Faith without judgement merely degrades the spirit divine.'

[Thomas 'PointedEars' Lahn]

Lasse Reichstein Nielsen wrote:

Thomas 'PointedEars' Lahn <Po*********@we b.de> writes:

function foo(e)
{
if (!e)
e = event;
these two lines are not necessary if you do:

<... on...="foo(even t);" ...>...</...>

[...] It is needed (in IE) only when
you assign the function directly, as in:
something.onwha tever = foo;

Correct, I confused both.

Even more sophisticated but requires an ECMAScript 3 or later
implementation (e.g. JavaScript 1.5, JScript 5.6):

for (var i = albumAr.length; i--; 0)

This would start "i" out at albumAr.length, which is one past
the last element of the array. It should probably be
...(var i = albumAr.length - 1; ...

No, it should not. The value of i is decreased the first time
the loop is executed.
The "0" can also be omitted (all three expressions in a "for"
construct are optional).

It cannot be omitted, the expressions are not optional in all
implementations .
PointedEars
--
Talk to the hand, the hand doesn't listen...

[Richard Cornford]

Lasse Reichstein Nielsen wrote:

Thomas 'PointedEars' Lahn writes:

for (var i = albumAr.length; i--; 0)

This would start "i" out at albumAr.length, which is one past
the last element of the array. It should probably be
...(var i = albumAr.length - 1; ...

<snip>

No, the first two expressions are fine. The - i-- - post decrements the
counter before its first use (assuming length was not zero, else there
would be no array access) leaving it the equivalent of length-1 when it
is first used.

Rihcard.

[Lasse Reichstein Nielsen]

Thomas 'PointedEars' Lahn <Po*********@we b.de> writes:

No, it should not. The value of i is decreased the first time
the loop is executed.
Ach, yes. The decrement is in the test, which is (apparently)
confuzing enough that I won't recommend it (for anything I have
to read :)
It cannot be omitted, the expressions are not optional in all
implementations .

Can you name one where it isn't?

All three expressions are optional in Javascript 1.0 (tested in
Netscape 2.02) and in ECMAScript v1.

/L
--
Lasse Reichstein Nielsen - lr*@hotpop.com
DHTML Death Colors: <URL:http://www.infimum.dk/HTML/rasterTriangleD OM.html>
'Faith without judgement merely degrades the spirit divine.'

[Randy Webb]

Thomas 'PointedEars' Lahn wrote:

Lasse Reichstein Nielsen wrote:
<--snip-->

The "0" can also be omitted (all three expressions in a "for"
construct are optional).

It cannot be omitted, the expressions are not optional in all
implementations .

Can you quote one that does not allow them to be optional?
--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq