Fraction Calculator Problem

[Stolas]

Hello all,
I'm attempting to create a Fraction Calculator. But for some reasons on my RationalTest program it is giving me an error that getAdd in Rational cannot be applied to (Rational). I'm very confused by this and its probably something simple wrong, but can someone steer me in the right direction? The program is meant to take two fractions in and do the different get methods for arithmitic. the "gcd" is for reducing the fraction, and within the get methods i have it set to find a common denomenator and then reduce after the arithmitic is done. Thanks for the help!

import javax.swing.JOptionPane;
 
public class Rational
{
    private int num;
    private int den;
 
    public Rational(int n, int d)
    {
        num = n/gcd(n,d);
        den = d/gcd(n,d);
    }
    private int gcd(int M, int N)
    {
        int rem;
        while (N!=0) {
            rem = M%N;
            M = N;
            N = rem;
        }
        return M;
    }
    public void getFraction()
    {
        JOptionPane.showMessageDialog(null, num + "/" + den);
    }
 
    public void getFloat()
    {
        JOptionPane.showMessageDialog(null, num/den);
    }
    public int getNum()
    {
        return num;
    }
 
    public int getDen()
    {
        return den;
    }
 
 
    public int getAdd(Rational fract2, int num, int den, int n, int d)
    {
        int num1 = num;
        int den1 = den;
 
        num1 = ((num*fract2.getDen()) + (den*fract2.getNum())); 
        den1 = den*fract2.getDen();
 
        num = num1; 
        den = den1;
 
        num = n/gcd(n,d);
        den = d/gcd(n,d);
 
        return num/den;
 
    }
    public int getSubtract(Rational fract2, int num, int den, int n, int d)
    {
        int num1 = num;
        int den1 = den;
 
 
        num1 = ((num*fract2.getDen()) - (den*fract2.getNum()));
        den1 = den*fract2.getDen();
 
 
        num = num1;
        den = den1;
 
        num = n/gcd(n,d);
        den = d/gcd(n,d);
 
        return num/den;
    }
    public int getMultiply(Rational fract2, int num, int den, int n, int d)
    {
        int num1 = num;
        int den1 = den;
 
 
        num1 = ((num*fract2.getDen()) * (den*fract2.getNum()));
        den1 = den*fract2.getDen();
 
        num = num1;
        den = den1;
 
        num = n/gcd(n,d);
        den = d/gcd(n,d);
 
        return num/den;
    }
    public int getDivide(Rational fract2, int num, int den, int n, int d)
    {
        int num1 = num;
        int den1 = den;
 
 
        num1 = ((num*fract2.getDen()) / (den*fract2.getNum()));
        den1 = den*fract2.getDen();
 
        num = num1;
        den = den1;
 
        num = n/gcd(n,d);
        den = d/gcd(n,d);
 
        return num/den;
    }
}
 

import javax.swing.JOptionPane;
 
public class RationalTest
{
    public static void main(String args[])
    {
        int num;
        int den;
 
 
        Rational fract1 = new Rational(num, den);
 
        num = Integer.parseInt(JOptionPane.showInputDialog("Enter first numerator"));
        den = Integer.parseInt(JOptionPane.showInputDialog("Enter first denominator"));
 
        Rational fract2 = new Rational(num, den);
 
        num = Integer.parseInt(JOptionPane.showInputDialog("Enter second numerator"));
        den = Integer.parseInt(JOptionPane.showInputDialog("Enter second denominator"));
 
 
        fract1.getAdd(fract2);
 
        System.out.printf("The addition results are: %s\n", fract1.getFraction()); 
        System.out.printf("And the decimal results for addition are: %s\n", fract1.getFloat());
    }
}
 

[Ganon11]

Exactly what error are you getting? Copy and paste will do fine.

[r035198x]

You passed one parameter to the getAdd method in your main method but when you defined it in the Rational class you specified that it takes five parameters.

[JosAH]

I don't understand why the getAdd, getSubtract etc. methods return ints. I would've
expected something like this:

public Rational add(Rational that) {
   return add(that.num, that.den);
}
 
public Rational add(int num, int den) {
   return new Rational(this.num*den+this.den*num, this.den*den);
}
 
// the same for the other operators
 

For convenience you should implement the toString() method as well:

public String toString() {
   return num+"/"+den;
}
 

kind regards,

Jos