Trying to get more precise number (Poker Hands Generator)

[kinghippo423]

Hello Everyone,

I did a poker program in Java that essencially finds the strenght of a poker hand created Randomly. My program is doing OK...but I'm pretty sure it can be optimised.

This is my results with 1 million hands:



Number of hands generated : 1000000
Straight Flush : 0.0012 % In theory : 0.0012%
Four Of A Kind : 0.017 % In theory : 0.0240%
Full House : 0.1535 % In theory : 0.1441%
Flush : 0.2285 % In theory : 0.1967%
Straight : 0.3104 % In theory : 0.3532%
Three Of A Kind : 2.2372 % In theory : 2.1128%
Deux Pairs : 4.6104 % In theory : 4.759%
Pair : 41.777 % In theory : 42.2569%
Nothing : 50.6648 % In theory : 50.157%

There is big differences between my results and the theory. I thought at first that it was because I didn't used enough hands.

This is my results with 50 million hands:



Number of hands generated : 50000000
Straight Flush : 0.0012 % In theory : 0.0012%
Four Of A Kind : 0.0183 % In theory : 0.0240%
Full House : 0.1489 % In theory : 0.1441%
Flush : 0.2286 % In theory : 0.1967%
Straight : 0.3086 % In theory : 0.3532%
Three Of A Kind : 2.2266 % In theory : 2.1128%
Deux Pairs : 4.6107 % In theory : 4.759%
Pair : 41.7652 % In theory : 42.2569%
Nothing : 50.6918 % In theory : 50.1570%

And again, the numbers are pretty much the same so it means that thereare flaws in my logic. The problem is I can't find those flaws. My question will be about my isFourOfAKind() method because I get approximalety 20% less Four Of A Kind hands then the theory. A pretty good difference in my opinion.

In general, my program is built like this

Card --> suit, strenght.
Hand --> Card1, Card2, Card3, Card4, Card5.

This is a representation of my method (Card1 = the strenght of Card1. In reality Card1 would be replace by Card1.getCardSt renght())

if(Card1 == Card2 && Card1 == Card3 && Card1 == Card4 && Card1 != Card5)
return true
else if(Card1 == Card2 && Card1 == Card3 && Card1 != Card4 && Card1 == Card5)
return true
if(Card1 == Card2 && Card1 != Card3 && Card1 == Card4 && Card1 == Card5)
return true
if(Card1 != Card2 && Card1 == Card3 && Card1 == Card4 && Card1 == Card5)
return true
else
return false

I'm pretty sure this logic is good. The problem is my results tells me that my logic is NOT good. Where is the flaw in that method?

Thanks in advance and pardon me for English mistakes...it isn't my first language

kinghippo423

P.S. I saw lots of poker hands generator like mice that works WAY faster than mine. Is there any website that explain some technics to have a "faster" program? It sucks to wait 1 minute ot generate 1 million hands...I hope I explain that well.

[kinghippo423]

And here comes the fun: use regular expressions for finding the score:
Four of a kind is found as follows:

boolean fook= r.matches("0*40*");
 

A full house is found like this:

boolean fh= r.matches("0*20*30*") || r.matches("0*30*20*");
 

Checking whether or not all cards have the same suit is easy too:

boolean ss= s.matches("0*40*");
 

I hope you get the picture.

kind regards,

Jos

I was unterstanding up to this point perfectly. I just want to make use I get it before asking for more explanation.

Let's say my hand is:

Hand (suit - strenght):
Card1 : 2 - 4.
Card1 : 2 - 6.
Card1 : 2 - 8.
Card1 : 2 - 9.
Card1 :2 - 11.

For checking if my hand is a flush, my method should look ike this:

// ss = result of the checking.
// s = the concatenation of the hand information.
isFlush(Card card)
{
boolean result;
if(boolean ss= s.matches("0*0* 0*0*0*");
result = true;
else if(boolean ss= s.matches("1*1* 1*1*1*");
result = true;
else if(boolean ss= s.matches("2*2* 2*2*2*");
result = true;
else if(boolean ss= s.matches("3*3* 3*3*3*");
result = true;
else
result = false;

return result;
}

I'm getting it?

If yes, why it's a better way to built the program?
If not, I'll need more specification on the use here of the regular expressions. I'M almost there though it's just still a little fuzzy...

[JosAH]

I was unterstanding up to this point perfectly. I just want to make use I get it before asking for more explanation.

Let's say my hand is:

Hand (suit - strenght):
Card1 : 2 - 4.
Card1 : 2 - 6.
Card1 : 2 - 8.
Card1 : 2 - 9.
Card1 :2 - 11.

For checking if my hand is a flush, my method should look ike this:

// ss = result of the checking.
// s = the concatenation of the hand information.
isFlush(Card card)
{
boolean result;
if(boolean ss= s.matches("0*0* 0*0*0*");
result = true;
else if(boolean ss= s.matches("1*1* 1*1*1*");
result = true;
else if(boolean ss= s.matches("2*2* 2*2*2*");
result = true;
else if(boolean ss= s.matches("3*3* 3*3*3*");
result = true;
else
result = false;

return result;
}

I'm getting it?

If yes, why it's a better way to built the program?
If not, I'll need more specification on the use here of the regular expressions. I'M almost there though it's just still a little fuzzy...

You must read up on regular expressions. A flush means the cards all have the
same suit, so the suits string matches this: "0*50*" which translates to human
language as zero or more '0's followed by a '5' followed by zero or more '0's.

This regular expresssion matches "5000", "0500", "0050" or "0005". That's the
fun of those regular expressions: let them do the hard work so your code can
be extremely simple.

kind regards,

Jos

[Nepomuk]

You must read up on regular expressions. A flush means the cards all have the
same suit, so the suits string matches this: "0*50*" which translates to human
language as zero or more '0's followed by a '5' followed by zero or more '0's.

This regular expresssion matches "5000", "0500", "0050" or "0005". That's the
fun of those regular expressions: let them do the hard work so your code can
be extremely simple.

kind regards,

Jos

Actually, "0*" could mean one zeros, multiple zeros or no zeros. Therefore the Expression "0*50*" would match "5000" or "0005". What you said was, that "0*" meant zero or more multiple zeros, leaving out the possibility of the empty word.

Greetings,
Nepomuk

[JosAH]

Actually, "0*" could mean one zeros, multiple zeros or no zeros. Therefore the Expression "0*50*" would match "5000" or "0005". What you said was, that "0*" meant zero or more multiple zeros, leaving out the possibility of the empty word.

Greetings,
Nepomuk

Nope, "0*" just means zero or more '0's. So the expression matches all the
combinations 5000, 0500, 0050, 0005; give it a try.

kind regards,

Jos