command pattern variable number of parameters in execute method

[oll3i]

i want to write a bank account programme and use a command pattern where execute method has variable number of parameters.


[code]
public interface Command {
public abstract void execute (String ... s);
}
[code]
how do i get the parameters passed to that method?
when is the execute method called?

[JosAH]

i want to write a bank account programme and use a command pattern where execute method has variable number of parameters.

public interface Command {
     public abstract void execute (String ...  s);
}
 

how do i get the parameters passed to that method?
when is the execute method called?

You're in trouble here: other objects are not supposed to know anything at all
about an actual implementation of the Command interface so they don't know
how many Strings to pass to that particular implementation. All that the other
objects know is that they can pass zero or more Strings to your Command,
that's all. I think you have to go back to the drawing board for a bit more time.

kind regards,

Jos

[oll3i]

so i'm not on a good path?
what's wrong with my Command?

[JosAH]

so i'm not on a good path?
what's wrong with my Command?

That's what I wrote in my previous reply, but maybe things are not so bad.
What do these Strings mean? Can every Command take a variable number
of Strings or are the number of Strings depending on *which* Command is
to be executed?

kind regards,

Jos

[oll3i]

the number of Strings is depending on which Command is
to be executed i think ?

 
public class WplacnaKonto implements Command { 
// class for putting the money into account
private Konto konto = new Konto();  // Account account = new Account();
 
public WplacnaKonto(Konto k){
    konto=k;    
}
 
 
public void execute(String ... rozkaz){
    double suma = Double.valueOf(rozkaz[0].trim()).doubleValue();
     konto.wplata(suma); //account put the money  into account
}
 
}
 

this is a class responsible for putting the money into the account
i was following the example from this tutorial
http://www.javaworld.com/javaworld/j...68.html?page=1

kind regards

[JosAH]

the number of Strings is depending on which Command is
to be executed i think ?

Then there's trouble ahead; suppose you have three different commands: A, B
and C all implementing your Command interface. Command A needs 2 Strings,
Command B needs 1 String and Command C needs 4 Strings. Your other
objects are not supposed to know which Command they're dealing with. How
should they know how many Strings to pass to a Command?

kind regards,

Jos

[oll3i]

uups ... every Command can take a variable number
of Strings

public void execute(String ... rozkaz){
double suma = Double.valueOf( rozkaz[0].trim()).double Value();
konto.wplata(su ma);
}



putintoaccount. execute("100.00 ");
displayhistoryo faccounts.execu te("38102098765 43456","3810204 455667876");

and i dont know if am doing it right ?

[JosAH]

uups ... every Command can take a variable number
of Strings

public void execute(String ... rozkaz){
double suma = Double.valueOf( rozkaz[0].trim()).double Value();
konto.wplata(su ma);
}



putintoaccount. execute("100.00 ");
displayhistoryo faccounts.execu te("38102098765 43456","3810204 455667876");

and i dont know if am doing it right ?

Not really because your scenario allows me to do this:

putintoaccount.execute("foo", "bar", "baz");
displayhistoryofaccounts.execute("100.00", "-42", "Fido the Poodle");

In other words: I don't know to which Command I'm talking and I don't know
what to put as parameter values. All I know is that I'm talking to a Command
that takes zero or more Strings as its parameter list.

kind regards,

Jos

[oll3i]

so what would you suggest me to do?

[oll3i]

should i change my command execute method?