472,988 Members | 2,373 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 472,988 software developers and data experts.

sort input

Earlier, I have posted a program like this, a month ago IIRC. I have
created it again, without looking at the old program. Can I have your
opinions on this:

1) I wanted my program to be efficient, so I used reference to vector.
2) anything else you think worth mentioning

/* A program that asks the user for input and when user hits EOF will sort the words
* alphabetically and prints them.
*
*/
#include <iostream>
#include <vector>
#include <string>

void get_input( std::vector<std::string>& );
void print_input( std::vector<std::string>& );

int main()
{
std::vector<std::stringvec_of_strings;

get_input(vec_of_strings);
sort( vec_of_strings.begin(), vec_of_strings.end() );
print_input(vec_of_strings);

return 0;
}
void get_input( std::vector<std::string>& svec )
{
std::string aword;

while( std::cin >aword )
{
svec.push_back(aword);
}
}

void print_input( std::vector<std::string>& svec )
{
for( std::vector<std::string>::const_iter iter = svec.begin();
iter != svec.end(); ++iter )
{
std::cout << *iter << "\n";
}
}

==================== OUTPUT ========================
[arnuld@dune cpp]$ g++ -ansi -pedantic -Wall -Wextra sort-input.cpp
[arnuld@dune cpp]$ ./a.out
comp
lang
c++
is where cpp people live
--------------------------------
c++
comp
cpp
is
lang
live
people
where
[arnuld@dune cpp]$

--
www.lispmachine.wordpress.com
my email is @ the above blog.
Google Groups is UnBlocked now :)
Nov 4 '08 #1
9 2739
#include <iostream>
#include <vector>
#include <string>
you will need

#include <algorithm>

void get_input( std::vector<std::string>& svec )
{
* std::string aword;

* while( std::cin >aword )
* * {
* * * svec.push_back(aword);
* * }

}
You could write the more STL-ish

void get_input( std::vector<std::string>& svec )
{
copy(istream_iterator<string>(cin), istream_iterator<string>(),
back_inserter< vector<string(svec));
}
>
void print_input( std::vector<std::string>& svec )
{
* for( std::vector<std::string>::const_iter iter = svec.begin();
* * * *iter != svec.end(); ++iter )
* * {
* * * std::cout << *iter << "\n";
* * }

}
and

void print_input( std::vector<std::string>& svec )
{
copy(svec.begin(), svec.end(), ostream_iterator<string>(cout, "\n"));
}

Regards,
Csaba
Nov 4 '08 #2
On Tue, 04 Nov 2008 05:29:40 -0800, ctrucza wrote:
You could write the more STL-ish

void get_input( std::vector<std::string>& svec )
{
copy(istream_iterator<string>(cin), istream_iterator<string>(),
back_inserter< vector<string(svec));
}
...SNIP....

I get compile time errors:
#include <iostream>
#include <vector>
#include <string>
#include <algorithm>
void get_input( std::vector<std::string>& );
void print_input( std::vector<std::string>& );

int main()
{
std::vector<std::stringvec_of_strings;

get_input(vec_of_strings);
sort( vec_of_strings.begin(), vec_of_strings.end() );
print_input(vec_of_strings);

return 0;
}
void get_input( std::vector<std::string>& svec )
{
copy( istream_iterator<std::string>(std::cin), istream_iterator<std::string>(),
back_inserter<std::vector<std::string(svec) );

// Notice the last element, it is "(svec)" and not ">>(svec)"
// Just Remember the space.
}
void print_input( std::vector<std::string>& svec )
{
std::cout << "---------------------------------------------\n";
copy( svec.begin(), svec.end(), ostream_iterator<std::string>(std::cout, "\n") );
}
===================== OUTPUT =============================
[arnuld@dune cpp]$ g++ -ansi -pedantic -Wall -Wextra CLCPP_sort-input.cpp
CLCPP_sort-input.cpp: In function `void get_input(std::vector<std::string, std::allocator<std::string&)':
CLCPP_sort-input.cpp:30: error: `istream_iterator' was not declared in this scope
CLCPP_sort-input.cpp:30: error: expected primary-expression before '>' token
CLCPP_sort-input.cpp:30: error: expected primary-expression before '>' token
CLCPP_sort-input.cpp:30: error: expected primary-expression before ')' token
CLCPP_sort-input.cpp:31: error: `back_inserter' was not declared in this scope
CLCPP_sort-input.cpp:31: error: expected primary-expression before '>' token
CLCPP_sort-input.cpp:31: error: `copy' was not declared in this scope
CLCPP_sort-input.cpp:31: warning: unused variable 'back_inserter'
CLCPP_sort-input.cpp:31: warning: unused variable 'copy'
CLCPP_sort-input.cpp: In function `void print_input(std::vector<std::string, std::allocator<std::string&)':
CLCPP_sort-input.cpp:41: error: `ostream_iterator' was not declared in this scope
CLCPP_sort-input.cpp:41: error: expected primary-expression before '>' token
CLCPP_sort-input.cpp:41: warning: left-hand operand of comma has no effect
CLCPP_sort-input.cpp:41: warning: unused variable 'ostream_iterator'
[arnuld@dune cpp]$

[arnuld@dune cpp]$ gcc --version
gcc (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[arnuld@dune cpp]$


--
www.lispmachine.wordpress.com
my email is @ the above blog.
Google Groups is UnBlocked now :)
Nov 5 '08 #3
On Wed, 05 Nov 2008 09:17:26 +0500, arnuld wrote:
I get compile time errors:
Okay I got this. It was in <iteratorheader.

#include <iostream>
#include <vector>
#include <string>
#include <algorithm>
#include <iterator>

void get_input( std::vector<std::string>& );
void print_input( std::vector<std::string>& );

int main()
{
std::vector<std::stringvec_of_strings;

get_input(vec_of_strings);
sort( vec_of_strings.begin(), vec_of_strings.end() );
print_input(vec_of_strings);

return 0;
}
void get_input( std::vector<std::string>& svec )
{
std::copy( std::istream_iterator<std::string>(std::cin), std::istream_iterator<std::string>(),
std::back_inserter<std::vector<std::string(svec) );

// Notice the last element, it is "(svec)" and not ">>(svec)"
// Just Remember the space.
}
void print_input( std::vector<std::string>& svec )
{
std::cout << "---------------------------------------------\n";
copy( svec.begin(), svec.end(), std::ostream_iterator<std::string>(std::cout, "\n") );
}

one thing still eludes me: "Why does using copy or std::copy makes no
difference ?"
--
www.lispmachine.wordpress.com
my email is @ the above blog.
Google Groups is UnBlocked now :)
Nov 5 '08 #4
arnuld wrote:
[...]
void print_input( std::vector<std::string>& svec )
{
std::cout << "---------------------------------------------\n";
copy( svec.begin(), svec.end(), std::ostream_iterator<std::string>(std::cout, "\n") );
}

one thing still eludes me: "Why does using copy or std::copy makes no
difference ?"
Because of ADL:
http://en.wikipedia.org/wiki/Argumen...nt_name_lookup

--
Thomas
Nov 5 '08 #5
On Wed, 05 Nov 2008 05:32:54 +0100, Thomas J. Gritzan wrote:
>arnuld wrote:
one thing still eludes me: "Why does using copy or std::copy makes no
difference ?"
Because of ADL:
http://en.wikipedia.org/wiki/Argumen...nt_name_lookup

It means I am giving the compiler a burden to search for namespace. Hence
using std::copy will be a good idea.

--
www.lispmachine.wordpress.com
my email is @ the above blog.
Google Groups is UnBlocked now :)
Nov 5 '08 #6
In article <pa****************************@invalid.address> ,
su*****@invalid.address says...

[ ... ]
It means I am giving the compiler a burden to search for namespace. Hence
using std::copy will be a good idea.
Not really -- lots of things would break in a hurry if ADL didn't work.

--
Later,
Jerry.

The universe is a figment of its own imagination.
Nov 5 '08 #7
Jerry Coffin wrote:
In article <pa****************************@invalid.address> ,
su*****@invalid.address says...

[ ... ]
>It means I am giving the compiler a burden to search for namespace. Hence
using std::copy will be a good idea.

Not really -- lots of things would break in a hurry if ADL didn't work.
He didn't propose to break ADL, he just said that explicitly
specifying the namespace is a good idea. That's a POV which
I support. for one ADL can do surprising things. Also, as was
just demonstrated, the code is easier to read if the namespace
is spelled out explicitly.

Schob
Nov 6 '08 #8
In article <ge**********@hoshi.visyn.net>, sp******@gmx.de says...
Jerry Coffin wrote:
In article <pa****************************@invalid.address> ,
su*****@invalid.address says...

[ ... ]
It means I am giving the compiler a burden to search for namespace. Hence
using std::copy will be a good idea.
Not really -- lots of things would break in a hurry if ADL didn't work.

He didn't propose to break ADL, he just said that explicitly
specifying the namespace is a good idea. That's a POV which
I support. for one ADL can do surprising things. Also, as was
just demonstrated, the code is easier to read if the namespace
is spelled out explicitly.
My point apparently wasn't clear. I have no argument with his conclusion
at all -- only with the implication that this was a good idea _because_
("Hence") it was placing a burden on the compiler. In reality, the
compiler has to be able to handle it for things to work anyway, so
putting it to use in this situation doesn't cause it any real extra
work.

My own experience is that as often as not, rewriting code on the
assumption that one way of writing it will be easier to compile than
another is a mistake. IMO, code should be written bo be as readable as
possible for other people, and only rewritten to cover for a compiler
bug when truly necessary.

--
Later,
Jerry.

The universe is a figment of its own imagination.
Nov 7 '08 #9
Jerry Coffin wrote:
[ ... ]
My own experience is that as often as not, rewriting code on the
assumption that one way of writing it will be easier to compile than
another is a mistake. IMO, code should be written bo be as readable as
possible for other people, and only rewritten to cover for a compiler
bug when truly necessary.
Amen. :)

Schobi
Nov 7 '08 #10

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

18
by: googleboy | last post by:
I didn't think this would be as difficult as it now seems to me. I am reading in a csv file that documents a bunch of different info on about 200 books, such as title, author, publisher, isbn,...
1
by: Derek Tinney | last post by:
Hi, I'm having difficulty building an XLST file that allows me to sort a list of log records. I put together an XSL file that allows me to output a copy of the input file and then I attempted...
3
by: Kevin King | last post by:
I have a question about an assignment I have. I need to count the number of comparisons in my merge sort. I know that the function is roughly nlog(n), but I am definately coming up with too many...
12
by: Eva | last post by:
Hi, I try to implement quick sort. I sort vectors by their first value. 10 2 3 4 9 3 5 6 10 4 5 6 must be 9 3 5 6 10 2 3 4 10 4 5 6 The prog works great on maybe 500 vectors, but I have an...
3
by: rwise5 | last post by:
I have been tasked with finishing the following C program. I need to develop the sort by birthday function and the print grade function. I have been working on the print function for the last week...
2
by: joesindel | last post by:
So heres the deal... I work for a company in which numbers are dropping. The owners created a game where calling potential clients racks up points for crap like basketball ticekts and such. The...
2
by: gonzo | last post by:
So I have a project where I'm supposed to have a .txt input file of no more than ten first names, last names and birth years, and than in a menu I'm to give the user some options as to how the...
0
by: kgiraldin | last post by:
Hello, I have some code commented out in order to make this work. However, I would prefer to use the commented code so my users can SORT on the column heading because I know they are going to want...
5
by: Nirmala123 | last post by:
hi... I want to sort the table using combobox values. I give the code here. address.html: <html> <head> <title>Add a new entry</title> </head>
3
by: aRTx | last post by:
I have try a couple of time but does not work for me My files everytime are sortet by NAME. I want to Sort my files by Date-desc. Can anyone help me to do it? The Script <? /* ORIGJINALI
0
by: lllomh | last post by:
Define the method first this.state = { buttonBackgroundColor: 'green', isBlinking: false, // A new status is added to identify whether the button is blinking or not } autoStart=()=>{
2
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 4 Oct 2023 starting at 18:00 UK time (6PM UTC+1) and finishing at about 19:15 (7.15PM) The start time is equivalent to 19:00 (7PM) in Central...
0
by: Aliciasmith | last post by:
In an age dominated by smartphones, having a mobile app for your business is no longer an option; it's a necessity. Whether you're a startup or an established enterprise, finding the right mobile app...
2
by: giovanniandrean | last post by:
The energy model is structured as follows and uses excel sheets to give input data: 1-Utility.py contains all the functions needed to calculate the variables and other minor things (mentions...
4
NeoPa
by: NeoPa | last post by:
Hello everyone. I find myself stuck trying to find the VBA way to get Access to create a PDF of the currently-selected (and open) object (Form or Report). I know it can be done by selecting :...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 1 Nov 2023 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM) Please note that the UK and Europe revert to winter time on...
0
isladogs
by: isladogs | last post by:
The next online meeting of the Access Europe User Group will be on Wednesday 6 Dec 2023 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, Mike...
4
by: GKJR | last post by:
Does anyone have a recommendation to build a standalone application to replace an Access database? I have my bookkeeping software I developed in Access that I would like to make available to other...
3
SueHopson
by: SueHopson | last post by:
Hi All, I'm trying to create a single code (run off a button that calls the Private Sub) for our parts list report that will allow the user to filter by either/both PartVendor and PartType. On...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.