what 's wrong with this code?

[Siju]

The following code
=================================
$ cat
string.c
#include <string.h>

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') )
return cp+1;
return pathname;
}
$
=================================

gives the following error.

=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

Could some one help me find the error?
I am new to C lang

Thanks

--Siju

gives

[Joe Wright]

Siju wrote:

The following code
=================================
$ cat
string.c
#include <string.h>

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') )
return cp+1;
return pathname;
}
$
=================================

gives the following error.

=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

Could some one help me find the error?
I am new to C lang

Thanks

You missed a right paren. Should be..
if ( (cp = strrchr(pathname,'/')) )
^-here
--
Joe Wright
"Everything should be made as simple as possible, but not simpler."
--- Albert Einstein ---

[Andrew Poelstra]

On 2008-08-31, Siju <sg********@gmail.comwrote:

>
gives the following error.

=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.
Surely you could figure that one out without resorting to
asking on a newsgroup?

I have snipped the code.

--
Andrew Poelstra ap*******@wpsoftware.com
To email me, use the above email addresss with .com set to .net

[Barry Schwarz]

On Sun, 31 Aug 2008 16:28:49 GMT, Andrew Poelstra
<ap*******@supernova.homewrote:

>On 2008-08-31, Siju <sg********@gmail.comwrote:

>>
gives the following error.

=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.

There is no need for main to be present in this source file. It is
obviously needed to execute (on a hosted system) but not needed to
compile.

>Surely you could figure that one out without resorting to
asking on a newsgroup?

Not since there is no such requirement and even if there were it is
completely unrelated to the question at hand.

--
Remove del for email

[Barry Schwarz]

On Sun, 31 Aug 2008 09:15:25 -0700 (PDT), Siju <sg********@gmail.com>
wrote:

>The following code
=================================
$ cat
string.c
#include <string.h>

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') )
return cp+1;

Indenting the range of if (as well as for, while, and do-while) will
make your code a lot easier to read and save you a lot of time if you
have to come back to it months later.

return pathname;
}

--
Remove del for email

[Martin Ambuhl]

Siju wrote:

if ( (cp = strrchr(pathname,'/') )

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unbalanced parentheses

return cp+1;

[Old Wolf]

On Sep 1, 4:52*am, Barry Schwarz <[e-mail]:

On 2008-08-31, Siju <[e-mail]:

>=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.

There is no need for main to be present in this source file. *It is
obviously needed to execute (on a hosted system) but not needed to
compile.

The compilation command given by the OP requests
the generation of an executable from the single
source file, string.c . So main() is needed for
compilation to succeed.

[vippstar]

On Sep 1, 3:35 am, Old Wolf <[e-mail]:

On Sep 1, 4:52 am, Barry Schwarz <[e-mail]:

>On 2008-08-31, Siju <[e-mail]:

>>=================================
>$ cc string.c -o
>string
>string.c: In function `Basename':
>string.c:7: error: syntax error before "return"
>>================================

>You are missing a right parentheses and the entire main()
>function. Both are required for the program to compile.

There is no need for main to be present in this source file. It is
obviously needed to execute (on a hosted system) but not needed to
compile.

The compilation command given by the OP requests
the generation of an executable from the single
source file, string.c . So main() is needed for
compilation to succeed.

How do you know? cc string.c -o string could mean anything.

[Keith Thompson]

Old Wolf <ol*****@inspire.net.nzwrites:

On Sep 1, 4:52*am, Barry Schwarz <[e-mail]:

>On 2008-08-31, Siju <[e-mail]:
=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

>You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.

There is no need for main to be present in this source file. *It is
obviously needed to execute (on a hosted system) but not needed to
compile.

The compilation command given by the OP requests
the generation of an executable from the single
source file, string.c . So main() is needed for
compilation to succeed.

No, it's needed for *linking* to succeed. The command, assuming "cc"
works the way it does on most Unix-like systems, specifies both
compilation and linking.

--
Keith Thompson (The_Other_Keith) ks***@mib.org <http://www.ghoti.net/~kst>
Nokia
"We must do something. This is something. Therefore, we must do this."
-- Antony Jay and Jonathan Lynn, "Yes Minister"

[Siju]

On Aug 31, 9:52 pm, Barry Schwarz <[e-mail]:

On Sun, 31 Aug 2008 16:28:49 GMT, Andrew Poelstra

<[e-mail]:

On 2008-08-31, Siju <[e-mail]:

gives the following error.

>=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.

Thank you so much for the responses.

But when I added the parentheses

================================================== ======
$ cat string.c
#include <string.h>

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') ) )
return cp+1;
return pathname;
}
$
================================================== ======

I get this error

================================================== ======
$ cc string.c -o
string
/usr/lib/crt0.o(.text+0xa4): In function `___start':
: undefined reference to `main'
collect2: ld returned 1 exit status
================================================== =======

thanks

--Siju

[viza]

Hi

On Sun, 31 Aug 2008 09:15:25 -0700, Siju wrote:

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') )
return cp+1;
return pathname;
}

apart from the missing paren, your function mis-handles handle the
following values of pathname:

NULL should return "." your version probably crashes
"" should return "." your version returns ""
"foo/" should return "foo" your version returns ""
"/" should return "/" your version returns ""

The last two are very big bugs indeed!

There is an efficient public domain C implementation of this function and
several related ones at:

http://www.purposeful.co.uk/software...e/basename_r.h
http://www.purposeful.co.uk/software...e/basename_r.c

NB: these versions return (char*) cast to (const char*), to give you the
hint that it isn't always ok to write to the returned string. This is
the case with the standard basename(1) too, but the type doesn't indicate
it.

HTH
viza

[viza]

On Mon, 01 Sep 2008 11:25:59 +0000, viza wrote:

...This is the case with the standard basename(1) ...

basename(3)

[Old Wolf]

On Sep 1, 3:00*pm, Keith Thompson <[e-mail]:

Old Wolf <[e-mail]:

On Sep 1, 4:52*am, Barry Schwarz <[e-mail]:

On 2008-08-31, Siju <[e-mail]:
=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

You are missing a right parentheses and the entire main()
function. Both are required for the program to compile.

There is no need for main to be present in this source file. *It is
obviously needed to execute (on a hosted system) but not needed to
compile.

The compilation command given by the OP requests
the generation of an executable from the single
source file, string.c . So main() is needed for
compilation to succeed.

No, it's needed for *linking* to succeed. *The command, assuming "cc"
works the way it does on most Unix-like systems, specifies both
compilation and linking.

I was using 'compile' in the very common usage
of 'generate an executable'.

[rio]

"Siju" <sg********@gmail.comha scritto nel messaggio
news:7f**********************************@s1g2000p ra.googlegroups.com...

The following code
=================================
$ cat
string.c
#include <string.h>

char *
Basename(char *pathname) {
char *cp;
if ( (cp = strrchr(pathname,'/') )
return cp+1;
return pathname;
}

char* Basename(char *pathname) {
char *cp;
if(pathname)
if ( (cp=strrchr(pathname,'/'))
|| (cp=strrchr(pathname,'\\'))
) return cp+1;
return pathname;}

$
=================================

gives the following error.

=================================
$ cc string.c -o
string
string.c: In function `Basename':
string.c:7: error: syntax error before "return"
================================

Could some one help me find the error?
I am new to C lang

Thanks

--Siju

gives