For statement

[geebanga88]

Hi, im making a program that outputs change in terms of 50, 20, 10, 5 cent coins.

 
int integer_value, coin50, coin20, coin10, coin5, count50, count20, count10, count5; 
 
    printf ("Please enter your integer:\n"); 
    scanf ("%i*c", &integer_value);  
 
    if (( integer_value < 5) || ( integer_value > 95 ) || ( integer_value % 5 != 0))  
    {    
        printf ("Invalid number ");
        getchar (); 
        return 0; 
    }
 
    for (coin50 = 50, count50 = 0; integer_value > coin50; ++count50) 
        integer_value = integer_value - coin50;
 
    for (coin50 = 20, count20 = 0; integer_value > coin20; ++count20) 
        integer_value = integer_value - coin20;
 
    for (coin50 = 10, count10 = 0; integer_value > coin10; ++count10) 
        integer_value = integer_value - coin10;
 
    for (coin50 = 5, count5 = 0; integer_value > coin5; ++count5) 
        integer_value = integer_value - coin5;        
 
    printf ("Customer Change: %i 50cent Coins, %i 20cent Coins, %i 10cent Coins and %i 5cent Coins\n", count50, count20, count10, count5); 
 

However i think theres something wrong with the for statement loops. The program compiles with no errors but when i enter a valid integer the command terminal goes to a new line and if enter is pressed again nothing happens?
I gather the loop is not working correctly, i tired an invalid number e.g 54 and that will be covered by the if clause.

[doskey]

On line 6 i see no reason why you should have the ( integer_value % 5 != 0) whatsoever.

[geebanga88]

On line 6 i see no reason why you should have the ( integer_value % 5 != 0) whatsoever.

The reason for this is to only allow numbers divisible by 5 e.g. 5, 10 15 20 25, basically for currency purposes. As 1,2,3,4 cent coins arent used the lowest denominator is the 5 cent coin thus the number has to be a divisible by 5. E.g i dont 23 cents or 71 cents being entered.

[kreagan]

Hi, im making a program that outputs change in terms of 50, 20, 10, 5 cent coins.

However i think theres something wrong with the for statement loops. The program compiles with no errors but when i enter a valid integer the command terminal goes to a new line and if enter is pressed again nothing happens?
I gather the loop is not working correctly, i tired an invalid number e.g 54 and that will be covered by the if clause.

You need to set values to coin20, coin 10, and coin 5. They are uninitialized.

[chansoli]

every loop starts with (coin50,
other coin* are not initised

[geebanga88]

Ops yes bad mistake, i got the program to work expect i changed the loop experssion a bit so that the value can be equal to in order for the program statement to be executed.

 
 for (coin50 = 50, count50 = 0; integer_value => coin50; ++count50) 
        integer_value = integer_value - coin50;
 
    for (coin20 = 20, count20 = 0; integer_value => coin20; ++count20) 
        integer_value = integer_value - coin20;
 
    for (coin10 = 10, count10 = 0; integer_value => coin10; ++count10) 
        integer_value = integer_value - coin10;
 
    for (coin5 = 5, count5 = 0; integer_value => coin5; ++count5) 
        integer_value = integer_value - coin5; 
 
 

I get the error:
error: expected primary-expression before '>' token
for each of the for statment. Anyone know away around this error?

[kreagan]

Ops yes bad mistake, i got the program to work expect i changed the loop experssion a bit so that the value can be equal to in order for the program statement to be executed.

 
 
    for (coin10 = 10, count10 = 0; integer_value => coin10; ++count10) 
        integer_value = integer_value - coin10;
 
 

I get the error:
error: expected primary-expression before '>' token
for each of the for statment. Anyone know away around this error?

use '>=' instead of '=>'. It's "greater than or equal to", not "equal to or greater than"!

[geebanga88]

ahhhhhh i see thanks :)

[geebanga88]

Hi again, I have added dollars, to the program to make things more complex. I got the program to compile ok in Dev C++. Invalid dollars and cents will generate the appropriate response however my initial problem has occurred again however this time im pretty sure that it is not variable initialization.

 
int dollar, cents, coin50, coin20, coin10, coin5, ccount50, ccount20, ccount10, ccount5; 
    int dollar100, dollar50, dollar20, dollar10, dollar5, dollar2, dollar1, dcount100, dcount50, dcount20, dcount10, dcount5, dcount2, dcount1;   
    float amount;
 
    printf ("Please enter your amount:\n"); 
    scanf ("%f", &amount);  
 
    dollar = (int) amount;
    cents = (int) (((amount - dollar)*100) + 0.5);
 
    if ( dollar < 1 )
    {    
        printf ("Invalid dollar amount");
        getchar ();
        getchar (); 
        return 0; 
    }
    if ( cents % 5 != 0) 
    {    
        printf ("Invalid cents amount");
        getchar ();
        getchar (); 
        return 0; 
    }
 
    for (dollar100 = 100, dcount100 = 0; amount >=  dollar100; ++dcount100) 
        amount = amount - dollar100;
 
    for (dollar100 = 50, dcount50 = 0; amount >=  dollar50; ++dcount50) 
        amount = amount - dollar50;
 
    for (dollar20 = 20, dcount20 = 0; amount >=  dollar20; ++dcount20) 
        amount = amount - dollar20;    
 
    for (dollar10 = 10, dcount10 = 0; amount >=  dollar10; ++dcount10) 
        amount = amount - dollar10; 
 
    for (dollar5 = 5, dcount5 = 0; amount >=  dollar5; ++dcount5) 
        amount = amount - dollar5; 
 
    for (dollar2 = 2, dcount2 = 0; amount >=  dollar2; ++dcount2) 
        amount = amount - dollar2;
 
    for (dollar1 = 1, dcount1 = 0; amount >=  dollar1; ++dcount1) 
        amount = amount - dollar1;
 
    for (coin50 = 50, ccount50 = 0; amount >=  coin50; ++ccount50) 
        amount = amount - coin50;
 
    for (coin20 = 20, ccount20 = 0; amount >= coin20; ++ccount20) 
        amount = amount - coin20;
 
    for (coin10 = 10, ccount10 = 0; amount >=  coin10; ++ccount10) 
        amount = amount - coin10;
 
    for (coin5 = 5, ccount5 = 0; amount >=  coin5; ++ccount5) 
        amount = amount - coin5;        
 
    printf ("Customer Change:\n %i 100 dollar note/s\n %i 50 dollar note/s\n %i 20 dollar note/s %i 10 dollar note/s, %i 5 dollar note/s\n %i 2 dollar coin/s\n %i 1 coin/s\n",dcount100, dcount50, dcount20, dcount10, dcount5, dcount2, dcount1); 
 
    printf ("Customer Change:\n %i 50 cent coin/s\n %i 20 cent coin/s\n %i 10 cent coin/s\n %i 5 cent coin/s\n", ccount50, ccount20, ccount10, ccount5); 
 

I also compiled i it in miracle c and comes up wtih the error:
line 37: unrecognised types in comparison
'for (dollar100 = 100, dcount100 = 0' ?

[kreagan]

Hi again, I have added dollars, to the program to make things more complex. I got the program to compile ok in Dev C++. Invalid dollars and cents will generate the appropriate response however my initial problem has occurred again however this time im pretty sure that it is not variable initialization.

 
int dollar, cents, coin50, coin20, coin10, coin5, ccount50, ccount20, ccount10, ccount5; 
    int dollar100, dollar50, dollar20, dollar10, dollar5, dollar2, dollar1, dcount100, dcount50, dcount20, dcount10, dcount5, dcount2, dcount1;   
    float amount;
 
    for (dollar100 = 100, dcount100 = 0; amount >=  dollar100; ++dcount100) 
        amount = amount - dollar100;
 
    for (dollar100 = 50, dcount50 = 0; amount >=  dollar50; ++dcount50) 
        amount = amount - dollar50;
 
 

I also compiled i it in miracle c and comes up wtih the error:
line 37: unrecognised types in comparison
'for (dollar100 = 100, dcount100 = 0' ?

I could compile it. The only problem I had was the 2nd for loop. dollar50 doesn't contain a value due to a typo. Instead of for(dollar100 = 50 ... ), it should be dollar50.

As for your compile issue, maybe your compiler cannot compair a float to an int. This is only a guess. I would suggest typcasting.

for (dollar100 = 100, dcount100 = 0; amount >=  (float)dollar100; ++dcount100) 
        amount = amount - dollar100;

Other than that, I don't know. Seems to be compiler specific.

[Ganon11]

This code will not work: Your coin5 variable holds the same value as your dollar5 variable, and so each are being treated as $5. You need to use doubles for your coins to get the proper results.

[geebanga88]

That one typo fixed it. I can also compile it in dev c++, just not in miracle c. Thanks for spotting that out, i think the code is a poorly design because of to many variables and loops being used which makes it difficult to spot those kinds of errors.