Whats the problem with this code

[flavourofbru]

HI,

I am reading a text file and then adding 1 to each element and displaying it.

the code is as follows:

#include "stdafx.h"
#include <iostream>
#include <fstream>
#include <string>
#include <sstream>
using namespace std;

int main ()
{
string line;
ifstream fnamet("abc.txt");
int Rows=0,Columns=0;
int relR,relG,relB,count;
if (fname.is_open())
{
while (! fname.eof() )
{
int i=0,a[4];//taken no of columns < =4
getline (fname,line);
istringstream tSS( line );
while( ! tSS.eof())
{
tSS>>a[i];
i++;
}

//if(Columns<2&&i>1) Columns=i;
if(i>3)
{
R=a[0]+1;
G=a[1]+1;
B=a[2]+1;
count=a[3];


printf("%d %d %d %d\n",R,G,B,a[3]);
}
}
printf("Rows=%d Columns=%d\n",histRows,histColumns);

fname.close();
}
else cout << "Unable to open file";
return 0;
}

Tha above code doesnt show any problem and shows the output.
Now I need to enter those values in a array as follows.
array[R][G][b] = count;
and my array size is 128*128*128.
If i am trying to do above, it doesnt show any compiling errors, but output is not generated. Shows that .exe file stopped working.

Pls help me how to achieve this.

Thanks,
Rishi

[niskin]

ifstream fnamet("abc.txt");
int Rows=0,Columns=0;
int relR,relG,relB,count;
if (fname.is_open())
{
while (! fname.eof() )

Here you have a file pointer called fnamet, but your loops are to do with a filepointer called fname.

[weaknessforcats]

This says you are using Windows:

#include "stdafx.h"

so you should be using the RGB structure of Win32.

[flavourofbru]

Yes I am using windows.

So wats the problem with the code.
Though it doesnt show any errors and gets compiled.
When showing the output it simply outputs .exe file stopped working.

Please help.

Thanks!!

[weaknessforcats]

Better send your stdafx.h so I can get this to compile.

Also, I need a sample of your input file.

[flavourofbru]

Hi,
Here is my stdafx.h file

// stdafx.h : include file for standard system include files,
// or project specific include files that are used frequently, but
// are changed infrequently
//

#pragma once


#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers
#include <stdio.h>
#include <tchar.h>



// TODO: reference additional headers your program requires here

and my sample text file is as follows:

12 23 45 65
89 34 9 43
95 32 65 39

pls help!!
Thanks!!

[weaknessforcats]

//#include "stdafx.h"
#pragma once
 
 
#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers
#include <stdio.h>
#include <tchar.h>
 
#include <iostream>
#include <fstream>
#include <string>
#include <sstream>
using namespace std; 
 
int main () 
{
string line;
//ifstream fnamet("abc.txt");
ifstream fname("c:\\scratch\\instructor\\abc.txt");
int Rows=0,Columns=0;
int relR,relG,relB,count;
if (fname.is_open())
{
while (! fname.eof() )
{
int i=0,a[4];//taken no of columns < =4
getline (fname,line);
istringstream tSS( line );
while( ! tSS.eof())
{
tSS>>a[i];
i++;
}
 
//if(Columns<2&&i>1) Columns=i;
if(i>3)
{
/*
R=a[0]+1;
G=a[1]+1;
B=a[2]+1;
count=a[3];
 
 
printf("%d %d %d %d\n",R,G,B,a[3]);
*/
relR=a[0]+1;
relG=a[1]+1;
relB=a[2]+1;
count=a[3];
 
 
printf("%d %d %d %d\n",relR,relG,relB,a[3]);
 
}
}
//printf("Rows=%d Columns=%d\n",histRows,histColumns);
printf("Rows=%d Columns=%d\n",Rows,Columns);
 
fname.close();
}
else cout << "Unable to open file"; 
return 0;
}
 

This does what you programmed. I didn't know what histRows and histColimns are so I fudged it.

[flavourofbru]

Hi,

Thanks for the help. The histRows and HistColumns are just the Rows and Columns.

The above program works properly. The problem is coming when I am trying to do the following. I am adding the following code in this place

if(i>3)
{

relR=a[0]+1;
relG=a[1]+1;
relB=a[2]+1;
count=a[3];

/*add the code at this place
initialize a 3D array of size 128*128*128 and at this place add the following
array_3D[relR][relG][relB] = count; */

printf("%d %d %d %d\n",relR,relG,relB,a[3]);

}

There are no compiling errors but while looking at the output it shows .exe files stopped working.

Please help.

I need to enter the count values into a 3d array at the position of array_3d[relR][relG][relB].

Thanks!!

[weaknessforcats]

128 x 128 x 128 = 294912.

As an array this is fine. As a stack array, this is way too big.

int array[128][128][128];   //wrong! probably exceeds your stack memory allowance
int (* array1)[128][128] = new int[128][128][128]; //OK
 

[flavourofbru]

HI Thanks for the help!!
It worked.