Function that standardize a string with lowercase and uppercase ?

[The_Kingpin]

Hi all, I need to make a function that convert a string into a certain
format. Here what are the restriction:

-The first letter of the first and last name must be uppercase.
-If a first name contains only 1 character, a '.' must follow the char.
-If we find a character that isn't a letter (.&*-), we must swap it for a
'/' and
add the correct spaces.

I tried making a function but my switch seems to have an error. If anyone
could help me out or give me a better way, that would be very appreciated
!
Right now I'm reading each letter of a name and treating itindividually.
I'm pretty sure there's a better way I'm not aware of ;)

Thanks, Frank

int formatName(char *name[], int length)
{
int i;
if(length==1)
{
/* If the word has only 1 letter, we put it in uppercase,
add a space after the letter and resize the word to
move every letter after the space
*/
toupper(name[i]);
name[i+1]=' ';
for(i;i<length;i++)
{
realloc(name[length], sizeof(name[length]+1));
name[i+1]=name[i];
}
}
else
{
/* The word has more than 1 letter */
for(i=0; name[i]<=name[length]; i++)
{
switch(name[i])
{
/* If we find a space, then the next character
is a new word and starts with an uppercase. */
case ' ':
toupper(name[i+1]);
break;
 
/* If the character is not a letter, we swap it
for a / and we check if there is spaces between
it. */
case '.': case '&': case '*':
name[i] = '/';
if(name[i+1]!=' ' && name[i+1]!='\0'){name[i+1]='
';}
if(name[i-1]!=' ' && name[i-1]!='\0'){name[i-1]='
';}
break;
 
/* If the character wasn't treat yet, it's a normal
case and we put it in lowercase. */
default:
tolower(name[i]);
}
}
}
return 0;
}
 

[Jim]

On Tue, 26 Oct 2004 02:03:23 -0400, "The_Kingpin"
<th**********@hotmail.com> wrote:

Hi all, I need to make a function that convert a string into a certain
format. Here what are the restriction:

-The first letter of the first and last name must be uppercase.
-If a first name contains only 1 character, a '.' must follow the char.
-If we find a character that isn't a letter (.&*-), we must swap it for a
'/' and
add the correct spaces.

I tried making a function but my switch seems to have an error. If anyone
could help me out or give me a better way, that would be very appreciated
!
Right now I'm reading each letter of a name and treating itindividually.
I'm pretty sure there's a better way I'm not aware of ;)

Thanks, Frank

int formatName(char *name[], int length)

 

You want

int formatName(char *name, int length)

{

     int i;

     if(length==1)

     {

          /* If the word has only 1 letter, we put it in uppercase,

             add a space after the letter and resize the word to

             move every letter after the space

          */

 

You haven't defined i to be anything yet, so

i=0;

          toupper(name[i]);

toupper() is a function call.  You need to assign the result

somewhere.

name[i] = toupper(name[i]);

          name[i+1]=' ';

 

This isn't going to work for many reasons.  sizeof(name)

doesn't give you the length of the string in name, strlen(name) does

that.  How do you plan to return the new string to the calling

function?  You need to rethink the interface.  name[length] isn't what

you think it is.  It only builds because your function definition is

wrong.

          for(i;i<length;i++)

            {

               realloc(name[length], sizeof(name[length]+1));

               name[i+1]=name[i];

            }

     }

     else

     {

          /* The word has more than 1 letter */

 

name[length] is nonsense - that would be the last character of the

string, assuming length is the string length, and it would always be

0.

 

for (i=0; i < strlen(name); i++)

or

for (i=0; i < length; i++)

          for(i=0; name[i]<=name[length]; i++)

          {

               switch(name[i])

               {

                    /* If we find a space, then the next character

                       is a new word and starts with an uppercase. */

                    case ' ':

                         toupper(name[i+1]);

Same as above.  Might also want to check name[i+1] isn't '\0'.

if (name[i+1] != '\0')

name[i+1]=toupper(name[i+1]);

                         break;

                    /* If the character is not a letter, we swap it

                       for a / and we check if there is spaces between

                       it. */

 

Don't understand what you're trying to do.

Looks like if you see a '.' or '&' or '*' you replace it with '/'.

If the next character is ' ' and not '\0' (silly, it can't be both)

replace it with '>'

If the prev character is ' ' and not '\0' (silly, again) replace it

with '>'

                    case '.': case '&': case '*':

                         name[i] = '/';

                         if(name[i+1]!=' ' && name[i+1]!='\0'){name[i+1]='>';}

                         if(name[i-1]!=' ' && name[i-1]!='\0'){name[i-1]='>';}

                         break;

                    /* If the character wasn't treat yet, it's a normal

                       case and we put it in lowercase. */

                    default:

                         tolower(name[i]);

Same as above

name[i] = tolower(name[i]);

               }

          }

     }

 

You're not returning anything useful.

     return 0;

}