i am looking for a more elegant/standard way to do this simple
operation,
however, for now, i just coded this beast. any comments will be
grateful,
ObserverMap::it erator itr = observers_.begi n();
while(itr != observers_.end( )){
if(itr->second == observer){
ObserverMap::it erator tmpItr = ++itr;
--itr;
observers_.eras e(itr);
itr = tmpItr;
continue;
}
++itr;
}
- minglei 3 1168 ke****@gmail.co m wrote:
i am looking for a more elegant/standard way to do this simple
operation,
however, for now, i just coded this beast. any comments will be
grateful,
ObserverMap::it erator itr = observers_.begi n();
while(itr != observers_.end( )){
if(itr->second == observer){
ObserverMap::it erator tmpItr = ++itr;
--itr;
observers_.eras e(itr);
itr = tmpItr;
OK, maybe I'm stating the obvious here, but the above FOUR lines
can be rewritten as just one:
observers_.eras e(itr++);
continue;
Drop the 'continue' and add 'else' below.
}
add
else
here.
>
++itr;
}
- minglei
IOW, you should be able to do what you need like so:
ObserverMap::it erator itr = observers_.begi n();
while (itr != observers_.end( )) {
if (itr->second == observer)
observers_.eras e(itr++);
else
++itr;
}
How's that?
V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
IOW, you should be able to do what you need like so:
ObserverMap::it erator itr = observers_.begi n();
while (itr != observers_.end( )) {
if (itr->second == observer)
observers_.eras e(itr++);
else
++itr;
}
How's that?
V
cool, that's really cool, a little arrange of code.
for(ObserverMap ::iterator itr = observers_.begi n(); itr !=
observers_.end( ); )
if (itr->second == observer)
observers_.eras e(itr++);
else
++itr;
- minglei
Hi!
Victor Bazarov schrieb:
IOW, you should be able to do what you need like so:
ObserverMap::it erator itr = observers_.begi n();
while (itr != observers_.end( )) {
if (itr->second == observer)
observers_.eras e(itr++);
else
++itr;
}
Now we consolidate the increment ++itr:
ObserverMap::it erator itr = observers_.begi n();
while (itr != observers_.end( )) {
const ObserverMap::it erator current = itr++;
if (current->second == observer)
observers_.eras e(current);
}
This is less confusing to me.
Regards, Frank This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: Woodster |
last post by:
I have declared the following
std::map<std::string, std::string> myMap;
to pass myMap to functions should I be declaring functions as:
void function(std::map<std::string, std::string>);
or is there a preferred/better method of doing this?
|
by: Antti Granqvist |
last post by:
Hello!
I have following object relations:
Competition 1--* Category 1--* Course
1
|
|
*
Course
|
by: Serengeti |
last post by:
Hello,
in my class I have a map that translates strings to pointers to some
member functions. The code goes like this:
class F {
typedef void (Function::*MathFuncPtr)();
std::map<std::string, MathFuncPtr> predefinedFunctions;
// lots of other stuff
void makeDictionary(){ predefinedFunctions=&F::f_sin(); }
};
|
by: Erik Wikström |
last post by:
First of all, forgive me if this is the wrong place to ask this question,
if it's a stupid question (it's my second week with C++), or if this is
answered some place else (I've searched but not found anything).
Here's the problem, I have two sets of files, the name of a file contains a
number which is unique for each set but it's possible (even probable) that
two files in different sets have the same numbers. I want to store these...
|
by: Dan Trowbridge |
last post by:
Hi everyone,
In my attempt to port code from VS 6.0 to VS.NET I had some code break along
the way, mostly due to not adhereing closely to the C++ standard. This may
be another instance but I can't think of a good fix, or even why it broke.
The problem
In one of my CFormView derived classes I have a member variable of the
type...
| |
by: Avery Fong |
last post by:
The following program will result in a compile error when building under Debug but will compile under Release. Why does is work under Release mode but not under Debug
This program is developed under Visual Studio .NET 2003 in a Win32 Console Project
// VectorInsert.cpp : Defines the entry point for the console application
/
#include "stdafx.h
#include "VectorInsert.h
#ifdef _DEBU
|
by: kamaraj80 |
last post by:
Hi
I am using the std:: map as following.
typedef struct _SeatRowCols
{
long nSeatRow;
unsigned char ucSeatLetter;
}SeatRowCols;
typedef struct _NetData
|
by: Diwa |
last post by:
Does the "value" type (value as in key-value pair )of "std::map"
require a default ctor even if it is not used ?
If I comment out Line 1 in the code attached later,
i.e remove the default ctor of "value" type of map,
I get the following error:
// --------------------------------------------
/usr/include/c++/3.2.3/bits/stl_map.h:225: no matching function for
call to `FieldType::FieldType()'
|
by: Chris Forone |
last post by:
Hello group,
g++ (3.4.2, mingw):
float init = {1.f, 2.f, 3.f};
std::map<std::string, std::valarray<float mp;
mp = std::valarray(init, 3);
mp.size(); // should be 3, but IS 0!
|
by: mveygman |
last post by:
Hi,
I am writing code that is using std::map and having a bit of an issue
with its performance.
It appears that the std::map is significantly slower searching for an
element then a sequential search in a vector.
Has anyone run into this before?
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main usage, and What is the difference between ONU and Router. Let’s take a closer look !
Part I. Meaning of...
| |
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it.
First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed.
This is as boiled down as I can make it.
Here is my compilation command:
g++-12 -std=c++20 -Wnarrowing bit_field.cpp
Here is the code in...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For most users, this new feature is actually very convenient. If you want to control the update process,...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then launch it, all on its own....
Now, this would greatly impact the work of software developers. The idea...
|
by: adsilva |
last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
|
by: 6302768590 |
last post by:
Hai team
i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system
| |
by: muto222 |
last post by:
How can i add a mobile payment intergratation into php mysql website.
|
by: bsmnconsultancy |
last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...
| |