Declared global variable isn't being seen by main.

[Tristin.Colby]

Can someone tell me why giv_len isn't being seen in this statement
below "printf("Re cord %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len)"

=cut

#include <stdio.h>
#include <stdlib.h>

char delimiter = '\n';
unsigned long long int cur_len = 0L;
int giv_len;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = argv[1];
char* outfile = argv[2];
giv_len = atoi(argv[3]);
printf("giv_len is :%d\n",giv_len) ;

FILE* i = fopen(infile,"r ");
FILE* o = fopen(outfile," w");
int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;
/*printf("%d\n", cur_len); */
if(cur_len != giv_len) {
printf("Record %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len);
fprintf(o,"Reco rd %d wrong length:%d\n",re cord,cur_len);
}
cur_len=0;
}
}
fclose(i);
fclose(o);
return 0;
}

[Lew Pitcher]

Tr***********@g mail.com wrote:

Can someone tell me why giv_len isn't being seen in this statement
below "printf("Re cord %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len)"

The answer is "because you lied to printf() by telling it that the cur_len
variable was an int".

Correct your printf() statement format string to reflect the fact that the
second variable value is an unsigned long long, and your problem should go
away.

=cut

#include <stdio.h>
#include <stdlib.h>

char delimiter = '\n';
unsigned long long int cur_len = 0L;
int giv_len;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = argv[1];
char* outfile = argv[2];
giv_len = atoi(argv[3]);
printf("giv_len is :%d\n",giv_len) ;

FILE* i = fopen(infile,"r ");
FILE* o = fopen(outfile," w");
int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;
/*printf("%d\n", cur_len); */
if(cur_len != giv_len) {
printf("Record %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len);
fprintf(o,"Reco rd %d wrong length:%d\n",re cord,cur_len);
}
cur_len=0;
}
}
fclose(i);
fclose(o);
return 0;
}

--
Lew Pitcher

Master Codewright & JOAT-in-training | Registered Linux User #112576
http://pitcher.digitalfreehold.ca/ | GPG public key available by request
---------- Slackware - Because I know what I'm doing. ------

[Tristin.Colby]

changed to the following:

printf("Record %lu wrong length:%llu Should be %d
\n",record,cur_ len,giv_len);

to no avail
On Mar 13, 8:32 pm, Lew Pitcher <lpitc...@teksa vvy.comwrote:

Tristin.Co...@g mail.com wrote:

Can someone tell me why giv_len isn't being seen in this statement
below "printf("Re cord %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len)"

The answer is "because you lied to printf() by telling it that the cur_len
variable was an int".

Correct your printf() statement format string to reflect the fact that the
second variable value is an unsigned long long, and your problem should go
away.

=cut

#include <stdio.h>
#include <stdlib.h>

char delimiter = '\n';
unsigned long long int cur_len = 0L;
int giv_len;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = argv[1];
char* outfile = argv[2];
giv_len = atoi(argv[3]);
printf("giv_len is :%d\n",giv_len) ;

FILE* i = fopen(infile,"r ");
FILE* o = fopen(outfile," w");
int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;
/*printf("%d\n", cur_len); */
if(cur_len != giv_len) {
printf("Record %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len);
fprintf(o,"Reco rd %d wrong length:%d\n",re cord,cur_len);
}
cur_len=0;
}
}
fclose(i);
fclose(o);

return 0;
}

--
Lew Pitcher

Master Codewright & JOAT-in-training | Registered Linux User #112576http://pitcher.digital freehold.ca/ | GPG public key available by request
---------- Slackware - Because I know what I'm doing. ------

[Tristin.Colby]

I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

Any way I can work around this and get the long long?
On Mar 13, 8:40 pm, Tristin.Co...@g mail.com wrote:

changed to the following:

printf("Record %lu wrong length:%llu Should be %d
\n",record,cur_ len,giv_len);

to no avail

On Mar 13, 8:32 pm, Lew Pitcher <lpitc...@teksa vvy.comwrote:

Tristin.Co...@g mail.com wrote:

Can someone tell me why giv_len isn't being seen in this statement
below "printf("Re cord %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len)"

The answer is "because you lied to printf() by telling it that the cur_len
variable was an int".

Correct your printf() statement format string to reflect the fact that the
second variable value is an unsigned long long, and your problem should go
away.

=cut

#include <stdio.h>
#include <stdlib.h>

char delimiter = '\n';
unsigned long long int cur_len = 0L;
int giv_len;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = argv[1];
char* outfile = argv[2];
giv_len = atoi(argv[3]);
printf("giv_len is :%d\n",giv_len) ;

FILE* i = fopen(infile,"r ");
FILE* o = fopen(outfile," w");
int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;
/*printf("%d\n", cur_len); */
if(cur_len != giv_len) {
printf("Record %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len);
fprintf(o,"Reco rd %d wrong length:%d\n",re cord,cur_len);
}
cur_len=0;
}
}
fclose(i);
fclose(o);

return 0;
}

--
Lew Pitcher

Master Codewright & JOAT-in-training | Registered Linux User #112576http://pitcher.digital freehold.ca/ | GPG public key available by request
---------- Slackware - Because I know what I'm doing. ------

[santosh]

Tr***********@g mail.com wrote:

I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

Any way I can work around this and get the long long?

<top post snipped>

This is a well known "interoperabili ty issue" between MinGW and
Microsoft's C runtime library. MinGW's compiler, gcc, supports long
long while the C library it links to by default (Microsoft's CRT) does
not support almost any C99 features, including long long. Thus printf
(which is part of CRT) displays the value incorrectly.

The fix is to use a compiler and C library that agree with each other.
An alternative to MinGW on Windows may be Cygwin, or DJGPP.

[Barry Schwarz]

On Thu, 13 Mar 2008 18:44:34 -0700 (PDT), Tr***********@g mail.com
wrote:

>I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

If you compiler doesn't support long long, your object declarations
should result in a compile time diagnostic. Have you set the warning
level to the appropriate level?

>Any way I can work around this and get the long long?

Why? unsigned long is guaranteed to support a value of at least 2G.
Are you planning on testing with a larger file?

>

On Mar 13, 8:40 pm, Tristin.Co...@g mail.com wrote:

>changed to the following:

printf("Reco rd %lu wrong length:%llu Should be %d
\n",record,cur _len,giv_len);

to no avail

It would be nice if you told us what output you were expecting and
what you actually received.

>>
On Mar 13, 8:32 pm, Lew Pitcher <lpitc...@teksa vvy.comwrote:

Tristin.Co...@g mail.com wrote:
Can someone tell me why giv_len isn't being seen in this statement
below "printf("Re cord %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len)"

The answer is "because you lied to printf() by telling it that the cur_len
variable was an int".

Correct your printf() statement format string to reflect the fact that the
second variable value is an unsigned long long, and your problem should go
away.

=cut

#include <stdio.h>
#include <stdlib.h>

char delimiter = '\n';
unsigned long long int cur_len = 0L;
int giv_len;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = argv[1];
char* outfile = argv[2];
giv_len = atoi(argv[3]);

Will the value you provide in argv[3] fit in an int?

printf("giv_len is :%d\n",giv_len) ;

FILE* i = fopen(infile,"r ");
FILE* o = fopen(outfile," w");

Don't you think you ought to check to make sure both streams are
actually open?

int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;

You planning on supporting a file with 2G records?

/*printf("%d\n", cur_len); */
if(cur_len != giv_len) {
printf("Record %d wrong length:%d Should be %d
\n",record,cur_ len,giv_len);

You changed this one -

fprintf(o,"Reco rd %d wrong length:%d\n",re cord,cur_len);

but you forgot to change this one. Neither record nor cur_len are of
type int as promised by the %d specifications.

}
cur_len=0;
}
}
fclose(i);
fclose(o);

return 0;
}

Remove del for email

[Tristin.Colby]

I'm using files that can potentially be several terabytes. My first
test file was over 232GB. I had to compile with the -
D_FILE_OFFSET_B ITS=64 flag just to be able to open it. I'm getting
relatively good performance though, over 1GB a minute. Here's an
example of the output.

Record 201 exceeds maximum length:31920669 04
Record 301 exceeds maximum length:40096225 04

Yes the value provided to argv[3] will fit into an int. Our products
have a max length of a record so it'll never be bigger than 102400
bytes. This app should really help. Try searching through 500GB for a
single bad record. :)

Here's the actual "finished" code Maybe someone else can get some use
out of it or tell me some way to optimize it further.

=cut

#include <stdio.h>
#include <stdlib.h>
#include <getopt.h>

/* Unsure if these are really needed */
#define _FILE_OFFSET_BI TS 64
#define _LARGEFILE_SOUR CE

/* you must use the compiler flag -D_FILE_OFFSET_B ITS=64 on linux
so that it is possible to open/parse files larger than 2GB

2008 March 13
*/
int debug = 0;

void help();

char delimiter = '\n';
unsigned long int cur_len = 0L;
int giv_len = 0;
unsigned long int record = 0L;

int main(int argc, char *argv[])
{
char* infile = NULL;
char* outfile = NULL;
giv_len = 0;

if(debug) {
int i = 0;
for(i=0;i<argc; i++) {
printf("%s\n",a rgv[i]);
}
}

if(argc == 1) {
help();
exit(0);
}

int option;
/* Parse Our options
*************** *************** *************** **************/
while( (option=getopt( argc,argv,"i:o: l:h")) != -1 ) {
switch(option) {
case 'i':
infile = optarg;
break;
case 'o':
outfile = optarg;
break;
case 'l':
giv_len = atoi(optarg);
break;
case 'h':
help();
break;
case '?':
printf("Unknown argument:%c\n", optopt);
exit(2);
break;
case ':':
printf("Option %c requires an argument\n",opt opt);
exit(2);
break;

}
}

FILE* i;
FILE* o;

if( (( i = fopen(infile,"r ") ) == NULL ) || ( o =
fopen(outfile," w") ) == NULL) {
printf("You must specify a valid input and output file\n");
perror("Error") ;
exit(2);
}

if(giv_len == 0) {
printf("You must give a [maximum] record length\n");
exit(2);
}

int ch;
while((ch=fgetc (i) ) != EOF) {
++cur_len;

if(ch == delimiter) {
++record;

if(cur_len giv_len) {
printf("Record %lu exceeds maximum length:%lu
\n",record,cur_ len);
fprintf(o,"Reco rd %lu exceeds maximum length:%lu
\n",record,cur_ len);
}
cur_len=0;
}
}
fclose(i);
fclose(o);
return 0;
}

void help() {
printf("\n");
printf("Variabl e Length File Verifier:\n");
printf("-i file The name of the input file\n");
printf("-o file The name of the output file\n");
printf("-l length The max number of bytes per record\n");
printf("-h This screen\n");
printf("\n");
printf("Example : variable.exe -i 99999.SO01 -o badrecords.txt -l
102400\n");
printf("\n");
printf("\n");
}

[ymuntyan]

On Mar 13, 8:44 pm, Tristin.Co...@g mail.com wrote:

I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

http://www.mingw.org/MinGWiki/index.php/long%20long

[Keith Thompson]

santosh <sa*********@gm ail.comwrites:

Tr***********@g mail.com wrote:

>I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

Any way I can work around this and get the long long?

<top post snipped>

This is a well known "interoperabili ty issue" between MinGW and
Microsoft's C runtime library. MinGW's compiler, gcc, supports long
long while the C library it links to by default (Microsoft's CRT) does
not support almost any C99 features, including long long. Thus printf
(which is part of CRT) displays the value incorrectly.

The fix is to use a compiler and C library that agree with each other.
An alternative to MinGW on Windows may be Cygwin, or DJGPP.

Really? I've heard that MinGW has an inconsistency in the
representation of long double supported by the compiler vs. the
representation expected by the (MS-provided) runtime library. I
hadn't heard that there was an issue with long long. You could well
be right, of course.

--
Keith Thompson (The_Other_Keit h) <ks***@mib.or g>
Nokia
"We must do something. This is something. Therefore, we must do this."
-- Antony Jay and Jonathan Lynn, "Yes Minister"

[Keith Thompson]

Barry Schwarz <sc******@dqel. comwrites:

On Thu, 13 Mar 2008 18:44:34 -0700 (PDT), Tr***********@g mail.com
wrote:

>>I think i figured it out. I'm on a windows box(using minGW). maybe it
doesn't support long long b/c when i change it to just unsigned long
and change the format accordingly, it works.

If you compiler doesn't support long long, your object declarations
should result in a compile time diagnostic. Have you set the warning
level to the appropriate level?

If the compiler supports long long, but the runtime library doesn't
(in particular, if printf doesn't support the "%llu" format), then you
could have problems that don't show up as compiler error messages. I
know that MinGW, which combines a compiler and a runtime library from
two different sources, has this kind of problem with long double; it
might have a similar problem with long long.

[snip]

Tristin, please don't top-post. Read the following:

http://www.caliburn.nl/topposting.html
http://www.cpax.org.uk/prg/writings/topposting.php

--
Keith Thompson (The_Other_Keit h) <ks***@mib.or g>
Nokia
"We must do something. This is something. Therefore, we must do this."
-- Antony Jay and Jonathan Lynn, "Yes Minister"