Passing data into a function

[howmanymiles]

I am currently writing a program which works out student marks and outputs the passes and fails two files. I have written some code but it does seem work as no names are displayed and according to this everybody has passed. My switch function is working, so why dont the other functions work? I have been creating new constructors, adding to the student class and allsorts but I just keep getting errors. My code is below

#include <cstdlib>
#include <iostream>
#include <fstream>
#include <string>
using namespace std;
 
//This is the class definition of student
 
class Student
{
public:
Student();
Student(string n, int y, int m1, int m2);
int getYear(){return year;}
double getOverallMark();
string getformatName();
bool getpassed();
static int GetCountPasses();
static int GetCountFails();
 
 
private:
string studentName;
int mark1;
int mark2;
int year;
string studentFName;
string studentSurname;
string name;
double overallMark;
static int CountPasses();
static int CountFails();
string formatName();
bool passed();
 
};
 
// Default constructor of the Student Class
Student::Student ()
{
studentName = "";
mark1 = 0;
mark2 = 0;
year = 0;
}
 
// This is the constructor of the student class
Student::Student (string n, int y, int m1, int m2)
{
studentName = n;
mark1 = m1;
mark2 = m2;
year = y;
}
 
 
//Function prototype for menuselect
char menuselect();
 
//MenuSelect function
char menuselect()
{
char menusel;
char userchoice;
cout << "Display the student with the overall highest mark (H) or lowest overall mark (L)" << endl;
cin >> menusel;
 
if (menusel == 'H' || menusel == 'h')
 
{
userchoice = 'H';
}
 
else if (menusel == 'L' || menusel == 'l')
 
{
userchoice = 'L';
}
return userchoice;
}
 
 
// This is the major part of the program
int main ()
{
string studentFName;
string studentSurname;
string student_Name;
int yearStudy;
int mark1;
int mark2;
char userChoice;
 
userChoice = menuselect();
ifstream markfile;
markfile.open("student_marks.txt");
if ( markfile.fail ())
 
{
cout << "There is an error in opening the file." << endl;
cout << "The program will now close!" <<endl;
exit(1);
}
 
ofstream passes;
passes.open("pass.txt");
ofstream fails;
fails.open("fail.txt");
 
while ( ! markfile.eof())
 
{
markfile >> studentFName >> studentSurname >> yearStudy >> mark1 >> mark2;
cout << "I'm in the code!" << " " << studentFName << " " << studentSurname << " "<< yearStudy << " " << mark1 << " " << mark2;
student_Name = studentFName + " " + studentSurname;
Student s1(student_Name, yearStudy, mark1, mark2);
 
 
string propname;
double mark;
bool passed;
 
propname = s1.getformatName();
mark = s1.getOverallMark();
passed = s1.getpassed();
 
 
 
if (passed = 1)
{
passes << propname << " " << mark << " " << "PASS" << endl;
}
else if (passed = 0)
{
fails << propname << " " << mark << " " << "FAIL" << endl;
}
}
markfile.close();
passes.close();
fails.close();
return 0;
}
 
 
double Student::getOverallMark()
{
switch (year)
{
 
case 1 :
overallMark = static_cast<double>((mark1+mark2)/2);
break;
 
case 2 :
overallMark = static_cast<double>((mark1 * 0.4) + (mark2 * 0.6));
break;
 
case 3 :
overallMark = static_cast<double>((mark1 * 0.3) + (mark2 * 0.7));
break;
 
default:
cout << "There is an error somewhere, program will now close!!!" << endl;
exit(1);
}
return overallMark;
}
 
 
 
string Student::getformatName()
{
string f;
string s;
string i;
string name;
 
f = "David";
s = "Lee";
 
name = f + " " + s;
 
i = f.substr(0,1);
 
name = s + " ," + i + ".";
 
return name;
}
 
 
 
bool Student::getpassed()
{
if(overallMark >= 40)
return true;
else
return false;
}
 
 
 
 
 

Any help would be appriacited as I have been trying how to work out this problem for hours but to no avail.

[Savage]

By no names are displayed,you mean nothing is written to file,or nothing is outputted with cout,or both?

[howmanymiles]

Ignore the cout statments, I just put them there to see if the code is working, and I do get an output to screen. What I meant was that there are no names in the files but the comma and full stop is in the files so the function must be working but no data must be getting passed to it.

[Savage]

Have you couted:

propname = s1.getformatName();
mark = s1.getOverallMark();
passed = s1.getpassed();

,to see what is in these variables?

[howmanymiles]

If I do that I get errors including 'getFormatName' undeclared (first use this function)

[Savage]

If I do that I get errors including 'getFormatName' undeclared (first use this function)

Perhaps you puted getFormatName instead of getformatName,o r if is this just a posting error move getformatName declaration to some place before main.

[howmanymiles]

What do you mean by the get format name declaration? and how do I pass data into the function. I want getFormatName to use studentFName and studentSurname.

[sicarie]

howmanymiles-

You are having very basic issues with C++ that we are not going to be able to help you with easily. As the language is case-sensitive, there is a difference between getformatName() and getFormatName(). The use of a capital F in one is referencing a completely different function.

Please read a tutorial such as this or your class' reading materials thoroughly before posting again. You're missing key conceptual elements that will take a very long time for us to explain.

That is a very good tutorial site, if you look through the others, you will probably find several things you didn't know before...