circular includes/in file problems

[Saltydog]

Ok so I ahve spent a while reading around this site and some others, and I thought there might of been some errors with my includes, but now I am just really confused. Basically I have a 3 classes, a main class and 2 sub classes the sub classes point at each other, but interactions is no more then pointing.

In the main program I have #include "school.h" in the header. I have the error

from schoolMain.cpp In file included from school.h:5, from schoolMain.cpp

some common other errors are:

student.h expected unqualified-id before '.' token

student.h variable or field `setID' declared void

from what I've read, this is either a include error or a syntax error. the code for school is:

#ifndef school_H
#define school_H
 
#include <string>
#include "student.h"
#include "unit.h"
 
class school
{
      public:
             School() {myStudents.resize(1); myUnits.resize(1)};
             ~School();
             void addStudentUnit(string studentName, string unitName);
             void printUnitsOfStudent(string studentName) const;
             void printStudentsOfUnit(string unitName) const;
             bool studentExists(string studentName, int &size);
             bool unitExists(string unitName, int &size)
 
      private:
              vector<student> myStudents();
              vector<unit> myUnits;    
}
 
#endif
 

I'm thinkin the error is pointing to header 5, which is the unit.h

#ifndef unit_H
#define unit_H
 
#include <iostream>
#include <string>
 
class student;
 
class unit
{
      public:
             unit() {unitName = ""; pupils.resize(1);};
             void setUnitName(string name);
             string getUnitName() const;
             string getPupil();
             void addPupil(student *p);
             void printPupils() const;
      private:
              string unitName;
              vector<student *> pupils;
}
 
#endif
 

Might as well put in the otehr class for safe measure

#ifndef stu_H
#define stu_H
 
#include <iostream>
#include <string>
 
class unit.h;
 
class student
{
      public:
          student() {id=""; units.resize(1);};
          void setID(string name);
          string getID() const;
          void addUnit(*unit);
          void printUnits() const;
 
      private:
              string id;
              vector<unit *> units;
}
 
#endif
 

any hints are much appreciated. Thank you in advance
Salty

[DumRat]

Ok so I ahve spent a while reading around this site and some others, and I thought there might of been some errors with my includes, but now I am just really confused. Basically I have a 3 classes, a main class and 2 sub classes the sub classes point at each other, but interactions is no more then pointing.

In the main program I have #include "school.h" in the header. I have the error

from schoolMain.cpp In file included from school.h:5, from schoolMain.cpp

from what I've read, this is either a include error or a syntax error. the code for school is:

#ifndef school_H
#define school_H
 
#include <string>
#include "student.h"
#include "unit.h"
 
class school
{
      public:
             School() {myStudents.resize(1); myUnits.resize(1)};
             ~School();
             void addStudentUnit(string studentName, string unitName);
             void printUnitsOfStudent(string studentName) const;
             void printStudentsOfUnit(string unitName) const;
             bool studentExists(string studentName, int &size);
             bool unitExists(string unitName, int &size)
 
      private:
              vector<student> myStudents();
              vector<unit> myUnits;    
}
 

I'm thinkin the error is pointing to header 5, which is the unit.h

#ifndef unit_H
#define unit_H
 
#include <iostream>
#include <string>
 
class student;
 
class unit
{
      public:
             unit() {unitName = ""; pupils.resize(1);};
             void setUnitName(string name);
             string getUnitName() const;
             string getPupil();
             void addPupil(student *p);
             void printPupils() const;
      private:
              string unitName;
              vector<student *> pupils;
}
 
#endif
 

Might as well put in the otehr class for safe measure

#ifndef stu_H
#define stu_H
 
#include <iostream>
#include <string>
 
class unit.h;
 
class student
{
      public:
          student() {id=""; units.resize(1);};
          void setID(string name);
          string getID() const;
          void addUnit(*unit);
          void printUnits() const;
 
      private:
              string id;
              vector<unit *> units;
}
 
#endif
 

any hints are much appreciated. Thank you in advance
Salty

Shouldn't there be an #endif at the end of the school.h?

[Saltydog]

yeah there is one, I just didnt copy that far down soz :S

[Saltydog]

...bump.....

plz anyone?

[gpraghuram]

...bump.....

plz anyone?

What is this declaration above class student
class unit.h;
i think u shuld have using unit;

Raghuram

[Banfa]

In student.h

class unit.h;

should be

class unit;