Problem implementing an object factory

[Stephen Torri]

Here is my attempt at implementing a object factory. The purpose of this
is to replace a large switch statement in a factory class with the
functors. I get an error at line 88, marked, "expected primary-expression
before ')' token". I am using Modern C++ Design chapter 8 as a guide.

Stephen

---------------------

#include <map>
#include <iostream>

namespace tool
{
namespace component
{
class Component;
}

namespace infrastructure
{

class Component_Facto ry
{
public:
typedef component::Comp onent* (*CreateCompone ntCallback)();

bool RegisterCompone nt ( int component_id,
CreateComponent Callback call_func )
{
return m_callbacks.ins ert ( CallbackMap::va lue_type ( component_id,
call_func ) ).second;
}

bool UnregisterCompo nent ( int component_id ) {
return m_callbacks.era se ( component_id ) == 1;
}

component::Comp onent* CreateComponent ( int component_id ) {
CallbackMap::co nst_iterator pos = m_callbacks.fin d ( component_id );

if ( pos == m_callbacks.end () )
{
std::cerr << "Unknown Component ID" << std::endl; abort();
}

return (pos->second)();
}

private:
typedef std::map<int, CreateComponent CallbackCallbac kMap;

CallbackMap m_callbacks;
};

}

namespace component
{
class Component
{};
class Apple : public Component
{
public:

static const int ID = 1;

Component* operator()()
{
return new Apple;
}
};

class Blueberry : public Component
{
public:

static const int ID = 5;

Component* operator()()
{
return new Blueberry;
}
};
}
}
int main (int, char**)
{
tool::infrastru cture::Componen t_Factory fact_ref;

/* LINE 88 */
fact_ref.Regist erComponent ( tool::component ::Apple::ID,
tool::component ::Apple );

fact_ref.Unregi sterComponent ( tool::component ::Apple::ID );

return 0;
}

[Barry]

Stephen Torri wrote:

Here is my attempt at implementing a object factory. The purpose of this
is to replace a large switch statement in a factory class with the
functors. I get an error at line 88, marked, "expected primary-expression
before ')' token". I am using Modern C++ Design chapter 8 as a guide.

Stephen

---------------------

#include <map>
#include <iostream>

namespace tool
{
namespace component
{
class Component;
}

namespace infrastructure
{

class Component_Facto ry
{
public:
typedef component::Comp onent* (*CreateCompone ntCallback)();

bool RegisterCompone nt ( int component_id,
CreateComponent Callback call_func )
{
return m_callbacks.ins ert ( CallbackMap::va lue_type ( component_id,
call_func ) ).second;
}

bool UnregisterCompo nent ( int component_id ) {
return m_callbacks.era se ( component_id ) == 1;
}

component::Comp onent* CreateComponent ( int component_id ) {
CallbackMap::co nst_iterator pos = m_callbacks.fin d ( component_id );

if ( pos == m_callbacks.end () )
{
std::cerr << "Unknown Component ID" << std::endl; abort();
}

return (pos->second)();
}

private:
typedef std::map<int, CreateComponent CallbackCallbac kMap;

CallbackMap m_callbacks;
};

}

namespace component
{
class Component
{};
class Apple : public Component
{
public:

static const int ID = 1;

Component* operator()()
{
return new Apple;
}
};

class Blueberry : public Component
{
public:

static const int ID = 5;

Component* operator()()
{
return new Blueberry;
}
};
}
}
int main (int, char**)
{
tool::infrastru cture::Componen t_Factory fact_ref;

/* LINE 88 */
fact_ref.Regist erComponent ( tool::component ::Apple::ID,
tool::component ::Apple );

the second param of Registercompone nt is typeof
typedef component::Comp onent* (*CreateCompone ntCallback)();
which is a free function.
now you trying to assign it with a class type, which is never valid
anywhere to use type as a function actual parameter.

so a quick and simple change is

class Apple : public Component
{
public:

static const int ID = 1;

Component* operator()()

static Component* Create() // factory method

{
return new Apple;
}
};

fact_ref.Regist erComponent ( tool::component ::Apple::ID,
tool::component ::Apple );

fact_ref.Regist erComponent ( tool::component ::Apple::ID,
&tool::componen t::Apple::Creat e );

>
fact_ref.Unregi sterComponent ( tool::component ::Apple::ID );

return 0;
}

--
Thanks
Barry

[Stephen Torri]

On Sat, 08 Sep 2007 11:15:25 +0800, Barry wrote:

>

>int main (int, char**)
{
tool::infrastru cture::Componen t_Factory fact_ref;

/* LINE 88 */
fact_ref.Regist erComponent ( tool::component ::Apple::ID,
tool::component ::Apple );

the second param of Registercompone nt is typeof typedef
component::Comp onent* (*CreateCompone ntCallback)(); which is a free
function.
now you trying to assign it with a class type, which is never valid
anywhere to use type as a function actual parameter.

Thanks.

Is there a way to have each class that will be a part of a object factory automatically register itself?

Stephen

[Barry]

Stephen Torri wrote:

On Sat, 08 Sep 2007 11:15:25 +0800, Barry wrote:

>>int main (int, char**)
{
tool::infrastru cture::Componen t_Factory fact_ref;

/* LINE 88 */
fact_ref.Regist erComponent ( tool::component ::Apple::ID,
tool::component ::Apple );

the second param of Registercompone nt is typeof typedef
component::Com ponent* (*CreateCompone ntCallback)(); which is a free
function.
now you trying to assign it with a class type, which is never valid
anywhere to use type as a function actual parameter.

Thanks.

Is there a way to have each class that will be a part of a object factory automatically register itself?

it depends on how you define "automatically" ,
if you meant register as you write the class, I think there's not.
if you meant easier registering, maybe you can apply macro, then you can
write less code, but since your code is not so complicated and the
reg/unreg is clean and easy to use, moreover, the macro is so notorious,
so don't fix it if it ain't broken.

--
Thanks
Barry