error: expected ')' before '*' token -- What is this ?

[Ram Prasad]

I am trying to write a simple libspf2 plugin code for my postfix
( milter)
I am getting this unhelpful error message when I try to compile

gcc -g1 -Wall -I/usr/local/include/spf2 -I. -c mfunc.c
In file included from mfunc.c:1:
mfunc.c:42: error: expected ')' before '*' token
make: *** [mfunc.o] Error 1

my mfunc.c has on the line 42
-----------------------
.. . . . .
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {
SPF_response_t *spf_response = NULL;
SPF_result_t t;
SPF_request_set _ipv4_str( ecm_spf_request , ip );
SPF_request_set _helo_dom( ecm_spf_request , helo );
SPF_request_set _env_from( ecm_spf_request , sender );
SPF_request_que ry_mailfrom(ecm _spf_request, &spf_respons e);
t = SPF_response_re sult(spf_respon se);
SPF_response_fr ee(spf_response );
return t;
}

.. . . . .


So what could be the error ?
Thanks
Ram

PS:
Note to Spammers: Go ahead , send me spam
ra*@netcore.co. in
http://ecm.netcore.co.in/spamtrap.html

[Richard]

Ram Prasad <ra**********@g mail.comwrites:

I am trying to write a simple libspf2 plugin code for my postfix
( milter)
I am getting this unhelpful error message when I try to compile

gcc -g1 -Wall -I/usr/local/include/spf2 -I. -c mfunc.c
In file included from mfunc.c:1:
mfunc.c:42: error: expected ')' before '*' token
make: *** [mfunc.o] Error 1

my mfunc.c has on the line 42
-----------------------
. . . . .
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {
SPF_response_t *spf_response = NULL;
SPF_result_t t;
SPF_request_set _ipv4_str( ecm_spf_request , ip );
SPF_request_set _helo_dom( ecm_spf_request , helo );
SPF_request_set _env_from( ecm_spf_request , sender );
SPF_request_que ry_mailfrom(ecm _spf_request, &spf_respons e);
t = SPF_response_re sult(spf_respon se);
SPF_response_fr ee(spf_response );
return t;
}

. . . . .


So what could be the error ?

Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

[Ram Prasad]

>

Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
----
#include "mdef.h"
FILE* LOGFILE;


/*
* Opens file ( /var/log/milter.log ) for debug log
* any milter code can print to log file using addlog function
*/
void opendbglog(void ){
LOGFILE=NULL;
LOGFILE=fopen(L OGFILENAME,"a") ;
if(LOGFILE==NUL L){
fprintf(stderr, "Couldnot open logfile\n");
exit(1);
}
fprintf(LOGFILE ,"opened logfile\n");
setvbuf(LOGFILE , (char *)NULL, _IONBF, 0);
}

/*
* Debug function
* using va_args for number of args
*
* usage addlog(number_o f_arguments,arg 1,arg2,arg3,arg 4...)
*/

void addlog(int num_args, ... ) {
va_list ap;
if(LOGFILE == NULL ) return;
va_start(ap,num _args);
while(num_args--) fprintf(LOGFILE ," %s ", va_arg(ap,char* ));
va_end(ap);
fprintf(LOGFILE ,"\n");
return;
}
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {
SPF_response_t *spf_response = NULL;
SPF_result_t t;
SPF_request_set _ipv4_str( ecm_spf_request , ip );
SPF_request_set _helo_dom( ecm_spf_request , helo );
SPF_request_set _env_from( ecm_spf_request , sender );
SPF_request_que ry_mailfrom(ecm _spf_request, &spf_respons e);
t = SPF_response_re sult(spf_respon se);
SPF_response_fr ee(spf_response );
return t;
}

[Richard]

Ram Prasad <ra**********@g mail.comwrites:

>>
Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
----

*snip*

I loaded into a syntax hilited editor and saw no obvious syntax errors -
I cant see anything manually despite a quick scan, I guess there might
be troubles in mdef.h where I assume you are including <stdio.hamong st
other things. Without it one cant really tell.

Try commenting blocks out and then reinstating them to pinpoint the
error.

[santosh]

Ram Prasad wrote:

Please don't remove attribution lines.
[Richard wrote]

>Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
----
#include "mdef.h"
FILE* LOGFILE;

It idiomatic in C to reserve all uppercase names for macros.

/*
* Opens file ( /var/log/milter.log ) for debug log
* any milter code can print to log file using addlog function
*/
void opendbglog(void ){
LOGFILE=NULL;
LOGFILE=fopen(L OGFILENAME,"a") ;
if(LOGFILE==NUL L){
fprintf(stderr, "Couldnot open logfile\n");
exit(1);
}
fprintf(LOGFILE ,"opened logfile\n");
setvbuf(LOGFILE , (char *)NULL, _IONBF, 0);

The cast is not needed.

}

/*
* Debug function
* using va_args for number of args
* usage addlog(number_o f_arguments,arg 1,arg2,arg3,arg 4...)
*/
void addlog(int num_args, ... ) {
va_list ap;
if(LOGFILE == NULL ) return;
va_start(ap,num _args);
while(num_args--) fprintf(LOGFILE ," %s ", va_arg(ap,char* ));
va_end(ap);
fprintf(LOGFILE ,"\n");
return;
}

SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {
SPF_response_t *spf_response = NULL;
SPF_result_t t;
SPF_request_set _ipv4_str( ecm_spf_request , ip );
SPF_request_set _helo_dom( ecm_spf_request , helo );
SPF_request_set _env_from( ecm_spf_request , sender );
SPF_request_que ry_mailfrom(ecm _spf_request, &spf_respons e);
t = SPF_response_re sult(spf_respon se);
SPF_response_fr ee(spf_response );
return t;
}

We'll need to see the definitions for SPF_*_t types. I can't spot anything
amiss, just looking at the above code.

[Eric Sosman]

Ram Prasad wrote:

>Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
[...]
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {

Just a guess: Does the header file (which you didn't show)
declare a type named `SPF_request_t' , or does it declare something
slightly different like `SPF_Request_t' or `SPF_request'? (Or
does it declare `struct SPF_request_t' but not `SPF_request_t' ?)

--
Eric Sosman
es*****@ieee-dot-org.invalid

[Ram Prasad]

On Jul 31, 5:25 pm, Eric Sosman <[e-mail] e:

Ram Prasad wrote:

Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
[...]
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {

Just a guess: Does the header file (which you didn't show)
declare a type named `SPF_request_t' , or does it declare something
slightly different like `SPF_Request_t' or `SPF_request'? (Or
does it declare `struct SPF_request_t' but not `SPF_request_t' ?)

--
Eric Sosman
[e-mail]

I am not much of a cprogrammer myself , ( been doing perl all this
while)
But I am willing to improve

Here you go, this is my mdef.h sorry for not posting all src code in
first place.
The spf header files come from standard libspf2-devel rpm

-------
#ifndef MDEF_H
#include "milterconfig.h "
#define MDEF_H 1
#include "milterconfig.h "

#include <time.h>
#include <errno.h>
#include <getopt.h>
#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
#include <string.h>
#include <sysexits.h>
#include <stdarg.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <syslog.h>
#include <regex.h/* Provides regular expression matching */
#include <strings.h/* String utillity functions */
#include <libmilter/mfapi.h>
#include <netinet/in.h>
# include <inttypes.h>
# include <string.h> /* strstr / strdup */
# include <sys/socket.h /* inet_ functions / structs */
# include <netinet/in.h /* inet_ functions / structs */
# include <arpa/inet.h> /* in_addr struct */
# include <unistd.h>
# include <spf.h>

#ifndef true
# define false 0
# define true 1
#endif /* ! true */

struct blist {
char *key;
};
typedef struct blist bl;
struct ecm_list_stru {
int count;
bl *list;
};

typedef struct ecm_list_stru ecml;

#define BLACKLIST_FILE "blacklist. txt"
/* Global functions */
void opendbglog(void );
void addlog(int num_args, ... ) ;
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t,char* ip, char*
helo, char* sender);
int compbl(const void *m1, const void *m2);
int init_ecml(ecml* el,char *filename);
int searchlist(ecml el,char *needle);
/* All definitions here */
#define LOGFILENAME "/var/log/milter.log"
#define MLOGLEVEL 5 /* level of error logs generation
0-5 */
#define MAXFROMSIZE 200
#define SAMPLE 1
/* some std structures */
struct mlfiPriv
{
#ifdef SAMPLE
char *mlfi_fname;
FILE *mlfi_fp;
#endif
#ifdef SPFCHECK
char mfrom[MAXFROMSIZE];
#endif
};

#define MLFIPRIV ((struct mlfiPriv *) smfi_getpriv(ct x))
#endif

[Lew Pitcher]

On Jul 31, 6:31 am, Ram Prasad <ramprasad...@g mail.comwrote:

I am trying to write a simple libspf2 plugin code for my postfix
( milter)
I am getting this unhelpful error message when I try to compile

gcc -g1 -Wall -I/usr/local/include/spf2 -I. -c mfunc.c
In file included from mfunc.c:1:
mfunc.c:42: error: expected ')' before '*' token
make: *** [mfunc.o] Error 1

my mfunc.c has on the line 42
-----------------------
. . . . .
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {
SPF_response_t *spf_response = NULL;
SPF_result_t t;
SPF_request_set _ipv4_str( ecm_spf_request , ip );
SPF_request_set _helo_dom( ecm_spf_request , helo );
SPF_request_set _env_from( ecm_spf_request , sender );
SPF_request_que ry_mailfrom(ecm _spf_request, &spf_respons e);
t = SPF_response_re sult(spf_respon se);
SPF_response_fr ee(spf_response );
return t;

}

. . . . .

So what could be the error ?

Well, the message says that the syntax error occurred
In file included from mfunc.c:1
which (in a later post) appears to be your
#include "mdef.h"

Otherwise, your code does not appear to contain any syntax errors that
would be detected and reported as
mfunc.c:42: error: expected ')' before '*' token
so I'm guessing that your mdef.h header has the syntax error.

HTH
--
Lew

[santosh]

Ram Prasad wrote:

On Jul 31, 5:25 pm, Eric Sosman <[e-mail] e:

>Ram Prasad wrote:

>Post all the code in that file and then "line 42" will be in context.
It isn't even apparent from above what IS on line 42. "----"? ". . .
"? or SPF_ ?

The file is here
[...]
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {

Just a guess: Does the header file (which you didn't show)
declare a type named `SPF_request_t' , or does it declare something
slightly different like `SPF_Request_t' or `SPF_request'? (Or
does it declare `struct SPF_request_t' but not `SPF_request_t' ?)

>
I am not much of a cprogrammer myself , ( been doing perl all this
while) But I am willing to improve

Here you go, this is my mdef.h sorry for not posting all src code in
first place. The spf header files come from standard libspf2-devel rpm

<snip header>

We still need the definitions for all the SPF_*_t types, particularly,
SPF_result_t and SPF_request_t.

[Richard]

Ram Prasad <ra**********@g mail.comwrites:

On Jul 31, 5:25 pm, Eric Sosman <[e-mail] e:

>Ram Prasad wrote:

>Post all the code in that file and then "line 42" will be in context. It
isn't even apparent from above what IS on line 42. "----"? ". . . "? or
SPF_ ?

The file is here
[...]
SPF_result_t spfcheck_s(SPF_ request_t *ecm_spf_reques t, char* ip,
char* helo, char* sender) {

Just a guess: Does the header file (which you didn't show)
declare a type named `SPF_request_t' , or does it declare something
slightly different like `SPF_Request_t' or `SPF_request'? (Or
does it declare `struct SPF_request_t' but not `SPF_request_t' ?)

--
Eric Sosman
[e-mail]

I am not much of a cprogrammer myself , ( been doing perl all this
while)
But I am willing to improve

Here you go, this is my mdef.h sorry for not posting all src code in
first place.

And you still haven't. There are other includes that people here
probably wont have. milterconfig.h for a start.

I suspect it would be quicker for you to comment/uncomment bit by bit to
find your error yourself.

btw, you include milterconfig.h twice for some reason.