char pointers?

[mdh]

In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
int main () {

f();

return 0;
}

void f(void) {
char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r','l ','d','\0'}};
f_output(matrix , 10);
}
void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

Desired output: "Hello world"
Actual output:

hello
ello
llo
lo
o

world
orld
rld
ld
My naive way of looking at this was to assume that the declaration

"void f_output(char arg1[6], int limit)"

would "tell" the pointer that the type was an array of 6 chars, hence s
++ would increment to matrix[2]. I understand this is a totally
useless and pointless function, except in trying to further my
understanding.. .so please go easy!!! :-)

[Walter Roberson]

In article <11************ **********@b75g 2000hsg.googleg roups.com>,
mdh <md**@comcast.n etwrote:

>In trying to understand the issue, I wrote this;

>void f_output(char arg1[6], int limit);

>void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

You have a disagreement between the function declaration
and the function definition. In one place you used char arg1[6]
and in the other place you used char *s -- array vs pointer.

--
There are some ideas so wrong that only a very intelligent person
could believe in them. -- George Orwell

[Ian Collins]

mdh wrote:

In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
int main () {

f();

Where's the prototype for f()?

return 0;
}

void f(void) {
char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r','l ','d','\0'}};
f_output(matrix , 10);
}
void f_output(char *s, int limit) {

Head the warning your compiler should have given you here - this doesn't
match the prototype.

--
Ian Collins.

[Eric Sosman]

Ian Collins wrote On 04/11/07 17:37,:

mdh wrote:

>>In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
[...]

void f_output(char *s, int limit) {

Head the warning your compiler should have given you here - this doesn't
match the prototype.

As far as I can see, the definition and declaration
match perfectly. Yet both you and Walter Roberson say
they disagree ... In light of 6.3.5.7p7

A declaration of a parameter as "array of /type/"
shall be adjusted to "qualified pointer to /type/"
[...]

.... could one or both of you explain the disagreement?

To the O.P.: Questions 6.21 and 6.4 in the comp.lang.c
Frequently Asked Questions (FAQ) at http://www.c-faq.com/
may help your understanding.

--
Er*********@sun .com

[Jonas]

"mdh" <md**@comcast.n etwrote in message
news:11******** **************@ b75g2000hsg.goo glegroups.com.. .

In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
int main () {

f();

return 0;
}

void f(void) {
char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r','l ','d','\0'}};

What's wrong with

char matrix[2][6] ={ "hello", "world" };

?

f_output(matrix , 10);

If you want f_output to output the entire matrix, it should be declared as
(also improving the names a bit)

void f_output(char string_list[][6], int count);

and called with

f_output(matrix , 2);

}
void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

With the above declaration,

void f_output(char string_list[][6], int count)
{
int i;
for (i = 0; i < count; i++) {
printf("%s\n", (char*)string_l ist++);
}
}

Of course, a more normal way to achieve this would be
printf("%s\n", string_list[i]);

>
My naive way of looking at this was to assume that the declaration

"void f_output(char arg1[6], int limit)"

would "tell" the pointer that the type was an array of 6 chars, hence s
++ would increment to matrix[2]. I understand this is a totally
useless and pointless function, except in trying to further my
understanding.. .so please go easy!!! :-)

With the argument char arg[6], the increment "arg++" would work on the
pointer to char value of the address to the first element in the array arg,
and arg will point to the next char in the array.

With the argument char arg[][6], the increment "arg++" would work on the
pointer to char[6] value of the address to the first element in the array
arg, and arg will point to the next char array in the array of arrays.

--
Jonas

[Default User]

Walter Roberson wrote:

In article <11************ **********@b75g 2000hsg.googleg roups.com>,
mdh <md**@comcast.n etwrote:

In trying to understand the issue, I wrote this;

void f_output(char arg1[6], int limit);

void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

You have a disagreement between the function declaration
and the function definition. In one place you used char arg1[6]
and in the other place you used char *s -- array vs pointer.

Those are the same thing. The 6 is ignored.


Brian

[Default User]

mdh wrote:

In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
int main () {

f();

return 0;
}

void f(void) {
char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r','l ','d','\0'}};
f_output(matrix , 10);
}
void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

Desired output: "Hello world"
Actual output:

hello
ello
llo
lo
o

world
orld
rld
ld
My naive way of looking at this was to assume that the declaration

"void f_output(char arg1[6], int limit)"

would "tell" the pointer that the type was an array of 6 chars, hence
s ++ would increment to matrix[2]. I understand this is a totally
useless and pointless function, except in trying to further my
understanding.. .so please go easy!!! :-)

I recommend that you stop naively assuming things and read your text
and/or the FAQs. You don't have an array definition there, as you can't
have array parameters. Arrays are converted to a pointer to the first
element of the array.

These are all the same:

void f(char *s);
void f(char s[]);
void f(char s[6]);

You should have received a diagnostic for passing s to that function,
as it's the wrong type. Here's what I got:

d:\arp\main.c(5 ) : warning C4013: 'f' undefined; assuming extern
returning int
d:\arp\main.c(1 0) : error C2371: 'f' : redefinition; different basic
types
d:\arp\main.c(1 3) : warning C4047: 'function' : 'char *' differs in
levels of indirection from 'char [2][6]'
d:\arp\main.c(1 3) : warning C4024: 'f_output' : different types for
formal and actual parameter 1

[Peter Nilsson]

"mdh" <m...@comcast.n etwrote:

In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);

>From a style point of view, the following is more consistent...

void f_output(char arg1[], int limit);

int main () {

f();

In C90, f is implicitly declared as int f(). In C99, this
violates a constraint (because f does not have a type since
it was never declared.)

return 0;

}

void f(void) {

This conflicts with the previous implicit declaration as it has
a void return type. The behaviour of the call to f in main() is
undefined.

char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r','l ','d','\0'}};

Simpler is...

char matrix[][6] = { "Hello", "World" };

f_output(matrix , 10);

This requires a diagnostic since matrix will decay to a pointer
to its first element. Thus it is equivalent to &matrix[0] which
has type char[6]. But that type is incompatible with the parameter
which has type char * (not char []).

}

void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

Desired output: "Hello world"
Actual output:

<snip>

No C implementation is required to accept this program.
Turn up the warning levels and work on correct programs. It is
dangerous to try and learn from ill formed programs.

My naive way of looking at this was to assume that the declaration

"void f_output(char arg1[6], int limit)"

would "tell" the pointer that the type was an array of 6 chars,

Nope. This is a quirk of C. It is not possible to pass or return
arrays by value. A parameter declaration of type array will be
implicitly treated as a pointer to its element type.

As Eric mentions, the clc FAQ is worth reading.

hence s++ would increment to matrix[2].

If you believed that, why did you intent to increment s 10 times
when you know there are only 2 elements in matrix?

I understand this is a totally useless and pointless function,
except in trying to further my understanding.. .so please go
easy!!! :-)

Don't try to learn C by naive experimentation . Replicate samples
that are known to work. Explore what you _can_ do, not what you
think _might_ work.

--
Peter

[mdh]

Thank you all for replying.

[Barry Schwarz]

On 11 Apr 2007 14:26:51 -0700, "mdh" <md**@comcast.n etwrote:

>In trying to understand the issue, I wrote this;

#include <stdio.h>
void f_output(char arg1[6], int limit);
int main () {

f();

return 0;
}

void f(void) {
char matrix[2][6] ={ {'h','e','l','l ','o','\0'},
{'w','o','r',' l','d','\0'}};
f_output(matri x, 10);

Did your compiler not produce a diagnostic here. The first argument
to f_output must be of type char* to satisfy both the prototype above
and the actual definition below. Your are passing an argument of type
char (*)[6]. They are incompatible types. My recommendation is to
define the arguments in both places as
(char arg1[2][6], int limit)

>}
void f_output(char *s, int limit) {
int x, i;
for (i=0; i < limit; i++)
printf("%s\n", s++);

}

Desired output: "Hello world"
Actual output:

hello
ello
llo
lo
o

world
orld
rld
ld

Since you invoke undefined behavior, any output or no output would
correct.

>

My naive way of looking at this was to assume that the declaration

"void f_output(char arg1[6], int limit)"

Naive and incorrect. When an array is passed to a function, the
actual argument is a pointer to the first element of the array. That
is why it is OK for your prototype to have char arg1[6] while your
function definition has char *s. And you should have no trouble
figuring out what s++ will do when s is a char*.

>
would "tell" the pointer that the type was an array of 6 chars, hence s
++ would increment to matrix[2]. I understand this is a totally
useless and pointless function, except in trying to further my
understanding. ..so please go easy!!! :-)

Remove del for email