Function Declaration and Defintion Problem

[Amit_Basnak]

Dear Friends

I am giving the following command to build the server executableon
HP-UX
/opt/aCC/bin/aCC -o SOAPServer SOAPServer.o WFWuListService .o
WFWuListImpl.o WFWuListStructs .o WFWuList.o
-I/opt/systinet/server_cpp65/include/ -I../.. +DD64
/opt/systinet/server_cpp65/lib/libwasp.sl
/opt/systinet/server_cpp65/lib/libwasp_stl.sl -ldcekt -lpthread

and Im getting the following error
ld: Unsatisfied symbol "WF_ListWuC lnt" in file WFWuListService .o
1 errors.
Which means WFWuListService .cpp, especially the spelling and definition
of WF_ListWuClnt needs to be checked .

My header file WFWuMYList1.h has the prototype declaration of
WF_ListWuClnt function which is

long WF_ListWuClnt (
unsigned char *process_id,
unsigned char *process_step_i d,
unsigned char *cluster_id,
WF_STRUCT_SEARC H *search_params,
char incl_active_wu,
int nbr_requested,
WF_LIST_WORKUNI T_P_FE *workunit_array
);

and in WFWuListService .cpp

I have
------------------------------------------------------------------------------------------------------------------------------------------
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
#include <sys/time.h>
#include "WFWuListServic e.h" // WFWuList Systinet service
declarations

#include "WFWuMYList 1.h"
WFWuStructFe WFWuStructDceTo Soap(WF_STRUCT_ WORKUNIT_FE dceStruct) {

// define WFWuStructFe
WFWuStructFe wuStructFe;
WFWuHandle wuHandle;

wuHandle->workunit_id = 5;
wuHandle->workunit_seq = 10;
wuHandle->updateSerial_n um = 12;

wuStructFe->wf_workunit_ha ndle = wuHandle;

wuStructFe->ap_batch_id = "12";
wuStructFe->ap_bene_base_n um = "12";
wuStructFe->ap_customer_na me = "Amit" ;
wuStructFe->ap_customer_nu m = "0400034";
return wuStructFe;
}
ArrayOfWFWuStru ctFe WFWuListService ::WfListWuClnt( ::WFWuHandle &
handle, const WASP_STD_NS::st ring & process_id, const
WASP_STD_NS::st ring & process_step_id , const WASP_STD_NS::st ring &
cluster_id, ::WFStructSearc h & search_params, const WASP_STD_NS::st ring
& incl_active_wu, int nbr_requested) {

// Array of workunit structures to return
ArrayOfWFWuStru ctFe wuList;

// time structures to capture the lapsed time for RPC call
struct timeval first,
second,
lapsed;
struct timezone tzp;

long tResult = 0;
char process_id_[7];
char process_step_id _[7];
char cluster_id_[4];
char incl_active_wu_ = 'Y' ;
int nbr_requested_;

strcpy((char*)p rocess_id_, (char*)process_ id.c_str() );
process_id_[6]='\0';
strcpy((char*)p rocess_step_id_ , (char*)process_ step_id.c_str() );
process_step_id _[6]='\0';
strcpy((char*)c luster_id_, (char*)cluster_ id.c_str());
cluster_id_[3]='\0';
nbr_requested_ = nbr_requested;

WF_STRUCT_SEARC H wf_struct_searc h_d ;
memset((void*)& wf_struct_searc h_d, '\0', sizeof(WF_STRUC T_SEARCH));

//***** Populate the WF_STRUCT_SEARC H ******

wf_struct_searc h_d.workunit_ha ndle.workunit_i d =
search_params->workunit_handl e->workunit_id;
wf_struct_searc h_d.workunit_ha ndle.workunit_s eq =
search_params->workunit_handl e->workunit_seq ;
wf_struct_searc h_d.workunit_ha ndle.update_ser ial_num =
search_params->workunit_handl e->updateSerial_n um;

strcpy((char*)w f_struct_search _d.prod_type,(c har*)search_par ams->prod_type.c_st r());

strcpy((char*)w f_struct_search _d.prod_sub_typ e,(char*)search _params->prod_sub_type. c_str());

strcpy((char*)w f_struct_search _d.opn_type,(ch ar*)search_para ms->opn_type.c_str ());

strcpy((char*)w f_struct_search _d.customer_num ,(char*)search_ params->customer_num.c _str());

strcpy((char*)w f_struct_search _d.bene_base_nu m,(char*)search _params->bene_base_num. c_str());

strcpy((char*)w f_struct_search _d.customer_ref _num,(char*)sea rch_params->customer_ref_n um.c_str());

WF_STRUCT_WORKU NIT_FE *pWufe = NULL;
WF_LIST_WORKUNI T_FE listWU;
memset((void*)& listWU, '\0' , sizeof(WF_LIST_ WORKUNIT_FE));
WF_LIST_WORKUNI T_P_FE ptrlistWU ;
ptrlistWU = &listWU;
gettimeofday(&f irst, &tzp);
tResult = WF_ListWuClnt(
wfm_binding_h,
(unsigned char*) (const char*) process_id_,
(unsigned char*) (const char*) process_step_id _,
(unsigned char*) (const char*) cluster_id_,
&wf_struct_sear ch_d,
incl_active_wu_ ,
nbr_requested_,
&ptrlistWU);
gettimeofday(&s econd, &tzp);
if (first.tv_usec second.tv_usec) {
second.tv_usec += 1000000;
second.tv_sec--;
}
lapsed.tv_usec = second.tv_usec - first.tv_usec;
lapsed.tv_sec = second.tv_sec - first.tv_sec;
// cout << "Lapsed time for DCE RPC call = " <<
lapsed.tv_sec*1 000 + lapsed.tv_usec/1000 << " msec." << endl;
int i = 0;
for (i = 0; i < ptrlistWU->nbr_Workunits_ fe; i++) {

wuList->wFWuStructFe.p ush_back(WFWuSt ructDceToSoap(p trlistWU->lst_Workunit_f e[i]));
}
free(ptrlistWU) ;
cout << "WFWuListServic e: Number of records = " <<
wuList->wFWuStructFe.s ize() << ", lapsed time = " << lapsed.tv_sec*1 000
+ lapsed.tv_usec/1000 << " msec." << endl;
return wuList;
}
}
------------------------------------------------------------------------------------------------------------------------------------------

Am Missing something yet

Thanks
Ronan

[Earl Purple]

Amit_Basnak wrote:

Am Missing something yet

Thanks
Ronan

A function body for WF_ListWuClnt perhaps, that has the same prototype
as the one in your header?
Or link in an external library that defines it.

[Salt_Peter]

Amit_Basnak wrote:

Dear Friends

I am giving the following command to build the server executableon
HP-UX
/opt/aCC/bin/aCC -o SOAPServer SOAPServer.o WFWuListService .o
WFWuListImpl.o WFWuListStructs .o WFWuList.o
-I/opt/systinet/server_cpp65/include/ -I../.. +DD64
/opt/systinet/server_cpp65/lib/libwasp.sl
/opt/systinet/server_cpp65/lib/libwasp_stl.sl -ldcekt -lpthread

and Im getting the following error
ld: Unsatisfied symbol "WF_ListWuC lnt" in file WFWuListService .o
1 errors.
Which means WFWuListService .cpp, especially the spelling and definition
of WF_ListWuClnt needs to be checked .

My header file WFWuMYList1.h has the prototype declaration of
WF_ListWuClnt function which is

long WF_ListWuClnt (
unsigned char *process_id,
unsigned char *process_step_i d,
unsigned char *cluster_id,
WF_STRUCT_SEARC H *search_params,
char incl_active_wu,
int nbr_requested,
WF_LIST_WORKUNI T_P_FE *workunit_array
);

and in WFWuListService .cpp

I have
------------------------------------------------------------------------------------------------------------------------------------------
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
#include <sys/time.h>
#include "WFWuListServic e.h" // WFWuList Systinet service
declarations

#include "WFWuMYList 1.h"
WFWuStructFe WFWuStructDceTo Soap(WF_STRUCT_ WORKUNIT_FE dceStruct) {

// define WFWuStructFe
WFWuStructFe wuStructFe;
WFWuHandle wuHandle;

wuHandle->workunit_id = 5;
wuHandle->workunit_seq = 10;
wuHandle->updateSerial_n um = 12;

wuStructFe->wf_workunit_ha ndle = wuHandle;

wuStructFe->ap_batch_id = "12";
wuStructFe->ap_bene_base_n um = "12";
wuStructFe->ap_customer_na me = "Amit" ;
wuStructFe->ap_customer_nu m = "0400034";
return wuStructFe;
}
ArrayOfWFWuStru ctFe WFWuListService ::WfListWuClnt( ::WFWuHandle &
handle, const WASP_STD_NS::st ring & process_id, const
WASP_STD_NS::st ring & process_step_id , const WASP_STD_NS::st ring &
cluster_id, ::WFStructSearc h & search_params, const WASP_STD_NS::st ring
& incl_active_wu, int nbr_requested) {

// Array of workunit structures to return
ArrayOfWFWuStru ctFe wuList;

// time structures to capture the lapsed time for RPC call
struct timeval first,
second,
lapsed;
struct timezone tzp;

long tResult = 0;
char process_id_[7];
char process_step_id _[7];
char cluster_id_[4];
char incl_active_wu_ = 'Y' ;
int nbr_requested_;

strcpy((char*)p rocess_id_, (char*)process_ id.c_str() );
process_id_[6]='\0';
strcpy((char*)p rocess_step_id_ , (char*)process_ step_id.c_str() );
process_step_id _[6]='\0';
strcpy((char*)c luster_id_, (char*)cluster_ id.c_str());
cluster_id_[3]='\0';
nbr_requested_ = nbr_requested;

WF_STRUCT_SEARC H wf_struct_searc h_d ;
memset((void*)& wf_struct_searc h_d, '\0', sizeof(WF_STRUC T_SEARCH));

//***** Populate the WF_STRUCT_SEARC H ******

wf_struct_searc h_d.workunit_ha ndle.workunit_i d =
search_params->workunit_handl e->workunit_id;
wf_struct_searc h_d.workunit_ha ndle.workunit_s eq =
search_params->workunit_handl e->workunit_seq ;
wf_struct_searc h_d.workunit_ha ndle.update_ser ial_num =
search_params->workunit_handl e->updateSerial_n um;

strcpy((char*)w f_struct_search _d.prod_type,(c har*)search_par ams->prod_type.c_st r());

strcpy((char*)w f_struct_search _d.prod_sub_typ e,(char*)search _params->prod_sub_type. c_str());

strcpy((char*)w f_struct_search _d.opn_type,(ch ar*)search_para ms->opn_type.c_str ());

strcpy((char*)w f_struct_search _d.customer_num ,(char*)search_ params->customer_num.c _str());

strcpy((char*)w f_struct_search _d.bene_base_nu m,(char*)search _params->bene_base_num. c_str());

strcpy((char*)w f_struct_search _d.customer_ref _num,(char*)sea rch_params->customer_ref_n um.c_str());

WF_STRUCT_WORKU NIT_FE *pWufe = NULL;
WF_LIST_WORKUNI T_FE listWU;
memset((void*)& listWU, '\0' , sizeof(WF_LIST_ WORKUNIT_FE));
WF_LIST_WORKUNI T_P_FE ptrlistWU ;
ptrlistWU = &listWU;
gettimeofday(&f irst, &tzp);
tResult = WF_ListWuClnt(
wfm_binding_h,
(unsigned char*) (const char*) process_id_,
(unsigned char*) (const char*) process_step_id _,
(unsigned char*) (const char*) cluster_id_,
&wf_struct_sear ch_d,
incl_active_wu_ ,
nbr_requested_,
&ptrlistWU);
gettimeofday(&s econd, &tzp);
if (first.tv_usec second.tv_usec) {
second.tv_usec += 1000000;
second.tv_sec--;
}
lapsed.tv_usec = second.tv_usec - first.tv_usec;
lapsed.tv_sec = second.tv_sec - first.tv_sec;
// cout << "Lapsed time for DCE RPC call = " <<
lapsed.tv_sec*1 000 + lapsed.tv_usec/1000 << " msec." << endl;
int i = 0;
for (i = 0; i < ptrlistWU->nbr_Workunits_ fe; i++) {

wuList->wFWuStructFe.p ush_back(WFWuSt ructDceToSoap(p trlistWU->lst_Workunit_f e[i]));
}
free(ptrlistWU) ;
cout << "WFWuListServic e: Number of records = " <<
wuList->wFWuStructFe.s ize() << ", lapsed time = " << lapsed.tv_sec*1 000
+ lapsed.tv_usec/1000 << " msec." << endl;
return wuList;
}
}
------------------------------------------------------------------------------------------------------------------------------------------

Am Missing something yet

Try programming in C++ instead. Otherwise ask your question in a C
newsgroup.
You have a declaration for long WF_ListWuClnt(. ..) but i don't see its
implementation.
Also,
a) pointers are evil, use references or const references instead
b) #include <string>, not <string.h>
c) #include <cstdlib>
d) #include <cstudio>

[Earl Purple]

Salt_Peter wrote:

>
Try programming in C++ instead. Otherwise ask your question in a C
newsgroup.

Well the code looks more like C with classes, but it certainly doesn't
pass
for pure C.

You have a declaration for long WF_ListWuClnt(. ..) but i don't see its
implementation.
Also,
a) pointers are evil, use references or const references instead

Pointers are not evil. However having to manage memory is evil. Use
smart-pointers,
use std::vector instead of arrays and std::string for string handling.

Use references instead of pointers when the pointer cannot be NULL or
change what
it points to. Use pointers when you need to initialise it later, eg
scoping:

Foo * ptrToAFoo;
if ( some_condition_ or_other )
{
ptrToAFoo = x;
}
else
{
ptrToAFoo = y;
}

and it might not be possible to use ? : notation in the above if it's
complex.

void function( const Foo & fooparam, Diagnostics * diagnostic_info =
NULL );

The above uses a const reference parameter and a non-const pointer
parameter.
The const reference must refer to a valid object. The pointer may be
NULL if the
caller doesn't want the function to write diagnostic information.

b) #include <string>, not <string.h>

The equivalent for <string.his <cstringbut it's true that most of
the time you won't
need the C string library functions. If you do then use <cstring>

c) #include <cstdlib>

Most of the time but I think there might be some POSIX functions in
<stdlib.hthat
are not in <cstdlib>. I certainly know there are some POSIX functions
that haven't
made it into the C++-equivalent header but I can't remember exactly
which ones.

d) #include <cstudio>

No, there is no 'u'. It is <cstdio>. Most of the time you won't need
this header though,
as you will be using iostream and equivalent instead.

[Amit_Basnak]

Earl Purple wrote:

Amit_Basnak wrote:

Am Missing something yet

Thanks
Ronan

A function body for WF_ListWuClnt perhaps, that has the same prototype
as the one in your header?
Or link in an external library that defines it.

Thanks Earl and Peter for your expert advice.
To give you more back ground , I am building a Server binary
usingSystinet Server for C++ .
Thanks for the information. The WF_ListWuClnt() function had
originally been usedwith DCE
DCE ( Distributed Computing Environment) calls which uses Interface
Definition language ( idl) . In WFClnt_dceOnlyR pc.h file this original
WF_ListWuClnt () call has been defined as below

extern AppReturnStatus WF_ListWuClnt(
#ifdef IDL_PROTOTYPES
/* [in] */ idl_char *process_id,
/* [in] */ idl_char *process_step_i d,
/* [in] */ idl_char *cluster_id,
/* [in] */ WF_STRUCT_SEARC H *search_params,
/* [in] */ idl_char incl_active_wu,
/* [in] */ idl_short_int nbr_requested,
/* [out] */ WF_LIST_WORKUNI T_P_FE *workunit_array ,
#endif
);

The modifying function I am writing with Systinet Server for C++ does
not use DCE and hence I converted WF_ListWuClnt () to normal C/C++
function type as

long WF_ListWuClnt (
unsigned char *process_id,
unsigned char
*process_step_i d,
unsigned char *cluster_id,
WF_STRUCT_SEARC H *search_params,
char
incl_active_wu,
int
nbr_requested,
WF_LIST_WORKUNI T_P_FE *workunit_array
);

and used as in my own header file WFWuMYList1.h which I included in
the WFWuListService .cpp . And its implementation is concerned , the
return of WF_ListWuClnt () oflong type has been stored in
tResult = WF_ListWuClnt(
wfm_binding_h,
(unsigned char*) (const char*) process_id_,
(unsigned char*) (const char*) process_step_id _,
(unsigned char*) (const char*) cluster_id_,
&wf_struct_sear ch_d,
incl_active_wu_ ,
nbr_requested_,
&ptrlistWU);
which is also in tResult.

While compiling with aCC under HP-Unix , I didnt get any error , The
error comes only while building the server executable and that too in
WFWuListService .o object file and as correctly pointed out by Earl that
link in an external library that defines it could be missing .
Thank you again for your time and the efforts that you put in this
question.
Please let me know whether the implementation of WF_ListWuClnt( )
as shown above is correct or needs to be modified .
Thanks
Amit

[Amit_Basnak]

Amit_Basnak wrote:

Earl Purple wrote:

Amit_Basnak wrote:

Am Missing something yet
>
Thanks
Ronan

A function body for WF_ListWuClnt perhaps, that has the same prototype
as the one in your header?
Or link in an external library that defines it.

Thanks Earl and Peter for your expert advice.
To give you more back ground , I am building a Server binary
usingSystinet Server for C++ .
Thanks for the information. The WF_ListWuClnt() function had
originally been usedwith DCE
DCE ( Distributed Computing Environment) calls which uses Interface
Definition language ( idl) . In WFClnt_dceOnlyR pc.h file this original
WF_ListWuClnt () call has been defined as below

extern AppReturnStatus WF_ListWuClnt(
#ifdef IDL_PROTOTYPES
/* [in] */ idl_char *process_id,
/* [in] */ idl_char *process_step_i d,
/* [in] */ idl_char *cluster_id,
/* [in] */ WF_STRUCT_SEARC H *search_params,
/* [in] */ idl_char incl_active_wu,
/* [in] */ idl_short_int nbr_requested,
/* [out] */ WF_LIST_WORKUNI T_P_FE *workunit_array ,
#endif
);

The modifying function I am writing with Systinet Server for C++ does
not use DCE and hence I converted WF_ListWuClnt () to normal C/C++
function type as

long WF_ListWuClnt (
unsigned char *process_id,
unsigned char
*process_step_i d,
unsigned char *cluster_id,
WF_STRUCT_SEARC H *search_params,
char
incl_active_wu,
int
nbr_requested,
WF_LIST_WORKUNI T_P_FE *workunit_array
);

and used as in my own header file WFWuMYList1.h which I included in
the WFWuListService .cpp . And its implementation is concerned , the
return of WF_ListWuClnt () oflong type has been stored in
tResult = WF_ListWuClnt(
wfm_binding_h,
(unsigned char*) (const char*) process_id_,
(unsigned char*) (const char*) process_step_id _,
(unsigned char*) (const char*) cluster_id_,
&wf_struct_sear ch_d,
incl_active_wu_ ,
nbr_requested_,
&ptrlistWU);
which is also in tResult.

While compiling with aCC under HP-Unix , I didnt get any error , The
error comes only while building the server executable and that too in
WFWuListService .o object file and as correctly pointed out by Earl that
link in an external library that defines it could be missing .
Thank you again for your time and the efforts that you put in this
question.
Please let me know whether the implementation of WF_ListWuClnt( )
as shown above is correct or needs to be modified .
Thanks
Amit

When I compiled with all WF_ListWuClnt( ) commented , It goes fine and
no error has been repored.

Thanks
Amit