my display so weird...

[nickyeng]

I have written 3 files, i dont know whether i do it correctly or wrongly but somehow it compiled well and can run.

My simple aim is to display the terrain.txt file into the terrain array, and then display terrain into screen.

I can't display the whitespace characters from terrain.txt file to screen.
and
It display "weird"( the red color part).

I tried searching one line by line, and i can't figure out which line has the problem.
here is my 3 file:

// screen.h
#ifndef _SCREEN_H_
#define _SCREEN_H_
#include <string>
#include <iostream>
#include <fstream>
#include <cstdlib>
#include "array2d.h"
 
namespace Game{
    using namespace std;
 
    class Screen{
        public:
 
        Screen(unsigned xsize = 80, unsigned ysize = 23): Xsize(xsize), Ysize(ysize), myArray(Xsize, Ysize){}
 
        ~Screen()
        {
        }
 
        //Insert a character into the screen image at a specified row and column.
        void Insert(unsigned x, unsigned y , char c){
                    myArray.Put(x,y,c);
        }
 
        void setStatus(string str){
            status = str;
        }
 
        /* clear the previous screen and display new screen image with Xsize Ysize */
        void Paint(){
 
            /* clear the screen */
            system("clear");
 
            // and then display the screen with width and height
            for(unsigned y = 0; y < Ysize; y++){
                for(unsigned x = 0; x < Xsize; x++){
                    cout << myArray.Get(x , y);
                }
            }
        }
 
        void Beep(){
            cout << '\a';
        }
        private:
        unsigned Xsize;
        unsigned Ysize;
        Array2D<char> myArray;
        string status;
    };
}
#endif
 

// terrain.h
#ifndef _TERRAIN_H_
#define _TERRAIN_H_
#include <iostream>
#include <fstream>
#include <string>
#include "array2d.h"
#include "screen.h"
 
namespace Game{
using namespace std;
 
    class Terrain{
 
        public:
 
            // constructor that will input the terrain from a specified file and store it
            // in dynamically allocated storage of an appropriate size.
 
                Terrain(char* filename =""): width(25) , height(11), ter_array(width, height){
 
 
                ifstream in(filename);
 
                if(!in){
                    cout << "Cannot open terrain file." << endl;
                }
 
                for(unsigned y = 0; y < height; y++){
                    for(unsigned x = 0; x < width; x++){
                        in >> piece;
                        ter_array.Put(x,y,piece);
                    }
                }
                in.close();
            };
 
            ~Terrain(){  }
 
            // draw the terrain onto a specified Screen object.
            void Draw(Screen& scr){
                for(unsigned y = 0; y < height; y++){
                    for(unsigned x = 0; x < width; x++){
                        scr.Insert(x, y, ter_array.Get(x,y));
                    }
                }
            }
 
        private:
 
            unsigned width;
            unsigned height;
 
            Array2D<char> ter_array;
            char piece;
 
    };
}
#endif
 

// array2d.h - Simple template class for a sparse 2D array
#ifndef _ARRAY2D_H_
#define _ARRAY2D_H_
#include "exception.h"
 
namespace Game {
 
    /*** Simple template class for a 2D Array ***/
    template<class T>
    class Array2D {
    public:
        Array2D(unsigned width, unsigned height) : xsize(width), ysize(height) {
            array = new T[xsize * ysize];
        }
        ~Array2D() { delete array; }
        void Put(unsigned x, unsigned y, T item) {
            if (x >= xsize || y >= ysize) {
                throw GameException("Array out of bounds");
            }
            array[y * xsize + x] = item;
        }
        T Get(unsigned x, unsigned y) const {
            if (x >= xsize || y >= ysize) {
                throw GameException("Array out of bounds");
            }
            return array[y * xsize + x];
        }
        void SetAll(T item) {
            for (unsigned i = 0; i < xsize * ysize; i++) {
                array[i] = item;
            }
        }
    private:
        const unsigned xsize;
        const unsigned ysize;
        T* array;
    };
}
#endif
 

here is the main.cpp i used:

#include <iostream>
#include <string>
#include "screen.h"
#include "array2d.h"
#include "terrain.h"
 
using namespace std;
using namespace Game;
 
// get terrain.txt from command line
int main(int argc, char* argv[]){
        Screen s;
        Terrain t(argv[1]);
 
        t.Draw(s);
        s.Paint();
 
    return 0;
}
 

[nickyeng]

Hi all,

i fix the whitespace problem, DeMan helped me out with that already.
get the whitespace using get().

So now leave the problem of that red color spot.
I think somehow the problem issued when i draw terrain to screen.

but still no idea about where's wrong. I'm looking at it now. Hope you guys can help me out too.

[nickyeng]

here is the code i been changing it for past 15 minutes.

// terrain.h
#ifndef _TERRAIN_H_
#define _TERRAIN_H_
#include <iostream>
#include <fstream>
#include <string>
#include "array2d.h"
#include "screen.h"
 
namespace Game{
using namespace std;
 
    class Terrain{
 
        public:
 
            // constructor that will input the terrain from a specified file and store it
            // in dynamically allocated storage of an appropriate size.
 
                Terrain(char* filename =""): width(25) , height(11), ter_array(width, height){
 
 
                ifstream in(filename);
 
                if(!in){
                    cout << "Cannot open terrain file." << endl;
                }
 
                for(unsigned y = 0; y < height; y++){
                    for(unsigned x = 0; x < width; x++){
                                piece = in.get();               // i get whitespace useing get()
                        ter_array.Put(x,y,piece);
                    }
                }
                in.close();
            };
 
            ~Terrain(){  }
 
            // draw the terrain onto a specified Screen object.
            void Draw(Screen& scr){
                for(unsigned y = 0; y < height; y++){
                    for(unsigned x = 0; x < width; x++){
                        scr.Insert(x, y, ter_array.Get(x,y));
                    }
                }
            }
 
        private:
 
            unsigned width;
            unsigned height;
 
            Array2D<char> ter_array;
            char piece;
 
    };
}
#endif
 

// screen.h
#ifndef _SCREEN_H_
#define _SCREEN_H_
#include <string>
#include <iostream>
#include <fstream>
#include <cstdlib>
#include "array2d.h"
 
namespace Game{
    using namespace std;
 
    class Screen{
        public:
 
        Screen(unsigned xsize = 79, unsigned ysize = 23): Xsize(xsize), Ysize(ysize), myArray(Xsize, Ysize){}
 
        ~Screen()
        {
        }
 
        //Insert a character into the screen image at a specified row and column.
        void Insert(unsigned x, unsigned y , char c){
                    myArray.Put(x,y,c);
        }
 
        void setStatus(string str){
            status = str;
        }
 
        /* clear the previous screen and display new screen image with Xsize Ysize */
        void Paint(){
 
            /* clear the screen */
            system("clear");
 
            // and then display the screen with width and height
            for(unsigned y = 0; y < Ysize; y++){
                for(unsigned x = 0; x < Xsize; x++){
                    cout << myArray.Get(x , y);
                }
            }
        }
 
        void Beep(){
            cout << '\a';
        }
        private:
        unsigned Xsize;
        unsigned Ysize;
        Array2D<char> myArray;
        string status;
    };
}
#endif
 

terrain.txt file:

+-----------------------+
|                       |
|              +-+--+ +-+
|                |      |
| +----+ +-------+      |
| |      |              |
| |  +---+    +         |
| |           |         |
| +-----+     +--+ +    |
|                  |    |
+------------------+----+
 

here is the output:

it seems that the last line of terrain.txt file is missing some part.
where's the wrong code anyway...?

thanks in advance.
Nick.

[Ganon11]

DId you make terrain.txt in a simple editor such as Notepad? There may be extra characters used for formatting if you used something 'fancier'...

[nickyeng]

DId you make terrain.txt in a simple editor such as Notepad? There may be extra characters used for formatting if you used something 'fancier'...

i used TextPad 4.7.3: 32-bit Edition to create the terrain.txt file.
I make sure there is no extra space in each end of line. The terrain should be 25 in columns and 11 in rows.

[nickyeng]

if the terrain.txt file is like this:

+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
 

it will display to screen like this:

[montzter]

if the terrain.txt file is like this:

+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
+++++++++++++++++++++++++
 

it will display to screen like this:

Hi,

I believe this is a problem with the X and Y coordinates with your screen which doesn't match with the widtch and height of what you are drawing. try lowering down the value of Xsize to 23 then Ysize to 11 in screen.h. Or try organizing your array well to match with the how big your screen is.

That's all thanks. Hope this helps.

[nickyeng]

Hi,

I believe this is a problem with the X and Y coordinates with your screen which doesn't match with the widtch and height of what you are drawing. try lowering down the value of Xsize to 23 then Ysize to 11 in screen.h. Or try organizing your array well to match with the how big your screen is.

That's all thanks. Hope this helps.

since you mentioned me, i change the code in game.cpp(the main function located), where i obtain the width and height of terrain array, and use them to initialise screen array with screen constructor.

it display well, but seems that last line of the terrain.txt file cannot be display.

i guess this code is the problem where it can't get all the characters from terrain text file.

    for(unsigned y = 0; y < height; y++){
                    for(unsigned x = 0; x < width; x++){
 
                        in.get(piece);
                        ter_array.Put(x,y,piece);
                    }
                }
 

[nickyeng]

i fixed the reading all character from file problem by setting the terrain array with 27 in width and 11 in height. With this setting, i can display all characters from terrain text file.

now my problem is, i dont know why i can draw the terrain array into screen object without calling t.Draw(s) as following. i set 80x23 of the screen and Paint() is to display the screen into cout. So if i didnt' call t.Draw(s), it should display 80x23 screen into cout.

Anyone please explain to me.

int main(int argc, char* argv[]){
 
        Terrain t(argv[1]);
 
        unsigned width = t.getWidth();
        unsigned height = t.getHeight();
 
        Screen s(width, height);
 
        //t.Draw(s);
        s.Paint();
 
    return 0;
}