fgetc/fpostc crashes with long filenames

[mariodr]

Hi! This is my first post on the web ever!

To make it short, I made a routine to change certain bytes in a file in binary mode. It all worked perfectly, until I decided to use a long name directory and it crashes. I made certain check points to find out exactly where it crashes and why. Here is my subroutine code:

void binary_edit (char *cur_dir) {
    FILE *fp,*fp2;
    char filename[100],filename2[100];
    int temp,cur_bit=0;
    sprintf(filename ,"%s\\file1.bin",cur_dir);
    sprintf(filename2,"%s\\file2.bin",cur_dir);
    fp=fopen(filename,"rb");
    fp2=fopen(filename2,"wb");
 
    temp=(int)fgetc(fp); //doesn't get here if filename=>41
    while (!feof(fp)) {
        switch (cur_bit) {
            case 50:fputc(0,fp2);break;
            case 51:fputc(1,fp2);break;
            case 52:fputc(2,fp2);break;
            case 53:fputc(3,fp2);break;
            case 54:fputc(4,fp2);break;
            case 55:fputc(5,fp2);break;
            default:fputc(temp,fp2);
        }
        temp=(int)fgetc(fp);
    }
 
     //doesn't get here if filename2=>39
    fclose(fp);
    fclose(fp2);
    unlink(filename);
    SleepEx(1000,false);
    rename(filename2,filename);
}
 

Thanking you in advance

Mario

[horace1]

the maximum path length should be defined by PATH_MAX in limits.h, see
http://www.opengroup.o rg/onlinepubs/009695399/functions/fopen.html

try the following program

/* display maximum path and file name length */
 
#include <stdio.h>
#include <limits.h>
 
int main()
{
       printf(" maximum path length %d ", PATH_MAX);
       printf(" maximum name length %d ", NAME_MAX);
       getchar();getchar();getchar();getchar();
       }
 
 

some compilers don't define NAME_MAX and some define neither of them