Help with code (parse error)

[BWIGLEY]

Basically I've just started making a game. So far it makes an array
25 by 20 and tries to make five rooms within it.
In scr_make_room() there's parse errors:
20 C:\c\Rooms\Unti tled1.c parse error before "top_x"
28 C:\c\Rooms\Unti tled1.c parse error before "first_square_x "
35 C:\c\Rooms\Unti tled1.c parse error before '}' token

Why are these happening?

int room_square[25][20], selected = 1, squares = 1, first_square_x
= -1, first_square_y = 1;
void scr_make_room(v oid) //Make a room
{
int top_x, roomx, top_y, roomy, xplus, yplus;

top_x = 8; //floor(random(21 ))+1 //Do this later when
roomx = 5; //floor(random(8) )+1 //I can use random()
top_y = 12; //floor(random(16 ))+1 // and floor()
roomy = 5; //floor(random(8) )+1

//Turn all the wall squares within the room to floor
for (xplus = 0; xplus < roomx; xplus++)
{
for (yplus = 0; yplus < roomy; xplus++)
{

// make sure it's in the room
20: if top_x + xplus < 24 && top_y + yplus < 19 //***PARSE
ERROR
{
if room_square[top_x+xplus][top_y+yplus] == 0 //if
there is wall
{
room_square[top_x+xplus][top_y+yplus] = 1; //make
it floor
squares+=1; //increase the number of squares made

//record the first square made(ever)
28: if first_square_x == -1 //***PARSE ERROR
{
first_square_x = top_x+xplus;
first_square_y = top_y+yplus;
}//endi
}//endi wall
}//endi in room
35: }//end for y //***PARSE ERROR
}//end for x
}//end scr_make_room()

int main()
{
int i, j;

for (i = 0; i < 25; i++)
{
for (j = 0; j < 20; i++)
{
room_square[i][j]=0;
}
}

for (i=0; i<5; i+=1) //make 5 rooms
{
scr_make_room() ;
}

return 0;
}

[Eric Sosman]

BWIGLEY wrote:

Basically I've just started making a game. So far it makes an array
25 by 20 and tries to make five rooms within it.
In scr_make_room() there's parse errors:
20 C:\c\Rooms\Unti tled1.c parse error before "top_x"
28 C:\c\Rooms\Unti tled1.c parse error before "first_square_x "
35 C:\c\Rooms\Unti tled1.c parse error before '}' token

Why are these happening?

Because you have omitted the parentheses in the if(...)
construct. They are not optional.

if (x < y) /* pass "Go," collect $200 */

if x < y /* go to jail. go directly to jail. */

--
Eric Sosman
es*****@acm-dot-org.invalid

[Robert Gamble]

BWIGLEY wrote:

Basically I've just started making a game. So far it makes an array
25 by 20 and tries to make five rooms within it.
In scr_make_room() there's parse errors:
20 C:\c\Rooms\Unti tled1.c parse error before "top_x"
28 C:\c\Rooms\Unti tled1.c parse error before "first_square_x "
35 C:\c\Rooms\Unti tled1.c parse error before '}' token

Why are these happening?

int room_square[25][20], selected = 1, squares = 1, first_square_x
= -1, first_square_y = 1;
void scr_make_room(v oid) //Make a room
{
int top_x, roomx, top_y, roomy, xplus, yplus;

top_x = 8; //floor(random(21 ))+1 //Do this later when
roomx = 5; //floor(random(8) )+1 //I can use random()
top_y = 12; //floor(random(16 ))+1 // and floor()
roomy = 5; //floor(random(8) )+1

//Turn all the wall squares within the room to floor
for (xplus = 0; xplus < roomx; xplus++)
{
for (yplus = 0; yplus < roomy; xplus++)
{

// make sure it's in the room
20: if top_x + xplus < 24 && top_y + yplus < 19 //***PARSE
ERROR

if (top_x + xplus < 24 && top_y + yplus < 19) /* You need the
parenthesis */

Robert Gamble

[BWIGLEY]

"Eric Sosman" <es*****@acm-dot-org.invalidwrot e in message
news:Me******** *************** *******@comcast .com...

BWIGLEY wrote:

Basically I've just started making a game. So far it makes an

array

25 by 20 and tries to make five rooms within it.
In scr_make_room() there's parse errors:
20 C:\c\Rooms\Unti tled1.c parse error before "top_x"
28 C:\c\Rooms\Unti tled1.c parse error before "first_square_x "
35 C:\c\Rooms\Unti tled1.c parse error before '}' token

Why are these happening?

Because you have omitted the parentheses in the if(...)
construct. They are not optional.

if (x < y) /* pass "Go," collect $200 */

if x < y /* go to jail. go directly to jail. */

Thanks. Anyone know why it crashes when I try to run it?

[BWIGLEY]

"BWIGLEY" <bw*****@ihug.c o.nzwrote in message
news:ef******** **@lust.ihug.co .nz...

"Eric Sosman" <es*****@acm-dot-org.invalidwrot e in message
news:Me******** *************** *******@comcast .com...

BWIGLEY wrote:

Basically I've just started making a game. So far it makes an

array

25 by 20 and tries to make five rooms within it.
In scr_make_room() there's parse errors:
20 C:\c\Rooms\Unti tled1.c parse error before "top_x"
28 C:\c\Rooms\Unti tled1.c parse error before "first_square_x "
35 C:\c\Rooms\Unti tled1.c parse error before '}' token
>
Why are these happening?

Because you have omitted the parentheses in the if(...)
construct. They are not optional.

if (x < y) /* pass "Go," collect $200 */

if x < y /* go to jail. go directly to jail. */

Thanks. Anyone know why it crashes when I try to run it?

OK, it's crashing because it's trying to put "0" in lots of memory in:

for (i = 0; i < 25; i++)
{
for (j = 0; j < 20; i++)
{
room_square[i][j]=0;
}
}

i just keeps going up. What's wrong with it.

[jmcgill]

BWIGLEY wrote:

Thanks. Anyone know why it crashes when I try to run it?

You are incrementing i when you mean to increment j.

[BWIGLEY]

"jmcgill" <jm*****@email. arizona.eduwrot e in message
news:gklTg.500$ rS.250@fed1read 05...

BWIGLEY wrote:

Thanks. Anyone know why it crashes when I try to run it?

You are incrementing i when you mean to increment j.

Oops. Thanks

[jmcgill]

BWIGLEY wrote:

Thanks. Anyone know why it crashes when I try to run it?

Fixed as far as I could understand it, attached.

[BWIGLEY]

"jmcgill" <jm*****@email. arizona.eduwrot e in message
news:OolTg.501$ rS.229@fed1read 05...

BWIGLEY wrote:

Thanks. Anyone know why it crashes when I try to run it?

Fixed as far as I could understand it, attached.

<snip re-formatted code>

Thanks, this is very much appreciated. From now on I think I'll
format my code like this.

I don't know if anyone can be bothered, but if someone could please
tell me how to use random() and floor() ( what to #include etc.) so I
can actually randomly generate a level (I've finished everything else
and it works nicely). I'll probably be able to find this, but they
aren't in the tutorials I've downloaded so far...

[jmcgill]

BWIGLEY wrote:

>>Thanks. Anyone know why it crashes when I try to run it?

Fixed as far as I could understand it, attached.

<snip re-formatted code>

Thanks, this is very much appreciated. From now on I think I'll
format my code like this.

I don't know if anyone can be bothered, but if someone could please
tell me how to use random()

random() is not standard C.

In standard C you get RAND_MAX which is at least 32767 (but probably is
the maximum int for your system), you get rand() which gives a random
int between [0 and RAND_MAX] inclusive, and a seed function,
void srand(unsigned int seed);

To get a double precision random number, you can do this, no guarantees
about the distribution or anything.

double r;
r=( ((double) rand()) / (double) (RAND_MAX) + (double)(1.0) );

(Personally, I've been using the random number generator from a crypto
library, not the standard function).

and floor()

floor() is in <math.h>