overloading >> operator

[Ashwin]

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;
s=a;
return in;
}
i have also tried using a[100] and then using in>>a;
but in both the cases if i enter a string it gives segmentation fault.
and if i enter a character it works properly. if i give more than one
character it gives segmentation fault.what is the reason for this plzz
explain.
thanks in advance.

[lallous]

Hello

"Ashwin" <as************ @gmail.comwrote in message
news:11******** *************@b 28g2000cwb.goog legroups.com...

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;
s=a;
return in;
}

Very bad code.
1. memory leaks
2. can buffer overflow

i have also tried using a[100] and then using in>>a;
but in both the cases if i enter a string it gives segmentation fault.
and if i enter a character it works properly. if i give more than one
character it gives segmentation fault.what is the reason for this plzz
explain.

Are you entering a string bigger than 100 characters?

Can't you trace your code and see where exactly the crash occurs?

--
Elias

[Ashwin]

lallous wrote:

Hello

"Ashwin" <as************ @gmail.comwrote in message
news:11******** *************@b 28g2000cwb.goog legroups.com...

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;
s=a;
return in;
}

Very bad code.
1. memory leaks
2. can buffer overflow

i have also tried using a[100] and then using in>>a;
but in both the cases if i enter a string it gives segmentation fault.
and if i enter a character it works properly. if i give more than one
character it gives segmentation fault.what is the reason for this plzz
explain.

Are you entering a string bigger than 100 characters?

Can't you trace your code and see where exactly the crash occurs?

--
Elias

thanks elias

can u explain me about memory leaks or give me any good links about
memory leak.i think there is a buffer overflow i am checking for it.

[Ian Collins]

Ashwin wrote:

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;

Don't do this, use getline();

--
Ian Collins.

[WittyGuy]

"Ashwin" <as************ @gmail.comwrote in message
news:11******** *************@b 28g2000cwb.goog legroups.com...

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;
s=a;

Ashwin,
Try doing deep copy instead of shallow copy. And don't forget to delete the
allocated memory.

return in;
}

HTH,
Sukumar R

[Ashwin]

WittyGuy wrote:

"Ashwin" <as************ @gmail.comwrote in message
news:11******** *************@b 28g2000cwb.goog legroups.com...

hi guys,

i have overloaded >operator for my own string class .the function is
as given below
istream& operator>>(istr eam &in,string1 &s)
{
char *a;
a=new char[100];
in>>a;
s=a;

Ashwin,
Try doing deep copy instead of shallow copy. And don't forget to delete the
allocated memory.

return in;

thanks for the reponse can anyone tell me how to implement the
following eqation
s[1]='a';
where s is a object of the string class i have written
plzz tell me how to overload the operations just signatures of the
functions.

}

HTH,
Sukumar R

[Ian Collins]

Ashwin wrote:

>
thanks for the reponse can anyone tell me how to implement the
following eqation
s[1]='a';
where s is a object of the string class i have written
plzz tell me how to overload the operations just signatures of the
functions.

Show us what you have so far.

Please stop using silly abbreviations like 'plz' and try to use correct
capitalisation. Otherwise your posts are hard to read an people who
might help you will ignore them.
--
Ian Collins.

[Ashwin]

Ian Collins wrote:

Ashwin wrote:

thanks for the reponse can anyone tell me how to implement the
following eqation
s[1]='a';
where s is a object of the string class i have written
plzz tell me how to overload the operations just signatures of the
functions.

Show us what you have so far.

Please stop using silly abbreviations like 'plz' and try to use correct
capitalisation. Otherwise your posts are hard to read an people who
might help you will ignore them.
--
Ian Collins.

sorry Ian collins i wont use that abbrevation again . i have overloaded
both [ ] and = operator as follows
void operator=(char *s);
void operator=(strin g1 s);
and
string1& operator+(char *s);
char operator[](unsigned int i);
where string1 is the string class i am writing.
so to implement the expression s[1]='c';
i donot know how to overload the operators
i am thinking of using char operator=(char ch);
and char operator[ ] (unsigned int i);
i don't know whether it will work or not have to try.

[Rolf Magnus]

Ashwin wrote:

>
Ian Collins wrote:

>Ashwin wrote:

>
thanks for the reponse can anyone tell me how to implement the
following eqation
s[1]='a';
where s is a object of the string class i have written
plzz tell me how to overload the operations just signatures of the
functions.

Show us what you have so far.

Please stop using silly abbreviations like 'plz' and try to use correct
capitalisation . Otherwise your posts are hard to read an people who
might help you will ignore them.
--
Ian Collins.

sorry Ian collins i wont use that abbrevation again . i have overloaded
both [ ] and = operator as follows
void operator=(char *s);

Should better be:

string1& operator=(const char* s);

void operator=(strin g1 s);

string1& operator=(const string1& s);

and
string1& operator+(char *s);

string1& operator+(const char *s);

char operator[](unsigned int i);

char operator[](unsigned int i) const;

where string1 is the string class i am writing.
so to implement the expression s[1]='c';
i donot know how to overload the operators

Try to add:

char& operator[](unsigned int i);

i am thinking of using char operator=(char ch);
and char operator[ ] (unsigned int i);
i don't know whether it will work or not have to try.

Doesn't make much sense.

[Ashwin]

Rolf Magnus wrote:

Ashwin wrote:

Ian Collins wrote:

Ashwin wrote:

thanks for the reponse can anyone tell me how to implement the
following eqation
s[1]='a';
where s is a object of the string class i have written
plzz tell me how to overload the operations just signatures of the
functions.

Show us what you have so far.

Please stop using silly abbreviations like 'plz' and try to use correct
capitalisation. Otherwise your posts are hard to read an people who
might help you will ignore them.
--
Ian Collins.

sorry Ian collins i wont use that abbrevation again . i have overloaded
both [ ] and = operator as follows
void operator=(char *s);

Should better be:

string1& operator=(const char* s);

void operator=(strin g1 s);

string1& operator=(const string1& s);

and
string1& operator+(char *s);

string1& operator+(const char *s);

char operator[](unsigned int i);

char operator[](unsigned int i) const;

where string1 is the string class i am writing.
so to implement the expression s[1]='c';
i donot know how to overload the operators

Try to add:

char& operator[](unsigned int i);

i am thinking of using char operator=(char ch);
and char operator[ ] (unsigned int i);
i don't know whether it will work or not have to try.

Doesn't make much sense.

hi Rolf,

i wanted to know how to overload the [] and = operator so that i can
implement the expression
s[1]='c'.