please help with mysterious error....

[Martin Jørgensen]

Hi,

In continuation of the thread I made "perhaps a stack problem? Long
calculations - strange error?", I think I now got a "stable" error,
meaning that the error always seem to come here now (tried: visual
studio 2005 + linux/macintosh gcc)...

That's a pretty good thing. I think the error still appears using both
gcc and visual studio 2005. Everything is standard C (ANSI C ?? I don't
know the difference) - but since so many functions depend on different
variables it's hard for me to isolate the error or to make a minimal
example ready for posting...

What can I say: I don't get any compile errors/warning... I tried
valgrind, but it wrote something I didn't agree with or I didn't
understood what it disliked...
Instructions:

1) Download + unzip (there are no binaries so no viruses/spam/whatever)
2a) Under linux/mac os: just type "make" (makefile included)
2b) Under windows: I guess you just create a new project and drag the
*.c and *.h files into it and compile/build.
3a) Either run the program and see the error or
3b) put a breakpoint in "result_output. c" line 748, then step a few
lines and watch what happens.

What is wrong?
for(i=0; i<total_linepie ces; i++);
{
printf("i = %d\n", i); /* i should be 0 now, right? */
if( i != 0)
{
printf("\n\nTHE PROGRAM DOESN'T WORK\n\n");
quit_program(__ FILE__, __LINE__);
}
else
{
printf("\n\nTHA NKS!!! THE PROGRAM WORKS\n");
quit_program(__ FILE__, __LINE__);
}
}

Some memory-garbage-thing, probably...
I'm really really fed up and tired of this bug, because I can't find it
and the compiler doesn't help me...

I've prepared 2 archives: .zip + .tar.gz.

(enter code + click blue button "START DOWNLOAD")
zip: http://www.uploading.com/?get=N3PT46TP

(click "DOWNLOAD", yellow bar bottom right).
tar.gz: http://www.savefile.com/files/2695995
It would also be nice to know how to avoid such a problem in the future,
when the compiler doesn't help...
Best regards
Martin Jørgensen

--
---------------------------------------------------------------------------
Home of Martin Jørgensen - http://www.martinjoergensen.dk

[Richard Heathfield]

Martin Jørgensen said:

Hi,

In continuation of the thread I made "perhaps a stack problem? Long
calculations - strange error?", I think I now got a "stable" error,
meaning that the error always seem to come here now (tried: visual
studio 2005 + linux/macintosh gcc)...

I got 92 lines of complaint from gcc.

Here are the edited highlights:

main.h:46: warning: declaration of `dx' shadows global declaration
main.h:47: warning: declaration of `dy' shadows global declaration

(lots and lots of similar diagnostics)

..//main.c:32: warning: passing arg 1 of `get_nx_ny_nz' discards qualifiers
from pointer target type
..//main.c:49: warning: passing arg 1 of `quit_program' discards qualifiers
from pointer target type

(lots and lots of similar diagnostics)

When you get a clean compile at a reasonably fascist warning level, come on
back.

--
Richard Heathfield
"Usenet is a strange place" - dmr 29/7/1999
http://www.cpax.org.uk
email: rjh at above domain (but drop the www, obviously)

[Bas Wassink]

On Thu, 01 Jun 2006 18:17:12 +0200, Martin Jørgensen wrote:

Hi,

In continuation of the thread I made "perhaps a stack problem? Long
calculations - strange error?", I think I now got a "stable" error,
meaning that the error always seem to come here now (tried: visual
studio 2005 + linux/macintosh gcc)...

That's a pretty good thing. I think the error still appears using both
gcc and visual studio 2005. Everything is standard C (ANSI C ?? I don't
know the difference) - but since so many functions depend on different
variables it's hard for me to isolate the error or to make a minimal
example ready for posting...

What can I say: I don't get any compile errors/warning... I tried
valgrind, but it wrote something I didn't agree with or I didn't
understood what it disliked... <snip> What is wrong?
for(i=0; i<total_linepie ces; i++); I think you should remove the semicolon here, now this line just
increments i until it's equal to 'total_linepiec es', and afterwars the
following code gets executed.
{
printf("i = %d\n", i); /* i should be 0 now, right? */ if( i != 0) {
printf("\n\nTHE PROGRAM DOESN'T WORK\n\n"); quit_program(__ FILE__,
__LINE__);
}
else
{
printf("\n\nTHA NKS!!! THE PROGRAM WORKS\n"); quit_program(__ FILE__,
__LINE__);
}
}

Some memory-garbage-thing, probably...
I'm really really fed up and tired of this bug, because I can't find it
and the compiler doesn't help me... <snip>
It would also be nice to know how to avoid such a problem in the future,
when the compiler doesn't help...
Best regards
Martin Jørgensen

Hope this helps,
Bas Wassink

[Martin Jørgensen]

Bas Wassink wrote:

On Thu, 01 Jun 2006 18:17:12 +0200, Martin Jørgensen wrote:

Hi,

In continuation of the thread I made "perhaps a stack problem? Long
calculation s - strange error?", I think I now got a "stable" error,
meaning that the error always seem to come here now (tried: visual
studio 2005 + linux/macintosh gcc)...

That's a pretty good thing. I think the error still appears using both
gcc and visual studio 2005. Everything is standard C (ANSI C ?? I don't
know the difference) - but since so many functions depend on different
variables it's hard for me to isolate the error or to make a minimal
example ready for posting...

What can I say: I don't get any compile errors/warning... I tried
valgrind, but it wrote something I didn't agree with or I didn't
understood what it disliked...

<snip>

What is wrong?
for(i=0; i<total_linepie ces; i++);

I think you should remove the semicolon here, now this line just
increments i until it's equal to 'total_linepiec es', and afterwars the
following code gets executed.

OMFG! That code was driving me "#€%()#€%€(%##€ (#€%( crazy and then I
just overlooked that? :-)

I think I've looked many other places, but that... Oh, well. Nice to get
some feedback... Thanks.
Best regards
Martin Jørgensen

--
---------------------------------------------------------------------------
Home of Martin Jørgensen - http://www.martinjoergensen.dk

[Martin Jørgensen]

Richard Heathfield wrote:

Martin Jørgensen said:

Hi,

In continuation of the thread I made "perhaps a stack problem? Long
calculation s - strange error?", I think I now got a "stable" error,
meaning that the error always seem to come here now (tried: visual
studio 2005 + linux/macintosh gcc)...

I got 92 lines of complaint from gcc.

Ok, since this problem was just a semi-colon in the wrong place (C is
really a bitch to me sometimes, LOL) I have the feeling that my original
problem perhaps could have been that 2 of my variable arrays was
malloc'ed 2 bytes too small, each (the "perhaps a stack problem?-thing")...
Here are the edited highlights:

main.h:46: warning: declaration of `dx' shadows global declaration
main.h:47: warning: declaration of `dy' shadows global declaration

(lots and lots of similar diagnostics)

.//main.c:32: warning: passing arg 1 of `get_nx_ny_nz' discards qualifiers
from pointer target type
.//main.c:49: warning: passing arg 1 of `quit_program' discards qualifiers
from pointer target type

(lots and lots of similar diagnostics)

When you get a clean compile at a reasonably fascist warning level, come on
back.

Eerhm, please help me get to know how I get so many warnings printed out
so I can fix them... I don't get any if I just type make.

How did you compile (detailed instructions, please)...

I was told that just typing "make" was sufficient (I didn't make the
makefile myself), but I also had the feeling that much more was wrong...

I was actually also wondering why that global variable definitions
didn't work... :-)
Best regards
Martin Jørgensen

--
---------------------------------------------------------------------------
Home of Martin Jørgensen - http://www.martinjoergensen.dk

[Martin Jørgensen]

Richard Heathfield wrote:

Martin Jørgensen said: -snip-
When you get a clean compile at a reasonably fascist warning level, come on
back.

Erhm, even better yet: How do I make a/modify my makefile so the program
gets compiled with the highest warning/error-output level every time?

Basically I just want something where I just type "make" and then I see
all (92 lines of or whatever..) warnings/errors?

Then I fix some of them and type "make" again until they're all gone...
Best regards
Martin Jørgensen

--
---------------------------------------------------------------------------
Home of Martin Jørgensen - http://www.martinjoergensen.dk

[santosh]

Martin Jørgensen wrote:

Richard Heathfield wrote:

Martin Jørgensen said: -snip-

When you get a clean compile at a reasonably fascist warning level, come on
back.

Erhm, even better yet: How do I make a/modify my makefile so the program
gets compiled with the highest warning/error-output level every time?

The documentation for your compiler will detail the command line flags
needed to set diagnostics level.

If you're using gcc, type info gcc under Linux or download the docs
available from gcc.gnu.org and read them.

A minimal set of switches is -W -Wall -ansi -pedantic. Richard
Heathfield posted recently a set of switches he uses to get even more
checking and diagnostics. Use Google Groups to search for it.

Once you get the command line right, you can then create your makefile.
To do that, GNU make's docs contain a tutorial.
Basically I just want something where I just type "make" and then I see
all (92 lines of or whatever..) warnings/errors?

Then I fix some of them and type "make" again until they're all gone...

As an alternative a graphical IDE might suit your needs, provided it
supplies options to pass to the compiler.

[Richard Heathfield]

Martin Jørgensen said:

How did you compile (detailed instructions, please)...

I used your makefile (much against my better judgement), but changed:

CFLAGS = $(PROTO_DEFINES ) $(STD_DEFINES) -g

to

CFLAGS = $(PROTO_DEFINES ) $(STD_DEFINES) -g -W -Wall -ansi -pedantic
-Wformat-nonliteral -Wcast-align -Wpointer-arith -Wbad-function-cast
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Winline
-Wundef -Wnested-externs -Wcast-qual -Wshadow -Wconversion -Wwrite-strings
-Wno-conversion -ffloat-store -O2

(all on one line, obviously).

--
Richard Heathfield
"Usenet is a strange place" - dmr 29/7/1999
http://www.cpax.org.uk
email: rjh at above domain (but drop the www, obviously)

[Richard Heathfield]

Martin Jørgensen said:

Richard Heathfield wrote:

Martin Jørgensen said: -snip-

When you get a clean compile at a reasonably fascist warning level, come
on back.

Erhm, even better yet: How do I make a/modify my makefile so the program
gets compiled with the highest warning/error-output level every time?

I have already demonstrated this elsethread.
Basically I just want something where I just type "make" and then I see
all (92 lines of or whatever..) warnings/errors?

Then I fix some of them and type "make" again until they're all gone...

I have a little program called makegen, which generates a makefile on
standard output. The simplest possible usage is:

makegen foo

Its output (which can of course be redirected to a Makefile) is:

CC=gcc
CFLAGS=-W -Wall -ansi -pedantic -Wformat-nonliteral -Wcast-align
-Wpointer-arith -Wbad-function-cast -Wmissing-prototypes
-Wstrict-prototypes -Wmissing-declarations -Winline -Wundef
-Wnested-externs -Wcast-qual -Wshadow -Wconversion -Wwrite-strings
-Wno-conversion -ffloat-store -O2
DFLAGS=-g -pg
foo: foo.o
$(CC) $(CFLAGS) $(DFLAGS) -o foo foo.o
foo.o: foo.c
$(CC) $(CFLAGS) $(DFLAGS) -c -o foo.o foo.c

clean:
rm foo.o
rm foo

install:
cp foo /usr/local/bin

--
Richard Heathfield
"Usenet is a strange place" - dmr 29/7/1999
http://www.cpax.org.uk
email: rjh at above domain (but drop the www, obviously)

[Flash Gordon]

Martin Jørgensen wrote:

Richard Heathfield wrote:

Martin Jørgensen said:

-snip-

When you get a clean compile at a reasonably fascist warning level,
come on back.

Erhm, even better yet: How do I make a/modify my makefile so the program
gets compiled with the highest warning/error-output level every time?

Basically I just want something where I just type "make" and then I see
all (92 lines of or whatever..) warnings/errors?

Then I fix some of them and type "make" again until they're all gone...

That depends on your compiler and make system (it would not be the same
for all the systems I use). Ask in a group that deals with your tool set.
--
Flash Gordon, living in interesting times.
Web site - http://home.flash-gordon.me.uk/
comp.lang.c posting guidelines and intro:
http://clc-wiki.net/wiki/Intro_to_clc