file reading problem

[Felix85]

here is my method for reading in a file:

static room room::file2Room (int rnum){
ostringstream filename;
filename << "../gamefiles/rooms/" << rnum <<
".room";
ifstream infile(filename .str().c_str()) ;
string roomNameIn, roomDescription In;
int roomExitsIn[6];
infile >> rnum;
getline(infile, roomNameIn);
getline(infile, roomDescription In);
infile >> roomExitsIn[0] >> roomExitsIn[1] >>
roomExitsIn[2] >> roomExitsIn[3] >> roomExitsIn[4] >> roomExitsIn[5];
room r;
r.setRoomNumber (rnum);
r.setRoomName(r oomNameIn);
r.setRoomDescri ption(roomDescr iptionIn);
r.setRoomExits( roomExitsIn[0], roomExitsIn[1],
roomExitsIn[2], roomExitsIn[3], roomExitsIn[4], roomExitsIn[5]);
return r;
}

there are no compile errors but it reads in the file incorrectly.

here is the file it reads from:
0
Test Room
You are standing in a test room
1 2 -1 4 5 6
when i output the result to the screen it comes up:
Test Room
[ ]
instead of:
Test Room
You are standing in a test room
[ n s w u d ]

ive been trying to fix this for about 6hrs and still cant find the
problem.
any help will be appreciated.

[Jim Langston]

"Felix85" <a.******@gmail .com> wrote in message
news:11******** **************@ i39g2000cwa.goo glegroups.com.. .

here is my method for reading in a file:

static room room::file2Room (int rnum){
ostringstream filename;
filename << "../gamefiles/rooms/" << rnum <<
".room";
ifstream infile(filename .str().c_str()) ;
if ( ! infile.open() )
// Do something for error here.
// Display a message, return an r with rnum -1 or something
string roomNameIn, roomDescription In;
int roomExitsIn[6];
infile >> rnum;
if ( ! infile >> rnum )
// Do something for error here.
// Display a message, return an r with rnum -1 or something
getline(infile, roomNameIn);
if ( ! getline( infile, roomNameIn ) )
// Do something for error here.
// Display a message, return an r with rnum -1 or something
getline(infile, roomDescription In);
if ( ! getline(infile, roomDescription In) )
// Do something for error here.
// Display a message, return an r with rnum -1 or something
infile >> roomExitsIn[0] >> roomExitsIn[1] >>
roomExitsIn[2] >> roomExitsIn[3] >> roomExitsIn[4] >> roomExitsIn[5];
if ( ! infile >> roomExitsIn[0] >> roomExitsIn[1] >>
roomExitsIn[2] >> roomExitsIn[3] >> roomExitsIn[4] >> roomExitsIn[5] )
// Do something for error here.
// Display a message, return an r with rnum -1 or something
room r;
r.setRoomNumber (rnum);
r.setRoomName(r oomNameIn);
r.setRoomDescri ption(roomDescr iptionIn);
r.setRoomExits( roomExitsIn[0], roomExitsIn[1],
roomExitsIn[2], roomExitsIn[3], roomExitsIn[4], roomExitsIn[5]);
return r;
}

there are no compile errors but it reads in the file incorrectly.

here is the file it reads from:
0
Test Room
You are standing in a test room
1 2 -1 4 5 6
when i output the result to the screen it comes up:
Test Room
[ ]
instead of:
Test Room
You are standing in a test room
[ n s w u d ]

ive been trying to fix this for about 6hrs and still cant find the
problem.
any help will be appreciated.

Put in the testing code and see if you get an error anywhere.

Otherwise, not enough information. Let us see how the class r is defined.
Let us see where you are trying to display the class r.

[Felix85]

The room object:
room(int rnum, string rname, string rdesc, int rexits[]){
roomNumber = rnum;
roomName = rname;
roomDescription = rdesc;
int i;
for(i = 0; i < sizeof(roomExit s); i++){
roomExits[i] = rexits[i];
}
}

stringifying the room object:
friend ostream& operator << (ostream& os, room& r){
string rooms;
if(r.roomExits[0] >= 0){
rooms += " n";
}
if(r.roomExits[1] >= 0){
rooms += " s";
}
if(r.roomExits[2] >= 0){
rooms += " e";
}
if(r.roomExits[3] >= 0){
rooms += " w";
}
if(r.roomExits[4] >= 0){
rooms += " u";
}
if(r.roomExits[5] >= 0){
rooms += " d";
}
return os << r.roomName << "\n" <<
r.roomDescripti on << "\n" << "[" << rooms << " ]\n";
}

[Felix85]

actually here is a better idea ill just post the whole file:

#include <iostream>
#include <string>
#include <fstream>
#include <sstream>

using namespace std;

class room {
public:
room() { }
room(int rnum, string rname, string rdesc, int rexits[]){
roomNumber = rnum;
roomName = rname;
roomDescription = rdesc;
int i;
for(i = 0; i < sizeof(roomExit s); i++){
roomExits[i] = rexits[i];
}
}

void room::setRoomNu mber(int rnum){
roomNumber = rnum;
}

void room::setRoomNa me(string rname){
roomName = rname;
}

void room::setRoomDe scription(strin g rdesc){
roomDescription = rdesc;
}

void room::setRoomEx its(int n, int s, int e, int w, int u, int d){
roomExits[0] = n; roomExits[1] = s; roomExits[2] = e;
roomExits[3] = w; roomExits[4] = u; roomExits[5] = d;
}

int room::getRoomNu mber(){
return roomNumber;
}

string room::getRoomNa me(){
return roomName;
}

string room::getRoomDe scription(){
return roomDescription ;
}

int* room::getRoomEx its(){
return roomExits;
}

void room::room2File (){
ostringstream filename;
filename << "../gamefiles/rooms/" << roomNumber << ".room";
ofstream outfile(filenam e.str().c_str() );

outfile << roomNumber << "\n";
outfile << roomName << "\n";
outfile << roomDescription << "\n";
outfile << roomExits[0] << " ";
outfile << roomExits[1] << " ";
outfile << roomExits[2] << " ";
outfile << roomExits[3] << " ";
outfile << roomExits[4] << " ";
outfile << roomExits[5] << " ";
outfile.close() ;
}
static room room::file2Room (int rnum){
ostringstream filename;
filename << "../gamefiles/rooms/" << rnum << ".room";
ifstream infile(filename .str().c_str()) ;
string roomNameIn, roomDescription In;
int roomExitsIn[6];
infile >> rnum;
getline(infile, roomNameIn);
getline(infile, roomDescription In);
infile >> roomExitsIn[0] >> roomExitsIn[1] >> roomExitsIn[2] >>
roomExitsIn[3] >> roomExitsIn[4] >> roomExitsIn[5];
room r;
r.setRoomNumber (rnum);
r.setRoomName(r oomNameIn);
r.setRoomDescri ption(roomDescr iptionIn);
r.setRoomExits( roomExitsIn[0], roomExitsIn[1], roomExitsIn[2],
roomExitsIn[3], roomExitsIn[4], roomExitsIn[5]);
return r;
}

private:
int roomNumber;
string roomName, roomDescription ;
int roomExits[6];
friend ostream& operator << (ostream& os, room& r){
string rooms;
if(r.roomExits[0] >= 0){
rooms += " n";
}
if(r.roomExits[1] >= 0){
rooms += " s";
}
if(r.roomExits[2] >= 0){
rooms += " e";
}
if(r.roomExits[3] >= 0){
rooms += " w";
}
if(r.roomExits[4] >= 0){
rooms += " u";
}
if(r.roomExits[5] >= 0){
rooms += " d";
}
return os << r.roomName << "\n" << r.roomDescripti on << "\n" << "["
<< rooms << " ]\n";
}
};

int main(void){
room r;
r.setRoomNumber (0);
r.setRoomName(" Test Room");
r.setRoomDescri ption("You are standing in a test room");
r.setRoomExits( 1, 2, -1, 4, 5, 6);
r.room2File();
cout << r;

room r2;
r2 = room::file2Room (0);
cout << r2;
return 0;
}

[Jim Langston]

"Felix85" <a.******@gmail .com> wrote in message
news:11******** **************@ g10g2000cwb.goo glegroups.com.. .

actually here is a better idea ill just post the whole file:

[code to program snipped]

I compiled your program and ran it after creating a 0.room file.

This is my output:
Test Room
You are standing in a test room
[ n s w u d ]
[ ]

I suspect that you do not have your room file in the right location so it's
failing on open.

Add at least the check for open I showed.

[Jim Langston]

"Jim Langston" <ta*******@rock etmail.com> wrote in message
news:CQ******** *****@fe07.lga. ..

"Felix85" <a.******@gmail .com> wrote in message
news:11******** **************@ g10g2000cwb.goo glegroups.com.. .

actually here is a better idea ill just post the whole file:

[code to program snipped]

I compiled your program and ran it after creating a 0.room file.

This is my output:
Test Room
You are standing in a test room
[ n s w u d ]
[ ]

I suspect that you do not have your room file in the right location so
it's failing on open.

Add at least the check for open I showed.

Ooops, igore that, because I didn't notice you were outputting r twice.

Let me do some checking.

[Felix85]

if you look at the room2File method it shows you the directory it puts
the 0.room file in.
.../gamefiles/rooms/0.room
and the file is in the right place.

[Felix85]

sry your last post didn't show up before i posted.

[Markus Schoder]

Felix85 wrote:

here is my method for reading in a file:

static room room::file2Room (int rnum){
ostringstream filename;
filename << "../gamefiles/rooms/" << rnum <<
".room";
ifstream infile(filename .str().c_str()) ;
string roomNameIn, roomDescription In;
int roomExitsIn[6];
infile >> rnum;
This reads up to the newline but does not consume it.
getline(infile, roomNameIn);
This starts at the newline and therefore reads an empty string. From
then on everything is out of sync. You could insert a dummy
getline(...) before this one.
getline(infile, roomDescription In);
infile >> roomExitsIn[0] >> roomExitsIn[1] >>
roomExitsIn[2] >> roomExitsIn[3] >> roomExitsIn[4] >> roomExitsIn[5];
room r;
r.setRoomNumber (rnum);
r.setRoomName(r oomNameIn);
r.setRoomDescri ption(roomDescr iptionIn);
r.setRoomExits( roomExitsIn[0], roomExitsIn[1],
roomExitsIn[2], roomExitsIn[3], roomExitsIn[4], roomExitsIn[5]);
return r;
}

there are no compile errors but it reads in the file incorrectly.

here is the file it reads from:
0
Test Room
You are standing in a test room
1 2 -1 4 5 6
when i output the result to the screen it comes up:
Test Room
[ ]
instead of:
Test Room
You are standing in a test room
[ n s w u d ]

ive been trying to fix this for about 6hrs and still cant find the
problem.
any help will be appreciated.

[Felix85]

that was the problem. thanks Markus. and thanks to everyone else who
posted.