Static initialization order fiasco with smart pointers

[Boris]

I've a class C with a smart pointer (I use boost::shared_p tr) which is
initialized in the constructor:

class C {
boost::shared_p tr<D> d;
public:
C() : d(new d()) { }
};

When the program starts class C is instantiated quite a lot. As all the
instances of C use the same empty instance of D I want them to share the
instance:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> one;
public:
C() : d(one) { }
};

boost::shared_p tr<D> C::one(new d());

That would work if I wasn't using the quick_allocator for boost::shared_p tr
(a memory manager which is used when BOOST_SP_USE_QU ICK_ALLOCATOR is
defined). Now as it turns out this memory manager uses static variables.

According to the FAQ we initialize the static member now in a method:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> one;
public:
C() : d(one) { }
static Init() { one.reset(new d()); }
};

boost::shared_p tr<D> C::one;

Now everything works until the program ends. If the static variables in the
memory manager of boost::shared_p tr are destroyed first the destructor of
the static smart pointer in class C will make a call to a non-existing
memory manager.

The only solution I see is freeing the static smart pointer when the last
instance of class C is destroyed (then noone needs the instance of D in the
smart pointer anymore). The destructor uses the counter of the smart pointer
to check when it should be freed:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> one;
public:
C() : d(one) { }
static Init() { one.reset(new d()); }
~C() { if (one.unique()) one.reset(); }
};

boost::shared_p tr<D> C::one;

This is however no general solution (eg. if you destroy all instances of C
and then create a new one in the middle of the program the smart pointer is
empty). Is there a better idea how to handle this?

Boris

[Boris]

Boris wrote:

[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?

Alright, about three seconds after clicking on Send I suddenly understood
that the smart pointer must be created dynamically:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_p tr<D>(new d()); }
};

boost::shared_p tr<D> *C::one;

Sometimes it helps to send a question just to find the answer yourself. :)

Boris

[Victor Bazarov]

Boris wrote:

Boris wrote:

[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?
Alright, about three seconds after clicking on Send I suddenly
understood that the smart pointer must be created dynamically:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_p tr<D>(new d()); }

static *WHAT* Init()? Did you mean to say

static void Init()

???
};

boost::shared_p tr<D> *C::one;
This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of 'C',
I get undefined behaviour because a null pointer is dereferenced...
Sometimes it helps to send a question just to find the answer
yourself. :)

No doubt. Did you actually find the answer?

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask

[Boris]

Victor Bazarov wrote:

[...] static *WHAT* Init()? Did you mean to say

static void Init()

???

Sorry, I forgot the return type.

boost::shared_p tr<D> *C::one;

This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of 'C',
I get undefined behaviour because a null pointer is dereferenced...

Read my original message again and then the FAQ. Here's the direct link:
http://www.parashift.com/c++-faq-lit...html#faq-10.14

Sometimes it helps to send a question just to find the answer
yourself. :)

No doubt. Did you actually find the answer?

Guess for what Init() is used for you corrected above?

Boris

[Victor Bazarov]

Boris wrote:

Victor Bazarov wrote:

[...] static *WHAT* Init()? Did you mean to say

static void Init()

???

Sorry, I forgot the return type.

boost::shared_p tr<D> *C::one;

This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of
'C', I get undefined behaviour because a null pointer is
dereferenced...

Read my original message again and then the FAQ. Here's the direct
link: http://www.parashift.com/c++-faq-lit...html#faq-10.14

Sometimes it helps to send a question just to find the answer
yourself. :)

No doubt. Did you actually find the answer?

Guess for what Init() is used for you corrected above?

I don't see it called anywhere.

V
--
Please remove capital As from my address when replying by mail

[Fei Liu]

Boris wrote:

Boris wrote:

[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?

Alright, about three seconds after clicking on Send I suddenly understood
that the smart pointer must be created dynamically:

class C {
boost::shared_p tr<D> d;
static boost::shared_p tr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_p tr<D>(new d()); }
};

boost::shared_p tr<D> *C::one;

Sometimes it helps to send a question just to find the answer yourself. :)

Boris

Try the following code:

#include <iostream>
#include <boost/shared_ptr.hpp>

struct D {
int x;
D():x(3){}
};

class C {
boost::shared_p tr<D> d;
public:
C(): d(Init()) {}
static boost::shared_p tr<D> Init(){
static boost::shared_p tr<D> *one;
if(!one)
one = new boost::shared_p tr<D>(new D());
return *one;
}
void print(){
std::cout << "D::x = " << d->x << std::endl;
}
};

int main(void){

C c;
c.print();
}