Read dynamic string

[Sillaba atona]

I use this code to read dynamic string:

char *s1;
.......
puts("Inserire una stringa: ");
while((*s1++=ge tchar())!='\n') ;
*s1='\0';

The compilation (ANSI C) is OK but I receive an error during the execution.

The problem is not present if I use a static array.

I cannot find the error.

[Toni Uusitalo]

those who know me have no need of my name wrote:

in comp.lang.c i read:

i elided most of the code -- sometimes this is a mistake, though i hope not
-- only the bits with nits remain.

char *rfg(FILE * f, int l) {

int makes some sense, but i happen to prefer size_t as there is no meaning
in a negative length or offset in this code.

char *rfg(FILE * f, size_t l) {

also, this is now a very short name to have with external linkage. i would
probably change to internal linkage, or rename it rfgets_r -- heh, perhaps
both.

I would change its name to wof (write-only function)
(http://en.wikipedia.org/wiki/Write-only_language)
;-)

Well maybe I'm just jealous cos I couldn't come up with something as
clever as this function ;-)

with respect,
Toni Uusitalo

[Toni Uusitalo]

Toni Uusitalo wrote:

those who know me have no need of my name wrote:

in comp.lang.c i read:

i elided most of the code -- sometimes this is a mistake, though i
hope not
-- only the bits with nits remain.

char *rfg(FILE * f, int l) {

int makes some sense, but i happen to prefer size_t as there is no
meaning
in a negative length or offset in this code.

char *rfg(FILE * f, size_t l) {

also, this is now a very short name to have with external linkage. i
would
probably change to internal linkage, or rename it rfgets_r -- heh,
perhaps
both.

I would change its name to wof (write-only function)
(http://en.wikipedia.org/wiki/Write-only_language)
;-)

Oh sorry, of course it must be
WriteOnlyFuncti onWhichIsClever TrustMe()
to avoid too short name

with respect,
Toni Uusitalo

[Daniel Fischer]

those who know me have no need of my name!

what if the malloc fails? (the cast just to do the arithmetic is ugly
enough to want a change, even though it is valid -- as long as malloc
doesn't fail.)

One could argue that if malloc fails, writing to 0+l results in
fail-fast-by-segfault behaviour :)

But I guess you're right.
Daniel

[Richard Bos]

Daniel Fischer <sp**@erinye.co m> wrote:

those who know me have no need of my name!

what if the malloc fails? (the cast just to do the arithmetic is ugly
enough to want a change, even though it is valid -- as long as malloc
doesn't fail.)

One could argue that if malloc fails, writing to 0+l results in
fail-fast-by-segfault behaviour :)

_May_ result in fail-fast-by-segfault behaviour. May also, e.g., result
in fail-late-and-disastrously-by-overwritten-interrupt-vector behaviour.

Richard

[Flash Gordon]

Daniel Fischer wrote:

those who know me have no need of my name!

what if the malloc fails? (the cast just to do the arithmetic is ugly
enough to want a change, even though it is valid -- as long as malloc
doesn't fail.)
One could argue that if malloc fails, writing to 0+l results in
fail-fast-by-segfault behaviour :)

One could argue that, but one would not be right on all systems.
But I guess you're right.

He is indeed.
--
Flash Gordon
Living in interesting times.
Although my email address says spam, it is real and I read it.