Hi all,
I very much need your help here guys.. I'm working on a IPSec
implementation, and when almost finished, I found a considerable
problem. I'm sending a particular array + a key to a HMAC-SHA1 function.
I did the tests with the following:
void icv_Calculation _test(char p_output[20]) {
char msgtest[]="what do ya want for nothing?";
char key[]="Jefe";
uint8_t outputsha[20];
int size_message, size_key;
size_message = strlen(msgtest) ;
size_key = strlen(key);
hmac_sha(key, size_key, msgtest, size_message, outputsha,
sizeof(outputsh a));
strcpy(p_output , outputsha);
return;
}
And I got the expected result, as in test case #2 from RFC 2202:
0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79
However, I thought everything was ok until I tried to match different
HMAC calculations (from sender and receiver).. they didn't match and I
then realized I was generating different HMAC calculations every time I
called the function (from sender). I tried then other test cases from
RFC 2202, and then I realized I had problems with the following:
For instance, when trying to obtain the HMAC result for test case #1
which has:
char msgtest[]="Hi There";
and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B
I'm not sure how to deal with it.. I tried the following:
strtoul().. like this:
char szInput[]="0x0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B0B" ;
char * pEnd;
unsigned long ul;
ul = strtoul (szInput,&pEnd, 0);
But the HMAC functions from RFC 2202 need keys as strings.. I'm a little
bit confused because I don't know what to do with it.
Bottom line, I'm not getting the expected HMAC calculation when sending
to the function the following, but when using test case #2, which is all
ascii, it works fine..
Below is the code.. It's a little bit long, but I very much need your
help here.. Tell me if you need something else for this to be more clear..
Here i'm trying to show the data types..
..........
typedef struct {
char * message;
char dest_ip[20];
char src_ip[20];
int msg_length;
int port;
char * key;
char algorithm;
} CONF_PARAMS;
.............
uint8_t payload[sizeof(packet) + sizeof(authenHe ader_ext)];
uint8_t output[output_size]
...............
icv_Calculation (payload, sizeof(payload) , cnf, output, output_size);
..............
void icv_Calculation (char *hdrs, int hdrs_len, CONF_PARAMS *cnf, uint8_t
*output, int output_len) {
if (cnf->algorithm == 's' )
hmac_sha(cnf->key, strlen(cnf->key), hdrs, hdrs_len, output,
sizeof(output)) ;
}
hdrs is where I have my hex values, the message over which the HMAC
calculation works.
Heres the HMAC function, .h and .c
#ifndef HMACSHA1_H_
#define HMACSHA1_H_
#include "sha1.h"
#ifndef SHA_DIGESTSIZE
#define SHA_DIGESTSIZE 20
#endif
#ifndef SHA_BLOCKSIZE
#define SHA_BLOCKSIZE 64
#endif
void pr_sha(FILE*, unsigned char*, int);
void truncate_sha1 (char*, char*, int);
void hmac_sha (char*, int, char*, int, char*, int);
#endif /*HMACSHA1_H_*/
----------------------------------
#include <stdio.h>
#include "sha1.h"
#include "hmac-sha1.h"
/*
* From sha1.h ------------------------
*
* sha1_context;
* void sha1_starts( sha1_context *ctx );
* void sha1_update( sha1_context *ctx, uint8 *input, uint32 length );
* void sha1_finish( sha1_context *ctx, uint8 digest[20] );
*
*/
/* Function to print the digest */
void pr_sha(FILE* fp, unsigned char* s, int t) {
int i;
fprintf(fp, "0x");
for (i = 0 ; i < t ; i++)
fprintf(fp, "%02x", s[i]);
fprintf(fp, "0");
}
void truncate_sha1 (
char* d1, /* data to be truncated */
char* d2, /* truncated data */
int len /* length in bytes to keep */
) {
int i;
for (i=0; i < len; i++)
d2[i] = d1[i];
}
/* Function to compute the digest */
void hmac_sha (
char* k, /* secret key */
int lk, /* length of the key in bytes */
char* d, /* data */
int ld, /* length of data in bytes */
char* out, /* output buffer, at least "t" bytes */
int t
) {
sha1_context ictx, octx;
char isha[SHA_DIGESTSIZE], osha[SHA_DIGESTSIZE];
char key[SHA_DIGESTSIZE];
char buf[SHA_BLOCKSIZE];
int i;
if (lk > SHA_BLOCKSIZE) {
sha1_context tctx;
sha1_starts(&tc tx);
sha1_update(&tc tx, k, lk);
sha1_finish(&tc tx, key);
k = key;
lk = SHA_DIGESTSIZE;
}
/**** Inner Digest ****/
sha1_starts(&ic tx);
/* Pad the key for inner digest */
for (i = 0 ; i < lk ; ++i)
buf[i] = k[i] ^ 0x36;
for (i = lk ; i < SHA_BLOCKSIZE ; ++i) buf[i] = 0x36;
sha1_update(&ic tx, buf, SHA_BLOCKSIZE);
sha1_update(&ic tx, d, ld);
sha1_finish(&ic tx, isha);
/**** Outter Digest ****/
sha1_starts(&oc tx);
/* Pad the key for outter digest */
for (i = 0 ; i < lk ; ++i)
buf[i] = k[i] ^ 0x5C;
for (i = lk ; i < SHA_BLOCKSIZE ; ++i)
buf[i] = 0x5C;
sha1_update(&oc tx, buf, SHA_BLOCKSIZE);
sha1_update(&oc tx, isha, SHA_DIGESTSIZE) ;
sha1_finish(&oc tx, osha);
/* truncate and print the results */
t = t > SHA_DIGESTSIZE ? SHA_DIGESTSIZE : t;
truncate_sha1(o sha, out, t);
pr_sha(stdout, out, t);
}
------------------------
And here's the SHA1 function, sorry if this is a long code, but the
problem I guess is in the origin of the function calls..
/*
* FIPS-180-1 compliant SHA-1 implementation
*
* Copyright (C) 2001-2003 Christophe Devine
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA
*/
#include <string.h>
#include "sha1.h"
#define GET_UINT32(n,b, i) \
{ \
(n) = ( (uint32) (b)[(i) ] << 24 ) \
| ( (uint32) (b)[(i) + 1] << 16 ) \
| ( (uint32) (b)[(i) + 2] << 8 ) \
| ( (uint32) (b)[(i) + 3] ); \
}
#define PUT_UINT32(n,b, i) \
{ \
(b)[(i) ] = (uint8) ( (n) >> 24 ); \
(b)[(i) + 1] = (uint8) ( (n) >> 16 ); \
(b)[(i) + 2] = (uint8) ( (n) >> 8 ); \
(b)[(i) + 3] = (uint8) ( (n) ); \
}
void sha1_starts( sha1_context *ctx )
{
ctx->total[0] = 0;
ctx->total[1] = 0;
ctx->state[0] = 0x67452301;
ctx->state[1] = 0xEFCDAB89;
ctx->state[2] = 0x98BADCFE;
ctx->state[3] = 0x10325476;
ctx->state[4] = 0xC3D2E1F0;
}
void sha1_process( sha1_context *ctx, uint8 data[64] )
{
uint32 temp, W[16], A, B, C, D, E;
GET_UINT32( W[0], data, 0 );
GET_UINT32( W[1], data, 4 );
GET_UINT32( W[2], data, 8 );
GET_UINT32( W[3], data, 12 );
GET_UINT32( W[4], data, 16 );
GET_UINT32( W[5], data, 20 );
GET_UINT32( W[6], data, 24 );
GET_UINT32( W[7], data, 28 );
GET_UINT32( W[8], data, 32 );
GET_UINT32( W[9], data, 36 );
GET_UINT32( W[10], data, 40 );
GET_UINT32( W[11], data, 44 );
GET_UINT32( W[12], data, 48 );
GET_UINT32( W[13], data, 52 );
GET_UINT32( W[14], data, 56 );
GET_UINT32( W[15], data, 60 );
#define S(x,n) ((x << n) | ((x & 0xFFFFFFFF) >> (32 - n)))
#define R(t) \
( \
temp = W[(t - 3) & 0x0F] ^ W[(t - 8) & 0x0F] ^ \
W[(t - 14) & 0x0F] ^ W[ t & 0x0F], \
( W[t & 0x0F] = S(temp,1) ) \
)
#define P(a,b,c,d,e,x) \
{ \
e += S(a,5) + F(b,c,d) + K + x; b = S(b,30); \
}
A = ctx->state[0];
B = ctx->state[1];
C = ctx->state[2];
D = ctx->state[3];
E = ctx->state[4];
#define F(x,y,z) (z ^ (x & (y ^ z)))
#define K 0x5A827999
P( A, B, C, D, E, W[0] );
P( E, A, B, C, D, W[1] );
P( D, E, A, B, C, W[2] );
P( C, D, E, A, B, W[3] );
P( B, C, D, E, A, W[4] );
P( A, B, C, D, E, W[5] );
P( E, A, B, C, D, W[6] );
P( D, E, A, B, C, W[7] );
P( C, D, E, A, B, W[8] );
P( B, C, D, E, A, W[9] );
P( A, B, C, D, E, W[10] );
P( E, A, B, C, D, W[11] );
P( D, E, A, B, C, W[12] );
P( C, D, E, A, B, W[13] );
P( B, C, D, E, A, W[14] );
P( A, B, C, D, E, W[15] );
P( E, A, B, C, D, R(16) );
P( D, E, A, B, C, R(17) );
P( C, D, E, A, B, R(18) );
P( B, C, D, E, A, R(19) );
#undef K
#undef F
#define F(x,y,z) (x ^ y ^ z)
#define K 0x6ED9EBA1
P( A, B, C, D, E, R(20) );
P( E, A, B, C, D, R(21) );
P( D, E, A, B, C, R(22) );
P( C, D, E, A, B, R(23) );
P( B, C, D, E, A, R(24) );
P( A, B, C, D, E, R(25) );
P( E, A, B, C, D, R(26) );
P( D, E, A, B, C, R(27) );
P( C, D, E, A, B, R(28) );
P( B, C, D, E, A, R(29) );
P( A, B, C, D, E, R(30) );
P( E, A, B, C, D, R(31) );
P( D, E, A, B, C, R(32) );
P( C, D, E, A, B, R(33) );
P( B, C, D, E, A, R(34) );
P( A, B, C, D, E, R(35) );
P( E, A, B, C, D, R(36) );
P( D, E, A, B, C, R(37) );
P( C, D, E, A, B, R(38) );
P( B, C, D, E, A, R(39) );
#undef K
#undef F
#define F(x,y,z) ((x & y) | (z & (x | y)))
#define K 0x8F1BBCDC
P( A, B, C, D, E, R(40) );
P( E, A, B, C, D, R(41) );
P( D, E, A, B, C, R(42) );
P( C, D, E, A, B, R(43) );
P( B, C, D, E, A, R(44) );
P( A, B, C, D, E, R(45) );
P( E, A, B, C, D, R(46) );
P( D, E, A, B, C, R(47) );
P( C, D, E, A, B, R(48) );
P( B, C, D, E, A, R(49) );
P( A, B, C, D, E, R(50) );
P( E, A, B, C, D, R(51) );
P( D, E, A, B, C, R(52) );
P( C, D, E, A, B, R(53) );
P( B, C, D, E, A, R(54) );
P( A, B, C, D, E, R(55) );
P( E, A, B, C, D, R(56) );
P( D, E, A, B, C, R(57) );
P( C, D, E, A, B, R(58) );
P( B, C, D, E, A, R(59) );
#undef K
#undef F
#define F(x,y,z) (x ^ y ^ z)
#define K 0xCA62C1D6
P( A, B, C, D, E, R(60) );
P( E, A, B, C, D, R(61) );
P( D, E, A, B, C, R(62) );
P( C, D, E, A, B, R(63) );
P( B, C, D, E, A, R(64) );
P( A, B, C, D, E, R(65) );
P( E, A, B, C, D, R(66) );
P( D, E, A, B, C, R(67) );
P( C, D, E, A, B, R(68) );
P( B, C, D, E, A, R(69) );
P( A, B, C, D, E, R(70) );
P( E, A, B, C, D, R(71) );
P( D, E, A, B, C, R(72) );
P( C, D, E, A, B, R(73) );
P( B, C, D, E, A, R(74) );
P( A, B, C, D, E, R(75) );
P( E, A, B, C, D, R(76) );
P( D, E, A, B, C, R(77) );
P( C, D, E, A, B, R(78) );
P( B, C, D, E, A, R(79) );
#undef K
#undef F
ctx->state[0] += A;
ctx->state[1] += B;
ctx->state[2] += C;
ctx->state[3] += D;
ctx->state[4] += E;
}
void sha1_update( sha1_context *ctx, uint8 *input, uint32 length )
{
uint32 left, fill;
if( ! length ) return;
left = ctx->total[0] & 0x3F;
fill = 64 - left;
ctx->total[0] += length;
ctx->total[0] &= 0xFFFFFFFF;
if( ctx->total[0] < length )
ctx->total[1]++;
if( left && length >= fill )
{
memcpy( (void *) (ctx->buffer + left),
(void *) input, fill );
sha1_process( ctx, ctx->buffer );
length -= fill;
input += fill;
left = 0;
}
while( length >= 64 )
{
sha1_process( ctx, input );
length -= 64;
input += 64;
}
if( length )
{
memcpy( (void *) (ctx->buffer + left),
(void *) input, length );
}
}
static uint8 sha1_padding[64] =
{
0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
};
void sha1_finish( sha1_context *ctx, uint8 digest[20] )
{
uint32 last, padn;
uint32 high, low;
uint8 msglen[8];
high = ( ctx->total[0] >> 29 )
| ( ctx->total[1] << 3 );
low = ( ctx->total[0] << 3 );
PUT_UINT32( high, msglen, 0 );
PUT_UINT32( low, msglen, 4 );
last = ctx->total[0] & 0x3F;
padn = ( last < 56 ) ? ( 56 - last ) : ( 120 - last );
sha1_update( ctx, sha1_padding, padn );
sha1_update( ctx, msglen, 8 );
PUT_UINT32( ctx->state[0], digest, 0 );
PUT_UINT32( ctx->state[1], digest, 4 );
PUT_UINT32( ctx->state[2], digest, 8 );
PUT_UINT32( ctx->state[3], digest, 12 );
PUT_UINT32( ctx->state[4], digest, 16 );
}
FBM 11 1562
Fernando Barsoba wrote: Hi all,
I very much need your help here guys.. I'm working on a IPSec implementation, and when almost finished, I found a considerable problem. I'm sending a particular array + a key to a HMAC-SHA1 function. I did the tests with the following:
void icv_Calculation _test(char p_output[20]) { char msgtest[]="what do ya want for nothing?"; char key[]="Jefe"; uint8_t outputsha[20]; int size_message, size_key; size_message = strlen(msgtest) ; size_key = strlen(key); hmac_sha(key, size_key, msgtest, size_message, outputsha, sizeof(outputsh a)); strcpy(p_output , outputsha); return; }
And I got the expected result, as in test case #2 from RFC 2202: 0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79
However, I thought everything was ok until I tried to match different HMAC calculations (from sender and receiver).. they didn't match and I then realized I was generating different HMAC calculations every time I called the function (from sender). I tried then other test cases from RFC 2202, and then I realized I had problems with the following:
For instance, when trying to obtain the HMAC result for test case #1 which has:
char msgtest[]="Hi There"; and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B
I'm not sure how to deal with it.. I tried the following:
strtoul().. like this:
<snip>
Forget strtoul(), this is too long for a long. You need to convert this
hexstring to an actual sequence of bytes. See if you have a library
function somewhere to do this.
If not, here's an example implementation I whipped up in a few seconds
(so don't trust it, and don't count on it being fast):
#include <stdlib.h>
#include <string.h>
/* Convert the single hexadecimal digit 'c' to the corresponding
integer, or -1 if 'c' is not a hex digit. */
int hexdigit_to_int (char c) {
if (c >= '0' && c <= '9') return c - '0';
switch (c) {
case 'a': case 'A': return 10;
case 'b': case 'B': return 11;
case 'c': case 'C': return 12;
case 'd': case 'D': return 13;
case 'e': case 'E': return 14;
case 'f': case 'F': return 15;
default: {
return -1;
}
}
}
/* Convert the hexadecimal representation of a sequence of bytes to
the sequence of bytes. */
/* Returns a malloc()-allocated block of strlen(hex) / 2 bytes if
successful or a null pointer otherwise. */
unsigned char* hexstr_to_bytes (const char* hex) {
size_t l = strlen(hex);
size_t n = 0;
unsigned char* result;
if (l % 2 != 0) return NULL;
result = malloc(l / 2);
if (!result) return NULL;
while (n < l) {
int d1 = hexdigit_to_int (hex[n]) * 16;
int d2 = hexdigit_to_int (hex[n + 1]);
if (d1 == -1 || d2 == -1) {
free(result);
return NULL;
}
result[n / 2] = d1 + d2;
n += 2;
}
return result;
}
Keep in mind that the input string must not begin with "0x", that you
must free() the result and that it is *not* a null-terminated string but
a sequence of bytes of a length you must keep track of yourself, so no
calling strlen() on it.
S.
Skarmander wrote: Fernando Barsoba wrote: Hi all,
I very much need your help here guys.. I'm working on a IPSec implementation, and when almost finished, I found a considerable problem. I'm sending a particular array + a key to a HMAC-SHA1 function. I did the tests with the following:
void icv_Calculation _test(char p_output[20]) { char msgtest[]="what do ya want for nothing?"; char key[]="Jefe"; uint8_t outputsha[20]; int size_message, size_key; size_message = strlen(msgtest) ; size_key = strlen(key); hmac_sha(key, size_key, msgtest, size_message, outputsha, sizeof(outputsh a)); strcpy(p_output , outputsha); return; }
And I got the expected result, as in test case #2 from RFC 2202: 0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79
However, I thought everything was ok until I tried to match different HMAC calculations (from sender and receiver).. they didn't match and I then realized I was generating different HMAC calculations every time I called the function (from sender). I tried then other test cases from RFC 2202, and then I realized I had problems with the following:
For instance, when trying to obtain the HMAC result for test case #1 which has:
char msgtest[]="Hi There"; and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B
I'm not sure how to deal with it.. I tried the following:
strtoul().. like this:
<snip>
Forget strtoul(), this is too long for a long. You need to convert this hexstring to an actual sequence of bytes. See if you have a library function somewhere to do this.
If not, here's an example implementation I whipped up in a few seconds (so don't trust it, and don't count on it being fast):
#include <stdlib.h> #include <string.h>
Thanks a lot, I'll try this.. however, what is the concept behind the
problem I'm having? I mean, why when I try to obtain a message digest of
a particular 'string' message and particular 'string' key the function
works (message digest is always the same), and it doesn't when I try the
same with identical string key, but a different 'string' message? The
only difference between those messages is that with the latter the hex
content is what is important to me.. I mean, instead of having:
char msgtest[]="what do ya want for nothing?";
char key[]="Jefe";
I have a char * whose hex content is what matters to me..
thanks,
FBM
Fernando Barsoba wrote: Skarmander wrote:
Fernando Barsoba wrote:
Hi all,
I very much need your help here guys.. I'm working on a IPSec implementation, and when almost finished, I found a considerable problem. I'm sending a particular array + a key to a HMAC-SHA1 function. I did the tests with the following:
void icv_Calculation _test(char p_output[20]) { char msgtest[]="what do ya want for nothing?"; char key[]="Jefe"; uint8_t outputsha[20]; int size_message, size_key; size_message = strlen(msgtest) ; size_key = strlen(key); hmac_sha(key, size_key, msgtest, size_message, outputsha, sizeof(outputsh a)); strcpy(p_output , outputsha); return; }
And I got the expected result, as in test case #2 from RFC 2202: 0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79
<snip> For instance, when trying to obtain the HMAC result for test case #1 which has:
char msgtest[]="Hi There"; and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B
<snip> I mean, why when I try to obtain a message digest of a particular 'string' message and particular 'string' key the function works (message digest is always the same), and it doesn't when I try the same with identical string key, but a different 'string' message? The only difference between those messages is that with the latter the hex content is what is important to me.. I mean, instead of having:
char msgtest[]="what do ya want for nothing?"; char key[]="Jefe";
I have a char * whose hex content is what matters to me..
The SHA function (apparently) expects a key that is a sequence of bytes.
As it so happens, "Jefe" is a sequence of bytes: assuming your system
uses an ASCII-compatible character set, the sequence can be represented
in hexadecimal as 0x4A65666500.
This is why passing a string to the function "just works": a string is
already a sequence of bytes. In the second example (key = 0x0b0b0b...)
you want to pass an actual byte sequence represented as a string of
hexadecimal digits, not the string "0x0b0b0b.. .", which is something
completely different.
S.
Skarmander wrote: Fernando Barsoba wrote: Skarmander wrote:
Fernando Barsoba wrote:
Hi all,
I very much need your help here guys.. I'm working on a IPSec implementation, and when almost finished, I found a considerable problem. I'm sending a particular array + a key to a HMAC-SHA1 function. I did the tests with the following:
void icv_Calculation _test(char p_output[20]) { char msgtest[]="what do ya want for nothing?"; char key[]="Jefe"; uint8_t outputsha[20]; int size_message, size_key; size_message = strlen(msgtest) ; size_key = strlen(key); hmac_sha(key, size_key, msgtest, size_message, outputsha, sizeof(outputsh a)); strcpy(p_output , outputsha); return; }
And I got the expected result, as in test case #2 from RFC 2202: 0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79 <snip> For instance, when trying to obtain the HMAC result for test case #1 which has:
char msgtest[]="Hi There"; and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B <snip> I mean, why when I try to obtain a message digest of a particular 'string' message and particular 'string' key the function works (message digest is always the same), and it doesn't when I try the same with identical string key, but a different 'string' message? The only difference between those messages is that with the latter the hex content is what is important to me.. I mean, instead of having:
char msgtest[]="what do ya want for nothing?"; char key[]="Jefe";
I have a char * whose hex content is what matters to me..
The SHA function (apparently) expects a key that is a sequence of bytes. As it so happens, "Jefe" is a sequence of bytes: assuming your system uses an ASCII-compatible character set, the sequence can be represented in hexadecimal as 0x4A65666500.
This is why passing a string to the function "just works": a string is already a sequence of bytes. In the second example (key = 0x0b0b0b...) you want to pass an actual byte sequence represented as a string of hexadecimal digits, not the string "0x0b0b0b.. .", which is something completely different.
S.
Thanks... I think I mixed two different things in my explanation.. The
test with the key=0x0b0b0b is something I tried later on.. and then I
realized I didn't know how to deal with hex keys.. however, my first
problem came when I found that I was generating different digests even
though I was using the same info... THAT doesn't happen with the example
above, and I always get the same hex string (key="Jefe" message="what do
you want.." But it is happening with key="Jefe" but message being a
char* instead of a char message[]="what do you..."
Any idea why is that..? This is the core of my problem. For the key, I
may want to use hex keys or I may not.. but the other problem is critical..
Thanks again for you *extended* help!
FBM
Skarmander wrote: Fernando Barsoba wrote:
<snip> char msgtest[]="Hi There"; and the key is 0x0B0B0B0B0B0B0 B0B0B0B0B0B0B0B 0B0B0B0B0B0B
I'm not sure how to deal with it.. I tried the following:
strtoul().. like this:
<snip>
Forget strtoul(), this is too long for a long.
True, and good advice.
You need to convert this hexstring to an actual sequence of bytes. See if you have a library function somewhere to do this.
Be aware that any such library function is non-standard and may not be
available on all platforms.
If not, here's an example implementation I whipped up in a few seconds (so don't trust it, and don't count on it being fast):
Some suggested improvements/simplifications/things to make it easier to
read.
#include <stdlib.h> #include <string.h>
#include <ctype.h>
Since I want to use functions from it, although you did not. /* Convert the single hexadecimal digit 'c' to the corresponding integer, or -1 if 'c' is not a hex digit. */ int hexdigit_to_int (char c) {
int hexdigit_to_int (const unsigned char) {
so I don't have to cast to unsigned char later.
if (c >= '0' && c <= '9') return c - '0';
if (isdigit(c)) return c - '0';
Yours was correct, but I think mine is easier to read.
switch (c) {
switch (isupper(c)) {
case 'A': return 10;
and so on.
case 'a': case 'A': return 10; case 'b': case 'B': return 11; case 'c': case 'C': return 12; case 'd': case 'D': return 13; case 'e': case 'E': return 14; case 'f': case 'F': return 15; default: { return -1; } } }
Or the following:
int hexdigit_to_int (const char c) {
char t[] = { c, '\0' };
int res = strcspn("012345 6789ABCDEF",
isupper((unsign ed char)c);
return (res>15)?-1:res;
}
/* Convert the hexadecimal representation of a sequence of bytes to the sequence of bytes. */ /* Returns a malloc()-allocated block of strlen(hex) / 2 bytes if successful or a null pointer otherwise. */ unsigned char* hexstr_to_bytes (const char* hex) { size_t l = strlen(hex);
Using l as a variable name is not a good idea. I initialy misread some
instances of it below as 1 and wondered what you were up to.
size_t n = 0; unsigned char* result; if (l % 2 != 0) return NULL;
result = malloc(l / 2); if (!result) return NULL;
while (n < l) { int d1 = hexdigit_to_int (hex[n]) * 16; int d2 = hexdigit_to_int (hex[n + 1]); if (d1 == -1 || d2 == -1) {
Oops. Last I checked -1*16 was not -1 ! ;-) free(result); return NULL; } result[n / 2] = d1 + d2; n += 2; }
I would be more likely to do something like:
for (n = 0; n < l; n += 2) {
int d1 = hexdigit_to_int (hex[n]);
int d2 = hexdigit_to_int (hex[n+1]);
if (d1 < 0 || d2 < 0) {
free(result);
return NULL;
}
result[n/2] = (d1 << 4) + d2;
}
return result; }
Keep in mind that the input string must not begin with "0x", that you must free() the result and that it is *not* a null-terminated string but a sequence of bytes of a length you must keep track of yourself, so no calling strlen() on it.
All good points.
--
Flash Gordon
Living in interesting times.
Although my email address says spam, it is real and I read it.
Flash Gordon wrote: Skarmander wrote:
Fernando Barsoba wrote: > You need to convert this
hexstring to an actual sequence of bytes. See if you have a library function somewhere to do this.
Be aware that any such library function is non-standard and may not be available on all platforms.
Yes, the implication was that this function could be part of his SHA
library (not his C library). Seems like a common enough thing to want in
this case. If not, here's an example implementation I whipped up in a few seconds (so don't trust it, and don't count on it being fast):
Some suggested improvements/simplifications/things to make it easier to read.
<snip> while (n < l) { int d1 = hexdigit_to_int (hex[n]) * 16; int d2 = hexdigit_to_int (hex[n + 1]); if (d1 == -1 || d2 == -1) {
Oops. Last I checked -1*16 was not -1 ! ;-)
That thing where I said it shouldn't be trusted? Yeah, that's this. :-)
<snip> for (n = 0; n < l; n += 2) { int d1 = hexdigit_to_int (hex[n]); int d2 = hexdigit_to_int (hex[n+1]); if (d1 < 0 || d2 < 0) { free(result); return NULL; } result[n/2] = (d1 << 4) + d2;
I've switched away from bit-shifting lately to using multiplication,
unless I'm really working with bits. In this case I'm not. Your version
is a tad inconsistent conceptually: why + and not | if you use <<
instead of *?
S.
Fernando Barsoba wrote: Skarmander wrote:
Fernando Barsoba wrote:
Skarmander wrote:
Fernando Barsoba wrote:
> Hi all, > > I very much need your help here guys.. I'm working on a IPSec > implementation, and when almost finished, I found a considerable > problem. I'm sending a particular array + a key to a HMAC-SHA1 > function. I did the tests with the following: > > void icv_Calculation _test(char p_output[20]) { > char msgtest[]="what do ya want for nothing?"; > char key[]="Jefe"; > uint8_t outputsha[20]; > int size_message, size_key; > size_message = strlen(msgtest) ; > size_key = strlen(key); > hmac_sha(key, size_key, msgtest, size_message, outputsha, > sizeof(outputsh a)); > strcpy(p_output , outputsha); > return; > } > > And I got the expected result, as in test case #2 from RFC 2202: > 0xeffcdf6ae5eb2 fa2d27416d5f184 df9c259a7c79 > <snip> however, my first problem came when I found that I was generating different digests even though I was using the same info... THAT doesn't happen with the example above, and I always get the same hex string (key="Jefe" message="what do you want.." But it is happening with key="Jefe" but message being a char* instead of a char message[]="what do you..."
Any idea why is that..? This is the core of my problem. For the key, I may want to use hex keys or I may not.. but the other problem is critical..
There is no conceptual difference when passing a char* instead of a
char[] to a function, so my only guess is that your call is incorrect.
Are you certain the char* is a string, for example? If, like in the
example above, it's a byte sequence, there is no terminator character,
and calling strlen() will simply not work; you must keep track of the
key length explicitly.
S.
Skarmander wrote:
<snip> Are you certain the char* is a string, for example? If, like in the example above [..]
That should be "upthread". I snipped a little too enthusiasticall y.
S.
Skarmander wrote: Flash Gordon wrote: Skarmander wrote:
<snip>
result[n/2] = (d1 << 4) + d2; I've switched away from bit-shifting lately to using multiplication, unless I'm really working with bits.
I consider this to be a case of working with bits. Although looking at
it as multiplication is equally valid.
In this case I'm not. Your version is a tad inconsistent conceptually: why + and not | if you use << instead of *?
Because having shifted it to the right place you can just add the bits
together? ;-)
--
Flash Gordon
Living in interesting times.
Although my email address says spam, it is real and I read it. This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: ljb |
last post by:
Anyone have a good idea for encrypting salary data in US $? I have an Access
database with some salary info connected to ASP on our intranet. My manager
is somewhat apprehensive about the level of security currently provided. I'm
using basic authentication (I think that's what it is called). It relies on
NT directory permissions and code to query "AUTH_USER". Does anyone have a
simple encryption idea that can take US$, 5 digit employee ID,...
|
by: sffan |
last post by:
I am new to database programming and was curious how others solve the
problem of storing encrypted in data in db table columns and then
subsequently searching for these records.
The particular problem that I am facing is in dealing with (privacy)
critical information like credit-card #s and SSNs or business critical
information like sales opportunity size or revenue in the database. The
requirement is that this data be stored encrypted...
|
by: Brian P. Hammer |
last post by:
All - I have an app that saves data to a xml file via a dataset. Our company stores some data in various xml files that is now considered a risk under its security policy. What's the best way to encrypt and decrypt the data in the file.
I use a dataset to load data to my forms and commit changes to the dataset and then write it to the xml file.
Thanks,
Brian
|
by: Todd Gruben |
last post by:
I am trying to send some encrypted data from a php application to be
decoded in a .Net application. Both apps encode/decode a given string
but generate different encrypted results. Anyone have any idea? Code
to follow:
php====>
<?php
// Designate string to be encrypted
$string = "This is a test";
|
by: Bonj |
last post by:
I was in need of an encryption algorithm to the following requirements:
1) Must be capable of encrypting strings to a byte array, and decyrpting
back again to the same string
2) Must have the same algorithm work with strings that may or may not be
unicode
3) Number of bytes back must either be <= number of _TCHARs in *
sizeof(_TCHAR), or the relation between output size and input size can be
calculated simply. Has to take into account the...
| |
by: Bart |
last post by:
Dear all,
I would like to encrypt a large amount of data by using public/private keys,
but I read on MSDN:
"Symmetric encryption is performed on streams and is therefore useful to
encrypt large amounts of data. Asymmetric encryption is performed on a small
number of bytes and is therefore only useful for small amounts of data."
There is not possibility to do it? I have tried to encrypt a 300kB file by
RSA Algorithm, but I received...
|
by: Hannibal111111 |
last post by:
I found this code on a site for doing string encryption/decryption.
The string will encrypt fine, but I get this error when I try to
decrypt. Any idea why? I posted the code below.
The error actually points to this line of code in byte decrypt
function:
cs.FlushFinalBlock();
public static byte encrypt(byte clearData, byte Key, byte IV)
|
by: sofeng |
last post by:
I'm not sure if "data hiding" is the correct term, but I'm trying to
emulate this object-oriented technique. I know C++ probably provides
much more than my example, but I'd just like some feedback to find out
if I've done anything wrong. Also, I am working on this for an
embedded environment, so if there are great inefficiencies with this
code, I'd like to know that also. I realize there is overhead with
using an "accessor" function.
...
|
by: Sin Jeong-hun |
last post by:
It seems like the Protect() uses the Windows accout information to
encrypt data. If I know the user name and the password, can I decrypt
it on another PC? If it is not, how about the exported key? On Windows
Vista, if file encryption is used, Windows suggests to back up the
key. If I import the key on another PC, then can I decrypt a data
protected by the Protect() method?
Or it is impossible by any means?
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main usage, and What is the difference between ONU and Router. Let’s take a closer look !
Part I. Meaning of...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it.
First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
| |
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For most users, this new feature is actually very convenient. If you want to control the update process,...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules.
He will explain when you may want to use classes instead of User Defined Types (UDT). For example, to manage the data in unbound forms.
Adolph will...
|
by: TSSRALBI |
last post by:
Hello
I'm a network technician in training and I need your help.
I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs.
The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols.
I succeeded, with both firewalls in the same network. But I'm wondering if it's possible to do the same thing, with 2 Pfsense firewalls...
|
by: adsilva |
last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
|
by: muto222 |
last post by:
How can i add a mobile payment intergratation into php mysql website.
| |
by: bsmnconsultancy |
last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...
| |