IOCTL_STORAGE_Q UERY_PROPERTY and the STORAGE_BUS_TYP E data type

[GhostHouse]

Would appreciate any help with some test code I'm trying to write. I'm trying
to figure out how to use the IOCTL_STORAGE_Q UERY_PROPERTY stuff correctly when
querying a device/adapter. I've gone through the DDK and SDK and am still
stumped. Basically, the following code just gets a handle to the first physical
drive and calls the IOCTL_STORAGE_Q UERY_PROPERTY IO Control, and then dumps out
the result. It seems to work fine except that I had to alter one of the default
struct definitions which I originally got from the DDK. I had to change the
line "STORAGE_BUS_TY PE BusType;" to "USHORT BusType;" for the
STORAGE_ADAPTER _DESCRIPTOR structure. If I don't change this line, the BusType
value doesn't seem to come back correctly. I think I've narrowed it down to the
fact that enums are ints(4 bytes) when it seems to be returning the bustype back
as a 2 byte value(hence why I had to use USHORT). The following is an extract
of what the result is when I've got the BusType as USHORT:

Version: 32
Size: 32
MaxTransferLeng th: 131072
MaximumPhysical Pages: -1
AlignmentMask: 1
AdapterUsesPio: 1
AdapterScansDow n: 0
CommandQueueing : 0
AcceleratedTran sfer: 0
BusType: 3
BusMajorVersion : 1
BusMinorVersion : 0
ATA Drive Found
ATA Drive: 3
1394 Drive: 4
Unknown Drive: 127
SIZE Of STORAGE_BUS_TYP E: 4
SIZE Of USHORT: 2
SIZE Of INT: 4
SIZE Of ULONG: 4
SIZE Of BOOLEAN: 1

When I have the BusType as STORAGE_BUS_TYP E, I get the following, which doesn't
seem right
Version: 32
Size: 32
MaxTransferLeng th: 131072
MaximumPhysical Pages: -1
AlignmentMask: 1
AdapterUsesPio: 1
AdapterScansDow n: 0
CommandQueueing : 0
AcceleratedTran sfer: 0
BusType: 65539
BusMajorVersion : 0
BusMinorVersion : 0
ATA Drive: 3
1394 Drive: 4
Unknown Drive: 127
SIZE Of STORAGE_BUS_TYP E: 4
SIZE Of USHORT: 2
SIZE Of INT: 4
SIZE Of ULONG: 4
SIZE Of BOOLEAN: 1

Would appreciate if anyone who's experienced with this could shed some light on
this. Thanks

Relevant extract of code follows:
#define IOCTL_STORAGE_Q UERY_PROPERTY CTL_CODE(IOCTL_ STORAGE_BASE, 0x0500,
METHOD_BUFFERED , FILE_ANY_ACCESS )

typedef enum _STORAGE_BUS_TY PE {
BusTypeUnknown = 0x00,
BusTypeScsi,
BusTypeAtapi,
BusTypeAta,
BusType1394,
BusTypeSsa,
BusTypeFibre,
BusTypeUsb,
BusTypeRAID,
BusTypeMaxReser ved = 0x7F
} STORAGE_BUS_TYP E, *PSTORAGE_BUS_T YPE;

typedef struct _STORAGE_ADAPTE R_DESCRIPTOR {
ULONG Version;
ULONG Size;
ULONG MaximumTransfer Length;
ULONG MaximumPhysical Pages;
ULONG AlignmentMask;
BOOLEAN AdapterUsesPio;
BOOLEAN AdapterScansDow n;
BOOLEAN CommandQueueing ;
BOOLEAN AcceleratedTran sfer;
//??Should this be a storage bus type or a Ushort?
//STORAGE_BUS_TYP E BusType;
USHORT BusType;
USHORT BusMajorVersion ;
USHORT BusMinorVersion ;
} STORAGE_ADAPTER _DESCRIPTOR, *PSTORAGE_ADAPT ER_DESCRIPTOR;

int GetDiskDetails( )
{
HANDLE hDevice; // handle to the drive to be examined
STORAGE_PROPERT Y_QUERY Query; // input param for query
DWORD dwOutBytes; // IOCTL output length
BOOL bResult; // IOCTL return val

STORAGE_ADAPTER _DESCRIPTOR AdapDesc;
PSTORAGE_ADAPTE R_DESCRIPTOR pAdapDesc;

hDevice = CreateFile("\\\ \.\\PhysicalDri ve0", // drive to open
0, // no access to the drive
FILE_SHARE_READ | // share mode
FILE_SHARE_WRIT E,
NULL, // default security attributes
OPEN_EXISTING, // disposition
0, // file attributes
NULL); // do not copy file attributes

if (hDevice == INVALID_HANDLE_ VALUE) // cannot open the drive
{
puts("Bad Name to open");
return (FALSE);
}

// specify the query type
Query.PropertyI d = StorageAdapterP roperty ;
Query.QueryType = PropertyStandar dQuery;

pAdapDesc = &AdapDesc;
pAdapDesc->Size = sizeof(STORAGE_ ADAPTER_DESCRIP TOR);

// Query using IOCTL_STORAGE_Q UERY_PROPERTY
bResult = DeviceIoControl (hDevice, // device handle
IOCTL_STORAGE_Q UERY_PROPERTY, // info of device property
&Query, sizeof(STORAGE_ PROPERTY_QUERY) , // input data buffer
pAdapDesc, pAdapDesc->Size, // output data buffer
&dwOutBytes, // out's length
(LPOVERLAPPED)N ULL);

if(bResult)
{
puts("Good");

printf("Version : %ld\n",pAdapDes c->Version);
printf("Size: %ld\n",pAdapDes c->Size);
printf("MaxTran sferLength: %ld\n",pAdapDes c->MaximumTransfe rLength);
printf("Maximum PhysicalPages: %ld\n",pAdapDes c->MaximumPhysica lPages);
printf("Alignme ntMask: %ld\n",pAdapDes c->AlignmentMask) ;
printf("Adapter UsesPio: %ld\n",pAdapDes c->AdapterUsesPio );
printf("Adapter ScansDown: %ld\n",pAdapDes c->AdapterScansDo wn);
printf("Command Queueing: %ld\n",pAdapDes c->CommandQueuein g);
printf("Acceler atedTransfer: %ld\n",pAdapDes c->AcceleratedTra nsfer);
printf("BusType : %ld\n",pAdapDes c->BusType);
printf("BusMajo rVersion: %ld\n",pAdapDes c->BusMajorVersio n);
printf("BusMino rVersion: %ld\n",pAdapDes c->BusMinorVersio n);

if(pAdapDesc->BusType == BusTypeAta)
puts("ATA Drive Found");

printf("ATA Drive: %d\n",BusTypeAt a);
printf("1394 Drive: %d\n",BusType13 94);
printf("Unknown Drive: %d\n",BusTypeMa xReserved);

printf("SIZE Of STORAGE_BUS_TYP E: %d\n",sizeof(ST ORAGE_BUS_TYPE) );
printf("SIZE Of USHORT: %d\n",sizeof(US HORT));
printf("SIZE Of INT: %d\n",sizeof(in t));
printf("SIZE Of CHAR: %d\n",sizeof(ch ar));
}
else
{
puts("Damn");
}

CloseHandle(hDe vice);
return bResult;
}

[Joona I Palaste]

GhostHouse <Gh********@exc ite.com> scribbled the following
on comp.lang.c:

Would appreciate any help with some test code I'm trying to write. I'm trying
to figure out how to use the IOCTL_STORAGE_Q UERY_PROPERTY stuff correctly when
querying a device/adapter.

This has nothing whatsoever to do with C. Follow-ups set.

--
/-- Joona Palaste (pa*****@cc.hel sinki.fi) ------------- Finland --------\
\-- http://www.helsinki.fi/~palaste --------------------- rules! --------/
"To doo bee doo bee doo."
- Frank Sinatra

[heinz baer]

Do not post things about the DDK in the C language group. Always post
to the most relevant group to keep stuff not of general interest from
cluttering other groups. That's the whole purpose of having a DDK
group.

It seems to work fine except that I had to alter one of the default
struct definitions which I originally got from the DDK.
Never modify the DDK header files! This is why you are having
problems. It will also make upgrading the DDK a lot of unnecessary
work.
I had to change the line "STORAGE_BUS_TY PE BusType;" to
"USHORT BusType;" for the STORAGE_ADAPTER _DESCRIPTOR structure.

The DDK defines it as UCHAR which you should be using. Yes, this is
dumb the DDK does not use its own enum for the purpose. Also you
should ensure structure packing is 8. The DDK headers have problems if
you try to use structure packing other than 8 and indeed this
particular structure is vulnerable (sizeof & field alignment). That's
dumb too, but less effort to just go with Microsoft's guidelines when
you are dealing with the DDK...