Help needed to count lines between preprocessor directives

[Nalla]

Hi,
I want a program. It should be a command line one. you can input the
path of a folder(preferab ly) or a file...it should count the no. of
lines between the compiler directives,
ifdef win32 and # endif.can u pls help me out...

[MikeyD]

> > Not robust or anything, but should work...

And is grossly antisocial. The lack of indentation and the gratuitous use
of filescope variables, and '//' comments on very long lines suggests that
yours is a joke post (but not a very good one). Be that as it may,

gets(filepath); is a terrible thing to suggest. Not even the most clueless poster

deserves to be treated that way.

What? He asked for a program and I gave him one. Not a very good one, but it
would work. No-one else even bothered to write one.

[Mike Wahler]

MikeyD <m_*********@ho tmail.com> wrote in message
news:10******** ********@eunomi a.uk.clara.net. ..

Not robust or anything, but should work...
And is grossly antisocial. The lack of indentation and the gratuitous use of filescope variables, and '//' comments on very long lines suggests that yours is a joke post (but not a very good one). Be that as it may,

gets(filepath);

is a terrible thing to suggest. Not even the most clueless poster

deserves

to be treated that way.

What? He asked for a program and I gave him one. Not a very good one, but

it would work. No-one else even bothered to write one.

Really? My example can beat up your example. :-)

-Mike

[MikeyD]

> > What? He asked for a program and I gave him one. Not a very good one,
but

it

would work. No-one else even bothered to write one.

Really? My example can beat up your example. :-)

-Mike

Sorry, yes, you're right as a general program. But if he just wants to count
between those two particular directives then mine'll be easier for him to
use. I'll just fix it for commandline input, but that was chapter...actua lly
it wasn't in C for dummies at all.
Maybe this should be used as an example of how not to code whilst still
getting a working program.
#include <stdio.h>
char filepath[100];
char tstr[10];
int lines;
FILE* cfile
int main(int whatever, char**notaclue) {
lines=0
if(whatever==1) goto meaninglesslabe l;
printf("I didn't understand the arguments you gave me, so what's the file
then?\n");
gets(filepath);
goto evenworse;
meaninglesslabe l: filepath=notacl ue[1];//or should this be 0? I never really
//worked out how the ags are arranged
evenworse:
cfile=fopen(fil epath, "r");
fseek(cfile,SEE K_SET);//not sure if this is correctly formulated
for(;strcmp(tst r,"#ifdef win32")!=0;fget s(cfile,tstr));//value for strcmp
//may be wrong, fgets args may also be wrong
for(;strcmp(tst r,"#endif")!=0; fgets(cfile,tst r)) lines++;
printf("There were %d lines between the pre-processor commands\n",lin es);
//is this how you want it returned?
return lines; //or return 0;
}

[Martin Ambuhl]

MikeyD wrote:

gets(filepath);

Please stop this. No one deserves to be treated to this antisocial "advise."

--
Martin Ambuhl

[pete]

Martin Ambuhl wrote:

MikeyD wrote:

gets(filepath);

Please stop this.
No one deserves to be treated to this antisocial "advise."

http://www.eskimo.com/~scs/C-faq/q12.23.html

[MikeyD]

"Martin Ambuhl" <ma*****@earthl ink.net> wrote in message
news:Zb******** *******@newsrea d1.news.atl.ear thlink.net...

MikeyD wrote:

gets(filepath);
Please stop this. No one deserves to be treated to this antisocial

"advise."

It's just there as a backup now that I've fixed the commandline bit. There
are flaws with fgets() as well (the site mentions its failure to delete \n
at the end, I'm sure I've read of others) Obviously it's best to use your
own getstring() function but I can't rely on him having my personal function
library. For a utility program like this, gets() is perfectly suitable.
And on what grounds do you claim it's antisocial??

[Irrwahn Grausewitz]

"MikeyD" <m_*********@ho tmail.com> wrote:

"Martin Ambuhl" <ma*****@earthl ink.net> wrote in message
news:Zb******* ********@newsre ad1.news.atl.ea rthlink.net...

MikeyD wrote:

> gets(filepath);

Please stop this. No one deserves to be treated to this antisocial

"advise."

It's just there as a backup now that I've fixed the commandline bit. There
are flaws with fgets() as well (the site mentions its failure to delete \n
at the end, I'm sure I've read of others) Obviously it's best to use your
own getstring() function but I can't rely on him having my personal function
library. For a utility program like this, gets() is perfectly suitable.
And on what grounds do you claim it's antisocial??

gets() is suitable for absolutely nothing, except breaking your code.
And AFICS that's why Martin claimed it antisocial to suggest to use it.

Irrwahn
--
Close your eyes and press escape three times.

[Martin Ambuhl]

MikeyD wrote:

"Martin Ambuhl" <ma*****@earthl ink.net> wrote in message
news:Zb******** *******@newsrea d1.news.atl.ear thlink.net...

MikeyD wrote:

gets(filepat h);
Please stop this. No one deserves to be treated to this antisocial

"advise."

It's just there as a backup now that I've fixed the commandline bit. There
are flaws with fgets() as well (the site mentions its failure to delete \n
at the end, I'm sure I've read of others)

There may be flaws in fgets(), but not deleting '\n' is not one of them.
Dan Pop will probably provide a list of what's *really* wrong (on his vies)
with fgets(). If you think not deleting '\n' is a flaw, then you haven't
been programming long enough.

There is no such thing as using gets "as a backup." Using an inherently
dangerous function that ought never be used is not "a backup."
Obviously it's best to use your
own getstring() function
That's not obvious. There are situation in which having your own
getstring() function has attractions, though.
but I can't rely on him having my personal function
library.
What crap. If you want your own getstring() function just write the damn
thing and stick it in and you will be 100% sure of having it.
For a utility program like this, gets() is perfectly suitable.
Bullshit.
And on what grounds do you claim it's antisocial??

You are suggesting the use of inherently unsafe functions for which use
there is no excuse. Why not just hand out guns to children?


--
Martin Ambuhl

[MikeyD]

Fine then.
#include <stdio.h>
#include <stdlib.h>
char filepath[100];
char tstr[10];
int lines;
FILE* cfile
int main(int whatever, char**notaclue) {
lines=0
if(whatever==1) goto meaninglesslabe l;
printf("I didn't understand the arguments you gave me, so what's the file
then?\n");
for(int i=0;i<100;i++){ filepath[i]=getchar();
if(filepath[i]=='\n'){
filepath[i]='\0';
break;}
if(i==99){
printf("You entered too long a filename");
exit(1);
}}
goto evenworse;
meaninglesslabe l: strcpy(filepath ,notaclue[1]);//or should this be 0? I
never really
//worked out how the ags are arranged
evenworse:
cfile=fopen(fil epath, "r");
fseek(cfile,SEE K_SET);//not sure if this is correctly formulated
for(;strcmp(tst r,"#ifdef win32")!=0;fget s(cfile,tstr));//value for strcmp
//may be wrong, fgets args may also be wrong
for(;strcmp(tst r,"#endif")!=0; fgets(cfile,tst r)) lines++;
printf("There were %d lines between the pre-processor commands\n",lin es);
//is this how you want it returned?
return lines; //or return 0;
}
Happy now?

[James Kew]

"MikeyD" <m_*********@ho tmail.com> wrote in message
news:10******** ********@dyke.u k.clara.net...

char tstr[10]; [...] cfile=fopen(fil epath, "r");
fseek(cfile,SEE K_SET);//not sure if this is correctly formulated
Or indeed even needed -- why seek to the beginning a file you've just
opened?
for(;strcmp(tst r,"#ifdef win32")!=0;fget s(cfile,tstr));//value for strcmp

tstr is undefined for the first iteration here.

James