HELP!

[bex]

what is wrong with this, i'm stumped and gettin nowhere :-(

CPP FILE

// Serial.cpp

#include <stdio>
#include <stdexcept>
#include "Serial.h"
CSerial::CSeria l()
{

memset( &m_OverlappedRe ad, 0, sizeof( OVERLAPPED ) );
memset( &m_OverlappedWr ite, 0, sizeof( OVERLAPPED ) );
m_hIDComDev = NULL;
m_bOpened = false;

}

CSerial::~CSeri al()
{

Close(void);

}

BOOL CSerial::Open( int nPort, int nBaud )
{

if( m_bOpened ) return( true );

char szPort[15];
char szComParams[50];
DCB dcb;

wsprintf( szPort, "COM%d", nPort );
m_hIDComDev = CreateFile( szPort, GENERIC_READ | GENERIC_WRITE, 0, NULL,
OPEN_EXISTING, FILE_ATTRIBUTE_ NORMAL | FILE_FLAG_OVERL APPED, NULL );
if( m_hIDComDev == NULL ) return( false );

memset( &m_OverlappedRe ad, 0, sizeof( OVERLAPPED ) );
memset( &m_OverlappedWr ite, 0, sizeof( OVERLAPPED ) );

COMMTIMEOUTS CommTimeOuts;
CommTimeOuts.Re adIntervalTimeo ut = 0xFFFFFFFF;
CommTimeOuts.Re adTotalTimeoutM ultiplier = 0;
CommTimeOuts.Re adTotalTimeoutC onstant = 0;
CommTimeOuts.Wr iteTotalTimeout Multiplier = 0;
CommTimeOuts.Wr iteTotalTimeout Constant = 5000;
SetCommTimeouts ( m_hIDComDev, &CommTimeOut s );

wsprintf( szComParams, "COM%d:%d,n,8,1 ", nPort, nBaud );

m_OverlappedRea d.hEvent = CreateEvent( NULL, TRUE, FALSE, NULL );
m_OverlappedWri te.hEvent = CreateEvent( NULL, TRUE, FALSE, NULL );

dcb.DCBlength = sizeof( DCB );
GetCommState( m_hIDComDev, &dcb );
dcb.BaudRate = nBaud;
dcb.ByteSize = 8;
unsigned char ucSet;
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_DTRDSR ) != 0 );
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_RTSCTS ) != 0 );
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_XONXOFF ) != 0 );
if( !SetCommState( m_hIDComDev, &dcb ) ||
!SetupComm( m_hIDComDev, 10000, 10000 ) ||
m_OverlappedRea d.hEvent == NULL ||
m_OverlappedWri te.hEvent == NULL ){
DWORD dwError = GetLastError();
if( m_OverlappedRea d.hEvent != NULL ) CloseHandle(
m_OverlappedRea d.hEvent );
if( m_OverlappedWri te.hEvent != NULL ) CloseHandle(
m_OverlappedWri te.hEvent );
CloseHandle( m_hIDComDev );
return( false );
}

m_bOpened = TRUE;

return( m_bOpened );

}

BOOL CSerial::Close( void )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( TRUE );

if( m_OverlappedRea d.hEvent != NULL ) CloseHandle(
m_OverlappedRea d.hEvent );
if( m_OverlappedWri te.hEvent != NULL ) CloseHandle(
m_OverlappedWri te.hEvent );
CloseHandle( m_hIDComDev );
m_bOpened = FALSE;
m_hIDComDev = NULL;

return( true );

}

BOOL CSerial::WriteC ommByte( unsigned char ucByte )
{
BOOL bWriteStat;
DWORD dwBytesWritten;

bWriteStat = WriteFile( m_hIDComDev, (LPSTR) &ucByte, 1, &dwBytesWritten ,
&m_OverlappedWr ite );
if( !bWriteStat && ( GetLastError() == ERROR_IO_PENDIN G ) ){
if( WaitForSingleOb ject( m_OverlappedWri te.hEvent, 1000 ) ) dwBytesWritten
= 0;
else{
GetOverlappedRe sult( m_hIDComDev, &m_OverlappedWr ite, &dwBytesWritten ,
FALSE );
m_OverlappedWri te.Offset += dwBytesWritten;
}
}

return( true );

}

int CSerial::SendDa ta( const char *buffer, int size )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

DWORD dwBytesWritten = 0;
int i;
for( i=0; i<size; i++ ){
WriteCommByte( buffer[i] );
dwBytesWritten+ +;
}

return( (int) dwBytesWritten );

}

int CSerial::ReadDa taWaiting( void )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

DWORD dwErrorFlags;
COMSTAT ComStat;

ClearCommError( m_hIDComDev, &dwErrorFlag s, &ComStat );

return( (int) ComStat.cbInQue );

}

int CSerial::ReadDa ta( void *buffer, int limit )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

BOOL bReadStatus;
DWORD dwBytesRead, dwErrorFlags;
COMSTAT ComStat;

ClearCommError( m_hIDComDev, &dwErrorFlag s, &ComStat );
if( !ComStat.cbInQu e ) return( 0 );

dwBytesRead = (DWORD) ComStat.cbInQue ;
if( limit < (int) dwBytesRead ) dwBytesRead = (DWORD) limit;

bReadStatus = ReadFile( m_hIDComDev, buffer, dwBytesRead, &dwBytesRead ,
&m_OverlappedRe ad );
if( !bReadStatus ){
if( GetLastError() == ERROR_IO_PENDIN G ){
WaitForSingleOb ject( m_OverlappedRea d.hEvent, 2000 );
return( (int) dwBytesRead );
}
return( 0 );
}

return( (int) dwBytesRead );

}

HEADER FILE

// Serial.h

#ifndef __SERIAL_H__
#define __SERIAL_H__

#define FC_DTRDSR 0x01
#define FC_RTSCTS 0x02
#define FC_XONXOFF 0x04
#define ASCII_BEL 0x07
#define ASCII_BS 0x08
#define ASCII_LF 0x0A
#define ASCII_CR 0x0D
#define ASCII_XON 0x11
#define ASCII_XOFF 0x13

class CSerial
{

public:
CSerial();
~CSerial();

BOOL (Open( int nPort, int nBaud));
BOOL (Close( void ));

int ReadData( void *, int );
int SendData( const char *, int );
int ReadDataWaiting ( void );

BOOL (IsOpened( void ){return( m_bOpened )});

protected:
BOOL (WriteCommByte( unsigned char ));

HANDLE (m_hIDComDev);
OVERLAPPED ((m_OverlappedR ead)(m_Overlapp edWrite));
BOOL (m_bOpened);

};

#endif

[David]

bex,

Could you give us a hint as to what you think is wrong? What problem
are you encountering?

David

On Mon, 26 Apr 2004 09:13:52 UTC, "bex" <be***@ppmsolut ions.co.uk> wrote:

what is wrong with this, i'm stumped and gettin nowhere :-(

CPP FILE

// Serial.cpp

#include <stdio>
#include <stdexcept>
#include "Serial.h"
CSerial::CSeria l()
{

memset( &m_OverlappedRe ad, 0, sizeof( OVERLAPPED ) );
memset( &m_OverlappedWr ite, 0, sizeof( OVERLAPPED ) );
m_hIDComDev = NULL;
m_bOpened = false;

}

CSerial::~CSeri al()
{

Close(void);

}

BOOL CSerial::Open( int nPort, int nBaud )
{

if( m_bOpened ) return( true );

char szPort[15];
char szComParams[50];
DCB dcb;

wsprintf( szPort, "COM%d", nPort );
m_hIDComDev = CreateFile( szPort, GENERIC_READ | GENERIC_WRITE, 0, NULL,
OPEN_EXISTING, FILE_ATTRIBUTE_ NORMAL | FILE_FLAG_OVERL APPED, NULL );
if( m_hIDComDev == NULL ) return( false );

memset( &m_OverlappedRe ad, 0, sizeof( OVERLAPPED ) );
memset( &m_OverlappedWr ite, 0, sizeof( OVERLAPPED ) );

COMMTIMEOUTS CommTimeOuts;
CommTimeOuts.Re adIntervalTimeo ut = 0xFFFFFFFF;
CommTimeOuts.Re adTotalTimeoutM ultiplier = 0;
CommTimeOuts.Re adTotalTimeoutC onstant = 0;
CommTimeOuts.Wr iteTotalTimeout Multiplier = 0;
CommTimeOuts.Wr iteTotalTimeout Constant = 5000;
SetCommTimeouts ( m_hIDComDev, &CommTimeOut s );

wsprintf( szComParams, "COM%d:%d,n,8,1 ", nPort, nBaud );

m_OverlappedRea d.hEvent = CreateEvent( NULL, TRUE, FALSE, NULL );
m_OverlappedWri te.hEvent = CreateEvent( NULL, TRUE, FALSE, NULL );

dcb.DCBlength = sizeof( DCB );
GetCommState( m_hIDComDev, &dcb );
dcb.BaudRate = nBaud;
dcb.ByteSize = 8;
unsigned char ucSet;
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_DTRDSR ) != 0 );
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_RTSCTS ) != 0 );
ucSet = (unsigned char) ( ( FC_RTSCTS & FC_XONXOFF ) != 0 );
if( !SetCommState( m_hIDComDev, &dcb ) ||
!SetupComm( m_hIDComDev, 10000, 10000 ) ||
m_OverlappedRea d.hEvent == NULL ||
m_OverlappedWri te.hEvent == NULL ){
DWORD dwError = GetLastError();
if( m_OverlappedRea d.hEvent != NULL ) CloseHandle(
m_OverlappedRea d.hEvent );
if( m_OverlappedWri te.hEvent != NULL ) CloseHandle(
m_OverlappedWri te.hEvent );
CloseHandle( m_hIDComDev );
return( false );
}

m_bOpened = TRUE;

return( m_bOpened );

}

BOOL CSerial::Close( void )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( TRUE );

if( m_OverlappedRea d.hEvent != NULL ) CloseHandle(
m_OverlappedRea d.hEvent );
if( m_OverlappedWri te.hEvent != NULL ) CloseHandle(
m_OverlappedWri te.hEvent );
CloseHandle( m_hIDComDev );
m_bOpened = FALSE;
m_hIDComDev = NULL;

return( true );

}

BOOL CSerial::WriteC ommByte( unsigned char ucByte )
{
BOOL bWriteStat;
DWORD dwBytesWritten;

bWriteStat = WriteFile( m_hIDComDev, (LPSTR) &ucByte, 1, &dwBytesWritten ,
&m_OverlappedWr ite );
if( !bWriteStat && ( GetLastError() == ERROR_IO_PENDIN G ) ){
if( WaitForSingleOb ject( m_OverlappedWri te.hEvent, 1000 ) ) dwBytesWritten
= 0;
else{
GetOverlappedRe sult( m_hIDComDev, &m_OverlappedWr ite, &dwBytesWritten ,
FALSE );
m_OverlappedWri te.Offset += dwBytesWritten;
}
}

return( true );

}

int CSerial::SendDa ta( const char *buffer, int size )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

DWORD dwBytesWritten = 0;
int i;
for( i=0; i<size; i++ ){
WriteCommByte( buffer[i] );
dwBytesWritten+ +;
}

return( (int) dwBytesWritten );

}

int CSerial::ReadDa taWaiting( void )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

DWORD dwErrorFlags;
COMSTAT ComStat;

ClearCommError( m_hIDComDev, &dwErrorFlag s, &ComStat );

return( (int) ComStat.cbInQue );

}

int CSerial::ReadDa ta( void *buffer, int limit )
{

if( !m_bOpened || m_hIDComDev == NULL ) return( 0 );

BOOL bReadStatus;
DWORD dwBytesRead, dwErrorFlags;
COMSTAT ComStat;

ClearCommError( m_hIDComDev, &dwErrorFlag s, &ComStat );
if( !ComStat.cbInQu e ) return( 0 );

dwBytesRead = (DWORD) ComStat.cbInQue ;
if( limit < (int) dwBytesRead ) dwBytesRead = (DWORD) limit;

bReadStatus = ReadFile( m_hIDComDev, buffer, dwBytesRead, &dwBytesRead ,
&m_OverlappedRe ad );
if( !bReadStatus ){
if( GetLastError() == ERROR_IO_PENDIN G ){
WaitForSingleOb ject( m_OverlappedRea d.hEvent, 2000 );
return( (int) dwBytesRead );
}
return( 0 );
}

return( (int) dwBytesRead );

}

HEADER FILE

// Serial.h

#ifndef __SERIAL_H__
#define __SERIAL_H__

#define FC_DTRDSR 0x01
#define FC_RTSCTS 0x02
#define FC_XONXOFF 0x04
#define ASCII_BEL 0x07
#define ASCII_BS 0x08
#define ASCII_LF 0x0A
#define ASCII_CR 0x0D
#define ASCII_XON 0x11
#define ASCII_XOFF 0x13

class CSerial
{

public:
CSerial();
~CSerial();

BOOL (Open( int nPort, int nBaud));
BOOL (Close( void ));

int ReadData( void *, int );
int SendData( const char *, int );
int ReadDataWaiting ( void );

BOOL (IsOpened( void ){return( m_bOpened )});

protected:
BOOL (WriteCommByte( unsigned char ));

HANDLE (m_hIDComDev);
OVERLAPPED ((m_OverlappedR ead)(m_Overlapp edWrite));
BOOL (m_bOpened);

};

#endif

[John Harrison]

"David" <Fl************ @United.Com> wrote in message
news:rOdGr40LMP U3-pn2-UhdE1wuJ65zy@lo calhost...

bex,

Could you give us a hint as to what you think is wrong? What problem
are you encountering?

David

C'mon David, its obvious what's wrong, it doesn't work.

john

[Buster]

bex wrote:

what is wrong with this, i'm stumped and gettin nowhere :-(

You can do better than that. Read the welcome message and the posting
guidelines in the FAQ. Search the web for "C++ welcome message" and
"C++ FAQ". There's also an article about asking good questions on usenet
which you can find in the same way (it is by Eric Steven Raymond).

--
Regards,
Buster.

[myName]

?? What's wrong where ? u didn't mention what problem u r facing ..

bex wrote:

what is wrong with this, i'm stumped and gettin nowhere :-(

[JKop]

As implied in your post, I pressume that when you hit "compile",
custard is oozing out of your printer. This is most likely a problem
with Microsoft Windows, not specifically with your code.

If you have any other problems with your code, please feel free to
elaborate on them. Two kinds of problem I predict:
A) Compile/Link error. There's an error in your code, eg. syntax
error, type mismatch. You're not even getting an executable file.

B) You are getting an executable file, but your calls to the Win32API
aren't working as you would like.
In the case of A: People here will be glad to help you if you tell us
what errors you're getting.
In the case of B: Connect to the news server, "msnews.microso ft.com",
and go to the newsgroup "microsoft.publ ic.win32.progra mmer.kernel",
where experts will be more than happy to help.

-JKop

[Thomas Matthews]

myName wrote:

?? What's wrong where ? u didn't mention what problem u r facing ..

Y du u not shrtn al the words?
"Mention" s bigr den "you" or "are".

I am really curious why these people can't take the time to
write in the full written language. Why do they abbreviate
the small words but not the longer ones? I thought that
abbreviations were to make the longer words short.

--
Thomas Matthews

C++ newsgroup welcome message:
http://www.slack.net/~shiva/welcome.txt
C++ Faq: http://www.parashift.com/c++-faq-lite
C Faq: http://www.eskimo.com/~scs/c-faq/top.html
alt.comp.lang.l earn.c-c++ faq:
http://www.raos.demon.uk/acllc-c++/faq.html
Other sites:
http://www.josuttis.com -- C++ STL Library book

[John M. Gabriele]

Buster wrote:

bex wrote:

what is wrong with this, i'm stumped and gettin nowhere :-(

You can do better than that. Read the welcome message and the posting
guidelines in the FAQ. Search the web for "C++ welcome message" and
"C++ FAQ". There's also an article about asking good questions on usenet
which you can find in the same way (it is by Eric Steven Raymond).

http://www.catb.org/~esr/faqs/smart-questions.html

--
Regards,
Buster.

--
--- remove zees if contacting via email ---