do/while false

[Angus Graham]

Hi:

I've recently come across a number of programmers who use the following
type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
while (false);
delete pFish;
This is effective but seems to me to be bad style. The do/while loop
isn't really a loop at all which is misleading. The same could be
achieved with a boolean flag.

e.g.,

bool bSuccess = CatchFish(pFish );
if (bSuccess) {
bSuccess = CleanFish(pFish );
}
etc.

Exceptions are not being used because we are assuming that the methods
can return false under non-exceptional circumstances.

Any comments on this sort of do/while (false) style?

Angus.

[Aggro]

Angus Graham wrote:

Hi:

I've recently come across a number of programmers who use the following
type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
while (false);
delete pFish;

What's wrong with if - else if?

if (! CatchFish(pFish )) {}
else if (! CleanFish(pFish )) {}
else if (! CookFish(pFish) ) {}
else if (! EatFish(pFish)) {}
delete pFish;

[David Harmon]

On Sat, 14 Feb 2004 12:46:06 -0500 in comp.lang.c++, Angus Graham
<pl************ ****@notme.com> was alleged to have written:

This is effective but seems to me to be bad style. The do/while loop
isn't really a loop at all which is misleading. The same could be

Well, you could do it Perl style...

CatchFish(pFish )
&& CleanFish(pFish )
&& CookFish(pFish)
&& EatFish(pFish);

[AngleWyrm]

"Angus Graham" <pl************ ****@notme.com> wrote in message
news:F9******** ***********@new s20.bellglobal. com...

This is effective but seems to me to be bad style. The do/while loop
isn't really a loop at all which is misleading.

The advantage of a do loop is that it is guaranteed to execute at least
once; but to my mind they imply the possibility of executing more than once.

It reminds me of two other questionable but popular language structures: the
for(;;) loop and the if(true) statement

I avoid their use as well.

[Unforgiven]

Aggro wrote:

Angus Graham wrote:

Hi:

I've recently come across a number of programmers who use the
following type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
Final if() is redundant.
while (false);
delete pFish;
What's wrong with if - else if?

if (! CatchFish(pFish )) {}
else if (! CleanFish(pFish )) {}
else if (! CookFish(pFish) ) {}
else if (! EatFish(pFish)) {}

Here too.
delete pFish;

Or if you want to avoid the empty if statements, at the price of some
nesting:

if( CatchFish(pFish ) )
if( CleanFish(pFish ) )
if( CookFish(pFish) )
EatFish();
delete pFish;

--
Unforgiven
"Most people make generalisations "
Freek de Jonge

[Denis Perelyubskiy]

Angus Graham, 2/14/2004 9:46 AM:

Hi:

I've recently come across a number of programmers who use the following
type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
while (false);
delete pFish;

[...snip...]

I think some people use this sort of thing (perhaps not in as simple a
context as this) as a substitute for 'goto'.

denis

[Alf P. Steinbach]

On Sat, 14 Feb 2004 12:46:06 -0500, Angus Graham <pl************ ****@notme.com> wrote:

I've recently come across a number of programmers who use the following
type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
while (false);
delete pFish;
Well, they don't know shit about programming. Should have used a
std::auto_ptr here. That code is not exception-safe.
This is effective but seems to me to be bad style.
Yep.
The do/while loop
isn't really a loop at all which is misleading. The same could be
achieved with a boolean flag.

e.g.,

bool bSuccess = CatchFish(pFish );
if (bSuccess) {
bSuccess = CleanFish(pFish );
}
Hungarian notation is [censored derogatory expression].

And succcess/failure flags are seldom useful for anything.

Use a simple if-else.
Any comments on this sort of do/while (false) style?

The do-while style is useful in macros, allowing a macro to be used
as a statement in all cases where C/C++ allows a statement.

[John Kewley]

> ...

while (false);
delete pFish;
Well, they don't know s*!t about programming. Should have used a

Why use foul language here, and then censor yourself when
referring to Hungarian notation?
... Hungarian notation is [censored derogatory expression].

And succcess/failure flags are seldom useful for anything.
Very useful in making sense of a more complicated if then else where
it is harder to ensure a single "else" part.
Use a simple if-else.
Agreed, this would make most sense.

Any comments on this sort of do/while (false) style?

I think it was the mid 1960s when goto-less programs were championed, this
seems to be a throwback to then :-)
The do-while style is useful in macros, allowing a macro to be used
as a statement in all cases where C/C++ allows a statement.

Agreed - an excellent use of "do ... while (0);" (assuming you have
suitable
justification for using macros in the 1st place :-)

JK

[Alf P. Steinbach]

On Mon, 16 Feb 2004 16:34:20 -0000, "John Kewley" <j.******@dl.ac .uk> wrote:

...

>while (false);
>delete pFish;

Well, they don't know s*!t about programming. Should have used a

Why use foul language here, and then censor yourself when
referring to Hungarian notation?

I thought what I was about to write about Hungarian notation would
qualify as foul language... ;-)

[Old Wolf]

> > I've recently come across a number of programmers who use the following

type of do/while(false) structure quite often:

do {
if (! CatchFish(pFish )) {
break;
}
if (! CleanFish(pFish )) {
break;
}
if (! CookFish(pFish) ) {
break;
}
if (! EatFish(pFish)) {
break;
}
while (false);
delete pFish;

What's wrong with if - else if?

if (! CatchFish(pFish )) {}
else if (! CleanFish(pFish )) {}
else if (! CookFish(pFish) ) {}
else if (! EatFish(pFish)) {}
delete pFish;

This form doesn't let you insert extra statements without obfuscation;
eg. if you wanted to perform some series of non-checked actions
in between the cleaning and the cooking

To the OP: using try...catch is a bit less verbose,
especially if you want to know what the failure reason was at
the end of the code.